Disabled validators runtime API by tdimitrov · Pull Request #1257 · paritytech/polkadot-sdk

tdimitrov · 2023-08-29T12:30:46Z

Exposes disabled validators list via a runtime API.

paritytech-cicd-pr · 2023-09-16T08:35:04Z

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3716470

ordian · 2023-09-27T14:00:25Z

polkadot/runtime/parachains/src/runtime_api_impl/vstaging.rs

+	<pallet_session::Pallet<T>>::disabled_validators()
+		.iter()
+		.cloned()
+		.map(|v| ValidatorIndex(v))


I don't think that's correct since the type ValidatorIndex implies shuffling (and currently truncation to max_validators) done in the shared pallet. Session indices are raw.

* master: (61 commits) OpenGov in Westend and Rococo (#1177) Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720) Migrate polkadot-primitives to v6 (#1543) genesis-builder: implemented for all runtimes (#1492) `BlockId` removal: `tx-pool` refactor (#1678) Bump directories from 4.0.1 to 5.0.1 (#1656) Allow debug_assertions in short-benchmarks CI job (#1711) chainHead/storage: Fix storage iteration using the query key (#1665) Implement more useful traits in `Slot` type (#1595) Make downloads in parallel and give more time to complete (#1699) Bump actions/checkout from 4.0.0 to 4.1.0 (#1688) contracts: Fix incorrect storage alias in mirgration (#1687) Fix documentation about justification and `finalized == true` requirement (#1607) tweak pallet macro (genesis_config etc) to cater for RA users as well. (#1689) Uncoupling pallet-xcm from frame-system's RuntimeCall (#1684) Bump aes-gcm from 0.10.2 to 0.10.3 (#1681) docs / Update PR template to reflect monorepo (#1674) update contributing guide and ui-tests scripts (#1668) pallet epm: add `TrimmingStatus` to the mined solution (#1659) Update HRMP pallet benchmarking to use benchmarks v2 (#1676) ...

polkadot/primitives/src/runtime_api.rs

BradleyOlson64

Looks good to me 👍

polkadot/runtime/parachains/src/runtime_api_impl/vstaging.rs

AndreiEres

lgtm

AndreiEres · 2023-09-28T09:03:41Z

polkadot/node/core/runtime-api/src/cache.rs

+		&mut self,
+		relay_parent: &Hash,
+	) -> Option<&Vec<ValidatorIndex>> {
+		self.disabled_validators.get(relay_parent).map(|v| &*v)


Out of curiosity, what that .map(|v| &*v) does?

It converts &mut to &

eskimor · 2023-09-28T15:55:59Z

cumulus/client/relay-chain-rpc-interface/src/rpc_client.rs

 			.await
 	}

+	pub async fn parachain_host_disabled_validators(


Still not sure why we need to expose everything via RPC. I personally would limit the public facing APIs as much as possible. Anything that is exposed, we need to assume we can not change it without breaking things.

The very least we should communicate clearly that these RPC calls are an unstable feature, which might change anytime.

paritytech/cumulus#2160 (comment)

Well, I agree we should limit the scope for collators. But this is out of scope (hehe) of this PR.

* master: (24 commits) Init System Parachain storage versions and add migration check jobs to CI (#1344) no-bound derives: Use absolute path for `core` (#1763) migrate alliance, fast-unstake and bags list to use derive-impl (#1636) Tvl pool staking (#1322) improve service error (#1734) frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717) Point documentation links to monorepo (#1741) [NPoS] Fix for Reward Deficit in the pool (#1255) Move import queue from `ChainSync` to `SyncingEngine` (#1736) Enable mocking contracts (#1331) Revert "fix(review-bot): pull secrets from `master` environment" (#1748) Remove kusama and polkadot runtime crates (#1731) Use `Extensions` to register offchain worker custom extensions (#1719) [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666) fix(review-bot): pull secrets from `master` environment (#1745) Fix `subkey inspect` output text padding (#1744) archive: Implement height, hashByHeight and call (#1582) rpc/client: Propagate `rpc_methods` method to reported methods (#1713) rococo-runtime: `RococoGenesisExt` removed (#1490) PVF: more filesystem sandboxing (#1373) ...

tdimitrov · 2023-10-09T09:12:16Z

@eskimor @ordian should we merge this?

ordian · 2023-10-09T09:17:42Z

no objection from me

* master: (54 commits) Publish `xcm-emulator` crate (#1881) Adding migrations to clean Rococo Gov 1 storage & reserved funds (#1849) Arkworks Elliptic Curve utils overhaul (#1870) Fix typos (#1878) fix: GoAhead signal only set when runtime upgrade is enacted from parachain side (#1176) Refactor staking ledger (#1484) Paired-key Crypto Scheme (#1705) Include polkadot version in artifact path (#1828) add link to rfc-0001 in broker README (#1862) Discard `Executor` (#1855) Macros to use path instead of ident (#1474) Remove clippy clone-double-ref lint noise (#1860) Refactor alliance benchmarks to v2 (#1868) Check executor params coherence (#1774) frame: use derive-impl for beefy and mmr pallets (#1867) sc-consensus-beefy: improve gossip logic (#1852) Adds instance support for composite enums (#1857) Fix links to implementers' guide (#1865) Disabled validators runtime API (#1257) Adding `try_state` hook for `Treasury` pallet (#1820) ...

…ribution * tsv-disabling-backing: (54 commits) Publish `xcm-emulator` crate (#1881) Adding migrations to clean Rococo Gov 1 storage & reserved funds (#1849) Arkworks Elliptic Curve utils overhaul (#1870) Fix typos (#1878) fix: GoAhead signal only set when runtime upgrade is enacted from parachain side (#1176) Refactor staking ledger (#1484) Paired-key Crypto Scheme (#1705) Include polkadot version in artifact path (#1828) add link to rfc-0001 in broker README (#1862) Discard `Executor` (#1855) Macros to use path instead of ident (#1474) Remove clippy clone-double-ref lint noise (#1860) Refactor alliance benchmarks to v2 (#1868) Check executor params coherence (#1774) frame: use derive-impl for beefy and mmr pallets (#1867) sc-consensus-beefy: improve gossip logic (#1852) Adds instance support for composite enums (#1857) Fix links to implementers' guide (#1865) Disabled validators runtime API (#1257) Adding `try_state` hook for `Treasury` pallet (#1820) ...

* merge all similar update_conversion_rate functions * stall timeout in conversion rate update loop * fmt * fix

tdimitrov added 2 commits September 4, 2023 14:14

Add disabled_validators in staging runtime api

800d8e5

Cumulus changes

936216d

tdimitrov force-pushed the tsv-disabling-node-side branch from 3ee35c8 to 936216d Compare September 4, 2023 11:14

tdimitrov added 3 commits September 4, 2023 15:45

Merge branch 'master' into tsv-disabling-node-side

eaca5ed

Fix compilation errors

e4dee17

Merge branch 'master' into tsv-disabling-node-side

0d0129c

tdimitrov mentioned this pull request Sep 15, 2023

Handling of disabled validators in backing subsystem #1259

Merged

Merge branch 'master' into tsv-disabling-node-side

5e7655f

ordian reviewed Sep 27, 2023

View reviewed changes

ordian added 4 commits September 27, 2023 17:18

implement disabled_validators correctly

70dc6b6

add a CAVEAT comment

bca3c83

cargo fmt

f717d0b

ordian added the T4-runtime_API This PR/Issue is related to runtime APIs. label Sep 27, 2023

ordian reviewed Sep 27, 2023

View reviewed changes

polkadot/primitives/src/runtime_api.rs Outdated Show resolved Hide resolved

Clarify docs

2a5af89

BradleyOlson64 approved these changes Sep 27, 2023

View reviewed changes

polkadot/runtime/parachains/src/runtime_api_impl/vstaging.rs Show resolved Hide resolved

tdimitrov changed the title ~~Node side changes for validator disabling~~ Disabled validators runtime API Sep 28, 2023

tdimitrov commented Sep 28, 2023

View reviewed changes

polkadot/runtime/parachains/src/runtime_api_impl/vstaging.rs Show resolved Hide resolved

Merge branch 'master' into tsv-disabling-node-side

2c53894

AndreiEres approved these changes Sep 28, 2023

View reviewed changes

eskimor reviewed Sep 28, 2023

View reviewed changes

tdimitrov marked this pull request as ready for review October 9, 2023 09:11

ordian merged commit 7aace06 into master Oct 12, 2023

ordian deleted the tsv-disabling-node-side branch October 12, 2023 13:01

ordian mentioned this pull request Oct 12, 2023

Filter votes from disabled validators in BackedCandidates in process_inherent_data #1863

Merged

ordian mentioned this pull request Oct 13, 2023

Add availability-recovery from systematic chunks #1644

Merged

10 tasks

kiltbot mentioned this pull request Nov 7, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.2.0 to 1.3.0 KILTprotocol/kilt-node#575

Closed

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

Overkillus linked an issue Jan 17, 2024 that may be closed by this pull request

Disabled Validators Runtime API #2950

Closed

bkchr pushed a commit that referenced this pull request Apr 10, 2024

Mortal conversion rate updater transactions (#1257)

ba2b0b0

* merge all similar update_conversion_rate functions * stall timeout in conversion rate update loop * fmt * fix

This was referenced Jun 5, 2024

Update polkadot-sdk from v1.7.0 to v1.11.0 moondance-labs/tanssi#573

Closed

Update polkadot-sdk from v1.10.0 to v1.11.0 moondance-labs/tanssi#577

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disabled validators runtime API#1257

Disabled validators runtime API#1257
ordian merged 13 commits intomasterfrom
tsv-disabling-node-side

tdimitrov commented Aug 29, 2023 •

edited

Loading

Uh oh!

paritytech-cicd-pr commented Sep 16, 2023

Uh oh!

ordian Sep 27, 2023

Uh oh!

Uh oh!

BradleyOlson64 left a comment

Uh oh!

Uh oh!

Uh oh!

AndreiEres left a comment

Uh oh!

AndreiEres Sep 28, 2023

Uh oh!

ordian Sep 28, 2023

Uh oh!

eskimor Sep 28, 2023

Uh oh!

eskimor Sep 28, 2023

Uh oh!

ordian Sep 28, 2023

Uh oh!

tdimitrov commented Oct 9, 2023

Uh oh!

ordian commented Oct 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

tdimitrov commented Aug 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paritytech-cicd-pr commented Sep 16, 2023

Uh oh!

ordian Sep 27, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BradleyOlson64 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AndreiEres left a comment

Choose a reason for hiding this comment

Uh oh!

AndreiEres Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

ordian Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

eskimor Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

eskimor Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

ordian Sep 28, 2023

Choose a reason for hiding this comment

Uh oh!

tdimitrov commented Oct 9, 2023

Uh oh!

ordian commented Oct 9, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tdimitrov commented Aug 29, 2023 •

edited

Loading