Skip to content

Point documentation links to monorepo#1741

Merged
skunert merged 11 commits intoparitytech:masterfrom
skunert:skunert/monorepo-urls
Sep 29, 2023
Merged

Point documentation links to monorepo#1741
skunert merged 11 commits intoparitytech:masterfrom
skunert:skunert/monorepo-urls

Conversation

@skunert
Copy link
Copy Markdown
Contributor

@skunert skunert commented Sep 28, 2023

Adjusted:

  • Links in markdown files that are referencing docs in the old repos
  • Links in Dockerfiles that were referencing outdated files in new or old repo
  • Some Docker instructions that did not work due to new repo structure
  • Mentioned pull requests were it was easy to find follow ups in the new repository

Not adjusted:

  • Links to issues in the code. When they were transferred they will point to the new one anyways. For stale links we could make another pass. But there are tons of them.
  • Links to old pull requests for reference.
  • Links to code files in the old repos. Ideally they would point to the new repo, but for this we should check that the description is still correct.

@skunert skunert added the T11-documentation This PR/Issue is related to documentation. label Sep 28, 2023
@skunert skunert requested a review from a team September 28, 2023 14:04
@skunert skunert requested a review from athei as a code owner September 28, 2023 14:04
@skunert skunert requested review from a team September 28, 2023 14:04
@paritytech-ci paritytech-ci requested review from a team September 28, 2023 14:05
michalkucharczyk
michalkucharczyk reviewed Sep 28, 2023
View reviewed changes
@michalkucharczyk michalkucharczyk requested a review from a team September 28, 2023 14:35
@skunert @michalkucharczyk
Update README.md
c21c831 
Co-authored-by: Michal Kucharczyk <[email protected]>
@paritytech-ci paritytech-ci requested a review from a team September 28, 2023 15:28
chevdor
chevdor approved these changes Sep 28, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside the Dockerfile naming issues.
Those are not due to your PR but it would be nice to fix them as well.

@skunert skunert merged commit 9485b0b into paritytech:master Sep 29, 2023
ordian added a commit that referenced this pull request Oct 3, 2023
@ordian
Merge branch 'master' into tsv-disabling-node-side
a3bcb2f 
* master: (24 commits)
  Init System Parachain storage versions and add migration check jobs to CI (#1344)
  no-bound derives: Use absolute path for `core` (#1763)
  migrate alliance, fast-unstake and bags list to use derive-impl (#1636)
  Tvl pool staking (#1322)
  improve service error (#1734)
  frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717)
  Point documentation links to monorepo (#1741)
  [NPoS] Fix for Reward Deficit in the pool (#1255)
  Move import queue from `ChainSync` to `SyncingEngine` (#1736)
  Enable mocking contracts (#1331)
  Revert "fix(review-bot): pull secrets from `master` environment" (#1748)
  Remove kusama and polkadot runtime crates (#1731)
  Use `Extensions` to register offchain worker custom extensions (#1719)
  [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666)
  fix(review-bot): pull secrets from `master` environment (#1745)
  Fix `subkey inspect` output text padding (#1744)
  archive: Implement height, hashByHeight and call (#1582)
  rpc/client: Propagate `rpc_methods` method to reported methods (#1713)
  rococo-runtime: `RococoGenesisExt` removed (#1490)
  PVF: more filesystem sandboxing (#1373)
  ...
ordian added a commit that referenced this pull request Oct 10, 2023
@ordian
Merge branch 'tsv-disabling-node-side' into tsv-disabling-backing
863fc7d 
* tsv-disabling-node-side: (24 commits)
  Init System Parachain storage versions and add migration check jobs to CI (#1344)
  no-bound derives: Use absolute path for `core` (#1763)
  migrate alliance, fast-unstake and bags list to use derive-impl (#1636)
  Tvl pool staking (#1322)
  improve service error (#1734)
  frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717)
  Point documentation links to monorepo (#1741)
  [NPoS] Fix for Reward Deficit in the pool (#1255)
  Move import queue from `ChainSync` to `SyncingEngine` (#1736)
  Enable mocking contracts (#1331)
  Revert "fix(review-bot): pull secrets from `master` environment" (#1748)
  Remove kusama and polkadot runtime crates (#1731)
  Use `Extensions` to register offchain worker custom extensions (#1719)
  [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666)
  fix(review-bot): pull secrets from `master` environment (#1745)
  Fix `subkey inspect` output text padding (#1744)
  archive: Implement height, hashByHeight and call (#1582)
  rpc/client: Propagate `rpc_methods` method to reported methods (#1713)
  rococo-runtime: `RococoGenesisExt` removed (#1490)
  PVF: more filesystem sandboxing (#1373)
  ...
@kiltbot kiltbot mentioned this pull request Nov 7, 2023
Closed
@ahmadkaouk ahmadkaouk mentioned this pull request Nov 16, 2023
Closed
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@skunert
Point documentation links to monorepo (paritytech#1741)
ed447d1
bkchr pushed a commit that referenced this pull request Apr 10, 2024
@serban300 @bkchr
Remove CliChain::KeyPair (#1741)
4a10ccb
This was referenced Jun 5, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@athei athei Awaiting requested review from athei

+4 more reviewers

@chevdor chevdor chevdor approved these changes

@svyatonik svyatonik svyatonik approved these changes

@sam0x17 sam0x17 sam0x17 approved these changes

@coderobe coderobe coderobe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

T11-documentation This PR/Issue is related to documentation.

Projects

SDK Node
Status: done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@skunert @chevdor @svyatonik @michalkucharczyk @sam0x17 @coderobe @patriciobcs