Update HRMP pallet benchmarking to use benchmarks v2#1676
Merged
Conversation
Increase max_downward_message_size to fix force_clean_hrmp benchmark issue. Increased to 1024. Previously it was inheriting the tests config of 8, which was too small for the message struct. 1KiB randomly chosen as a reasonable number which won't present issues for small changes to the message format.
seadanda
added
T2-pallets
Contributor
Author
|
bot fmt |
|
@seadanda https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3770579 was started for your command Comment |
|
@seadanda Command |
seadanda
changed the title
joepetrowski
approved these changes
Sep 22, 2023
ordian
added a commit
that referenced
this pull request
Sep 27, 2023
* master: (61 commits) OpenGov in Westend and Rococo (#1177) Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720) Migrate polkadot-primitives to v6 (#1543) genesis-builder: implemented for all runtimes (#1492) `BlockId` removal: `tx-pool` refactor (#1678) Bump directories from 4.0.1 to 5.0.1 (#1656) Allow debug_assertions in short-benchmarks CI job (#1711) chainHead/storage: Fix storage iteration using the query key (#1665) Implement more useful traits in `Slot` type (#1595) Make downloads in parallel and give more time to complete (#1699) Bump actions/checkout from 4.0.0 to 4.1.0 (#1688) contracts: Fix incorrect storage alias in mirgration (#1687) Fix documentation about justification and `finalized == true` requirement (#1607) tweak pallet macro (genesis_config etc) to cater for RA users as well. (#1689) Uncoupling pallet-xcm from frame-system's RuntimeCall (#1684) Bump aes-gcm from 0.10.2 to 0.10.3 (#1681) docs / Update PR template to reflect monorepo (#1674) update contributing guide and ui-tests scripts (#1668) pallet epm: add `TrimmingStatus` to the mined solution (#1659) Update HRMP pallet benchmarking to use benchmarks v2 (#1676) ...
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
# Description This PR migrates the staking pallet's benchmarks to the `v2` of pallet benchmarking tooling provided by [`frame_benchmarking`](https://github.com/paritytech/polkadot-sdk/tree/master/substrate/frame/benchmarking). ## Integration N/A ## Review Notes The PR is straightforward, as were #1676 , #1838 and #1868. --------- Co-authored-by: Dónal Murray <donal.murray@parity.io> Co-authored-by: Shawn Tabrizi <shawntabrizi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the HRMP pallet benchmarks to Benchmarks v2 and fixes a small misconfiguration in one benchmark.
Why are these changes needed?
Updates HRMP benchmarks to v2 and force_clean_hrmp does not run otherwise.
How were these changes implemented and what do they affect?
Changes are contained in
polkadot/runtime/parachains/src/hrmp/benchmarking.rsI updated the syntax from v1 to v2 without changing the contents of the benchmarks.
I found an existing runtime issue with the config set in the tests. I explicitly set an increased limit in the benchmark in question and it runs successfully. I chose the limit semi-randomly with enough room that small changes to the message format won't cause any issues.