fix: GoAhead signal only set when runtime upgrade is enacted from parachain side by Daanvdplas · Pull Request #1176 · paritytech/polkadot-sdk

Daanvdplas · 2023-08-25T16:10:06Z

The runtime code of a parachain can be replaced on the relay-chain via:

[cumulus]: enact_authorized_upgrade; this is used for a runtime upgrade when a parachain is not bricked.

[polkadot] (these are used when a parachain is bricked):

force_set_current_code: immediately changes the runtime code of a given para without a pvf check (root).
force_schedule_code_upgrade: schedules a change to the runtime code of a given para including a pvf check of the new code (root).
schedule_code_upgrade: schedules a change to the runtime code of a given para including a pvf check of the new code. Besides root, the parachain or parachain manager can call this extrinsic given that the parachain is unlocked.

Polkadot signals a parachain to be ready for a runtime upgrade through the GoAhead signal.

When in cumulus enact_authorized_upgrade is executed, the same underlying helper function of force_schedule_code_upgrade & schedule_code_upgrade: schedule_code_upgrade, is called on the relay-chain, which sets the GoAhead signal (if the pvf is accepted).

If Cumulus receives the GoAhead signal from polkadot without having the PendingValidationCode ready, it will panic (ref). For enact_authorized_upgrade we know for sure the PendingValidationCode is set. On the contrary, for force_schedule_code_upgrade & schedule_code_upgrade this is not the case.

This PR includes a flag such that the GoAhead signal will only be set when a runtime upgrade is enacted by the parachain (enact_authorized_upgrade).

additional info: paritytech/polkadot#7412

Closes #641

BradleyOlson64

Looks good to me. Nice work Daan!

bkchr

Looking mainly good, just some nitpicks.

bkchr · 2023-09-07T10:44:20Z

polkadot/runtime/parachains/src/inclusion/mod.rs

-			UmpAcceptanceCheckErr::IsOffboarding =>
-				write!(fmt, "upward message rejected because the para is off-boarding",),
+			UmpAcceptanceCheckErr::IsOffboarding => {
+				write!(fmt, "upward message rejected because the para is off-boarding",)


Suggested change

write!(fmt, "upward message rejected because the para is off-boarding",)

write!(fmt, "upward message rejected because the para is off-boarding")

bkchr · 2023-09-07T10:45:58Z

polkadot/runtime/parachains/src/paras/mod.rs

 		/// See https://github.com/paritytech/polkadot/issues/4601 for detailed explanation.
 		included_at: BlockNumber,
+		/// Whether or not the given para should be sent the `GoAhead` signal.
+		set_go_ahead: bool,


Could we make this an enum:

/// Should the `GoAhead` signal be set after a successful check of the new wasm binary? enum SetGoAhead { Yes, No, }

bkchr · 2023-09-07T12:14:48Z

polkadot/runtime/parachains/src/paras/mod.rs

 		// Schedule the upgrade with a delay just like if a parachain triggered the upgrade.
 		let upgrade_block = current_block.saturating_add(config.validation_upgrade_delay);
-		Self::schedule_code_upgrade(id, new_code, upgrade_block, &config);
+		Self::schedule_code_upgrade(id, new_code, upgrade_block, &config, false);


IMO we should "bubble up" the set_go_ahead parameter to the callers of this function.

Daanvdplas · 2023-09-11T15:43:12Z

Apologies for the mess and the lost history. I didn't see another way than to force push, it won't happen again 😣

polkadot/runtime/parachains/src/paras/tests.rs

* master: (54 commits) Publish `xcm-emulator` crate (#1881) Adding migrations to clean Rococo Gov 1 storage & reserved funds (#1849) Arkworks Elliptic Curve utils overhaul (#1870) Fix typos (#1878) fix: GoAhead signal only set when runtime upgrade is enacted from parachain side (#1176) Refactor staking ledger (#1484) Paired-key Crypto Scheme (#1705) Include polkadot version in artifact path (#1828) add link to rfc-0001 in broker README (#1862) Discard `Executor` (#1855) Macros to use path instead of ident (#1474) Remove clippy clone-double-ref lint noise (#1860) Refactor alliance benchmarks to v2 (#1868) Check executor params coherence (#1774) frame: use derive-impl for beefy and mmr pallets (#1867) sc-consensus-beefy: improve gossip logic (#1852) Adds instance support for composite enums (#1857) Fix links to implementers' guide (#1865) Disabled validators runtime API (#1257) Adding `try_state` hook for `Treasury` pallet (#1820) ...

…ribution * tsv-disabling-backing: (54 commits) Publish `xcm-emulator` crate (#1881) Adding migrations to clean Rococo Gov 1 storage & reserved funds (#1849) Arkworks Elliptic Curve utils overhaul (#1870) Fix typos (#1878) fix: GoAhead signal only set when runtime upgrade is enacted from parachain side (#1176) Refactor staking ledger (#1484) Paired-key Crypto Scheme (#1705) Include polkadot version in artifact path (#1828) add link to rfc-0001 in broker README (#1862) Discard `Executor` (#1855) Macros to use path instead of ident (#1474) Remove clippy clone-double-ref lint noise (#1860) Refactor alliance benchmarks to v2 (#1868) Check executor params coherence (#1774) frame: use derive-impl for beefy and mmr pallets (#1867) sc-consensus-beefy: improve gossip logic (#1852) Adds instance support for composite enums (#1857) Fix links to implementers' guide (#1865) Disabled validators runtime API (#1257) Adding `try_state` hook for `Treasury` pallet (#1820) ...

Polkadot-Forum · 2023-11-15T11:00:11Z

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/polkadot-release-analysis-v1-3-0/4614/1

Daanvdplas requested review from BradleyOlson64, antonva and bkchr August 31, 2023 08:32

BradleyOlson64 approved these changes Sep 6, 2023

View reviewed changes

bkchr reviewed Sep 7, 2023

View reviewed changes

Daanvdplas requested review from a team September 11, 2023 14:47

Daanvdplas requested review from acatangiu, andresilva, athei, cheme, jsidorenko and sorpaas as code owners September 11, 2023 14:48

Daanvdplas requested a review from a team September 11, 2023 14:48

Daanvdplas requested review from a team and koute as code owners September 11, 2023 14:48

paritytech-ci requested review from a team September 11, 2023 14:53

svyatonik removed request for a team September 11, 2023 15:02

reapply changes

21570c6

Daanvdplas force-pushed the daan/fix-go-ahead-signal branch from 813666a to 21570c6 Compare September 11, 2023 15:12

Daanvdplas removed request for acatangiu, andresilva, athei, jsidorenko and sorpaas September 11, 2023 15:24

Daanvdplas removed request for a team, cheme and koute September 11, 2023 15:24

clean up merge conflicts

08407df

Daanvdplas added the I2-bug The node fails to follow expected behavior. label Sep 11, 2023

Daanvdplas added 2 commits September 11, 2023 17:38

fix

688bf7e

cargo +nightly fmt

e3dcd32

Daanvdplas requested a review from bkchr September 12, 2023 07:29

bkchr approved these changes Oct 15, 2023

View reviewed changes

bkchr reviewed Oct 15, 2023

View reviewed changes

polkadot/runtime/parachains/src/paras/tests.rs Outdated Show resolved Hide resolved

bkchr added 2 commits October 15, 2023 22:11

Update polkadot/runtime/parachains/src/paras/tests.rs

c020453

Merge branch 'master' into daan/fix-go-ahead-signal

c30aff9

bkchr added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Oct 15, 2023

Fix benchmarks

3740bbe

bkchr merged commit 91c4360 into master Oct 15, 2023

bkchr deleted the daan/fix-go-ahead-signal branch October 15, 2023 21:32

kiltbot mentioned this pull request Nov 7, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.2.0 to 1.3.0 KILTprotocol/kilt-node#575

Closed

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: GoAhead signal only set when runtime upgrade is enacted from parachain side#1176

fix: GoAhead signal only set when runtime upgrade is enacted from parachain side#1176
bkchr merged 7 commits intomasterfrom
daan/fix-go-ahead-signal

Daanvdplas commented Aug 25, 2023

Uh oh!

BradleyOlson64 left a comment

Uh oh!

bkchr left a comment

Uh oh!

bkchr Sep 7, 2023

Uh oh!

bkchr Sep 7, 2023

Uh oh!

bkchr Sep 7, 2023

Uh oh!

Daanvdplas commented Sep 11, 2023

Uh oh!

Uh oh!

Polkadot-Forum commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	write!(fmt, "upward message rejected because the para is off-boarding",)
	write!(fmt, "upward message rejected because the para is off-boarding")

Conversation

Daanvdplas commented Aug 25, 2023

Uh oh!

BradleyOlson64 left a comment

Choose a reason for hiding this comment

Uh oh!

bkchr left a comment

Choose a reason for hiding this comment

Uh oh!

bkchr Sep 7, 2023

Choose a reason for hiding this comment

Uh oh!

bkchr Sep 7, 2023

Choose a reason for hiding this comment

Uh oh!

bkchr Sep 7, 2023

Choose a reason for hiding this comment

Uh oh!

Daanvdplas commented Sep 11, 2023

Uh oh!

Uh oh!

Polkadot-Forum commented Nov 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants