Migrate polkadot-primitives to v6 by slumber · Pull Request #1543 · paritytech/polkadot-sdk

slumber · 2023-09-13T15:14:42Z

Async-backing related primitives are stable primitives::v6
Async-backing API is now part of api_version(7)
It's enabled on Rococo and Westend runtimes

stabilize async backing and enable API on Rococo

polkadot/runtime/parachains/src/runtime_api_impl/mod.rs

polkadot/runtime/rococo/src/lib.rs

polkadot/primitives/src/v6/mod.rs

rphmeier · 2023-09-13T19:52:56Z

Just to be clear, we need to make sure not to enable api_version(7) on Polkadot or Kusama runtimes. This will not automatically cause that, right?

slumber · 2023-09-13T19:53:58Z

Just to be clear, we need to make sure not to enable api_version(7) on Polkadot or Kusama runtimes. This will not automatically cause that, right?

Yes, API is only enabled on Rococo, ~~not even on Westend~~

UPD: on Rococo and Westend with 3953c5d

ordian · 2023-09-13T20:00:01Z

I would enable this on Westend given that it's a testnet and enabling this runtime API shouldn't automatically bork the chain. Also Versi is based on Westend still last I've heard.

Removes the `network-protocol-staging` feature. This is needed for the first release of async backing capable nodes. Renames `VStaging` to `V2` on top of #1543 --------- Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

* master: (61 commits) OpenGov in Westend and Rococo (#1177) Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720) Migrate polkadot-primitives to v6 (#1543) genesis-builder: implemented for all runtimes (#1492) `BlockId` removal: `tx-pool` refactor (#1678) Bump directories from 4.0.1 to 5.0.1 (#1656) Allow debug_assertions in short-benchmarks CI job (#1711) chainHead/storage: Fix storage iteration using the query key (#1665) Implement more useful traits in `Slot` type (#1595) Make downloads in parallel and give more time to complete (#1699) Bump actions/checkout from 4.0.0 to 4.1.0 (#1688) contracts: Fix incorrect storage alias in mirgration (#1687) Fix documentation about justification and `finalized == true` requirement (#1607) tweak pallet macro (genesis_config etc) to cater for RA users as well. (#1689) Uncoupling pallet-xcm from frame-system's RuntimeCall (#1684) Bump aes-gcm from 0.10.2 to 0.10.3 (#1681) docs / Update PR template to reflect monorepo (#1674) update contributing guide and ui-tests scripts (#1668) pallet epm: add `TrimmingStatus` to the mined solution (#1659) Update HRMP pallet benchmarking to use benchmarks v2 (#1676) ...

Follow-up to #1543.

* backport paritytech/polkadot-sdk#1543 * another backport

* fiox overflow when computing priority boost (#2587) * Backport changes from polkadot-sdk (#2588) * backport paritytech/polkadot-sdk#1543 * another backport * https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3833103

* tsv-disabling-node-side: (69 commits) runtime-api: cleanup after v7 stabilization (#1729) Move requests-responses and polling from `ChainSync` to `SyncingEngine` (#1650) Add custom error message for `StorageNoopGuard` (#1727) Clarify docs cargo fmt add a CAVEAT comment implement disabled_validators correctly remove unnecessary hash string (#1722) OpenGov in Westend and Rococo (#1177) Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720) Migrate polkadot-primitives to v6 (#1543) genesis-builder: implemented for all runtimes (#1492) `BlockId` removal: `tx-pool` refactor (#1678) Bump directories from 4.0.1 to 5.0.1 (#1656) Allow debug_assertions in short-benchmarks CI job (#1711) chainHead/storage: Fix storage iteration using the query key (#1665) Implement more useful traits in `Slot` type (#1595) Make downloads in parallel and give more time to complete (#1699) Bump actions/checkout from 4.0.0 to 4.1.0 (#1688) contracts: Fix incorrect storage alias in mirgration (#1687) ...

[do we need to upgrade?]

In the PR we bump versions for all dependacy crates from `polkadot-sdk` and apply all required changes Changes: - `parachains_runtime_api_impl` `v5` -> `v7`, - from paritytech/polkadot-sdk#1543; - `Consideration` setup for preimage pallet instances, - from paritytech/polkadot-sdk#1363; - `experimental` feature removed for `pallet-society`, `pallet-xcm`, `runtime-common` crates, - from paritytech/polkadot-sdk#1503; - `pallet_election_provider_multi_phase::Config::SignedDepositBase` set to `GeometricDepositBase`, - from paritytech/polkadot-sdk#1547; - support `open_outbound_hrmp_channel_for_benchmarks_or_tests` func rename, - from paritytech/polkadot-sdk#1422; - missing weight functions added for `runtime_parachains_hrmp` and `pallet_preimage`; TODO: - [x] Deleted the Copy&paste para scheduler migration from #26 in b666613. This should be applied in the next runtime upgrade, but i did not properly check yet. --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> Co-authored-by: Bastian Köcher <git@kchr.de> Co-authored-by: joe petrowski <25483142+joepetrowski@users.noreply.github.com>

* backport paritytech/polkadot-sdk#1543 * another backport

* backport #1543 * another backport

* fiox overflow when computing priority boost (#2587) * Backport changes from polkadot-sdk (#2588) * backport paritytech/polkadot-sdk#1543 * another backport * https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3833103

* fiox overflow when computing priority boost (#2587) * Backport changes from polkadot-sdk (#2588) * backport #1543 * another backport * https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/3833103

migrate primitives to v6

d8a9792

stabilize async backing and enable API on Rococo

slumber added the T8-polkadot This PR/Issue is related to/affects the Polkadot network. label Sep 13, 2023

paritytech-ci requested a review from a team September 13, 2023 15:16

slumber added 6 commits September 13, 2023 19:22

fix import

1b191d8

bump rococo version

22d0c74

bump wococo too

1b5679d

fix pallet

27d45f7

fix doc job

c264250

fmt

b23f36c

sandreim mentioned this pull request Sep 13, 2023

Enable validation/collation v2 protocols #1542

Merged

ordian reviewed Sep 13, 2023

View reviewed changes

polkadot/runtime/parachains/src/runtime_api_impl/mod.rs Show resolved Hide resolved

ordian reviewed Sep 13, 2023

View reviewed changes

polkadot/runtime/rococo/src/lib.rs Show resolved Hide resolved

bkontur reviewed Sep 13, 2023

View reviewed changes

polkadot/primitives/src/v6/mod.rs Show resolved Hide resolved

paritytech-ci requested a review from a team September 13, 2023 19:47

slumber added 2 commits September 13, 2023 23:48

drop LOWES_USER_ID reexport

21feed2

revert comment

4ffdc01

merge runtime api into v7

4049260

enable async backing API on Westend

3953c5d

slumber requested review from eskimor and sandreim September 13, 2023 20:02

ordian approved these changes Sep 13, 2023

View reviewed changes

ordian added the T4-runtime_API This PR/Issue is related to runtime APIs. label Sep 13, 2023

bump westend

9cb2847

sandreim approved these changes Sep 14, 2023

View reviewed changes

Merge branch 'master' into slumber-async-backing-v6-primitives

b8b8121

Sophia-Gold mentioned this pull request Sep 15, 2023

Enable async backing on Rococo #1496

Closed

Enable validation/collation v2 protocols (#1542)

4cb5e35

Removes the `network-protocol-staging` feature. This is needed for the first release of async backing capable nodes. Renames `VStaging` to `V2` on top of #1543 --------- Signed-off-by: Andrei Sandu <andrei-mihail@parity.io>

ordian mentioned this pull request Sep 27, 2023

runtime-api: cleanup after v7 stabilization #1729

Merged

ordian added a commit that referenced this pull request Sep 27, 2023

runtime-api: cleanup after v7 stabilization (#1729)

769bdd3

Follow-up to #1543.

svyatonik added a commit to paritytech/parity-bridges-common that referenced this pull request Sep 28, 2023

backport paritytech/polkadot-sdk#1543

4d21754

svyatonik added a commit to paritytech/parity-bridges-common that referenced this pull request Sep 28, 2023

Backport changes from polkadot-sdk (#2588)

4f44968

* backport paritytech/polkadot-sdk#1543 * another backport

svyatonik added a commit to paritytech/parity-bridges-common that referenced this pull request Sep 28, 2023

Backport changes from polkadot-sdk (#2588)

1a24704

* backport paritytech/polkadot-sdk#1543 * another backport

svyatonik added a commit to paritytech/parity-bridges-common that referenced this pull request Sep 28, 2023

Backport changes from polkadot-sdk (#2588)

983db6c

* backport paritytech/polkadot-sdk#1543 * another backport

muharem mentioned this pull request Oct 5, 2023

upgrade to v1.2 polkadot-fellows/runtimes#56

Merged

1 task

kiltbot mentioned this pull request Oct 19, 2023

[AUTOMATIC] Update Polkadot dependencies from 1.1.0 to 1.2.0 KILTprotocol/kilt-node#571

Closed

svyatonik added a commit to svyatonik/runtimes that referenced this pull request Nov 3, 2023

https://github.com/paritytech/polkadot-sdk/pull/1543

70d30ef

[do we need to upgrade?]

svyatonik added a commit to svyatonik/runtimes that referenced this pull request Nov 8, 2023

https://github.com/paritytech/polkadot-sdk/issues/1543

68ad4ba

svyatonik added a commit to svyatonik/runtimes that referenced this pull request Nov 9, 2023

https://github.com/paritytech/polkadot-sdk/issues/1543

bb5cfbc

ahmadkaouk mentioned this pull request Nov 16, 2023

Update polkadot-sdk from v.1.1.0 to v1.3.0 moonbeam-foundation/moonbeam#2565

Closed

serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024

Backport changes from polkadot-sdk (paritytech#2588)

22505d3

* backport paritytech/polkadot-sdk#1543 * another backport

serban300 pushed a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024

Backport changes from polkadot-sdk (paritytech#2588)

dd1cf06

* backport paritytech/polkadot-sdk#1543 * another backport

bkchr pushed a commit that referenced this pull request Apr 10, 2024

Backport changes from polkadot-sdk (#2588)

4dc99c4

* backport #1543 * another backport

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate polkadot-primitives to v6#1543

Migrate polkadot-primitives to v6#1543
slumber merged 25 commits intomasterfrom
slumber-async-backing-v6-primitives

slumber commented Sep 13, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rphmeier commented Sep 13, 2023

Uh oh!

slumber commented Sep 13, 2023 •

edited

Loading

Uh oh!

ordian commented Sep 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

slumber commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rphmeier commented Sep 13, 2023

Uh oh!

slumber commented Sep 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ordian commented Sep 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

slumber commented Sep 13, 2023 •

edited

Loading

slumber commented Sep 13, 2023 •

edited

Loading