pallet epm: add TrimmingStatus to the mined solution#1659
Merged
Conversation
For tools such that is using the `Miner` it's useful to know whether a solution was trimmed or not.
niklasad1
changed the title
TrimmingStatus to solutionTrimmingStatus to the mined solution
niklasad1
commented
Sep 21, 2023
|
|
||
| /// Reports the trimming result of mined solution | ||
| #[derive(Debug, Clone)] | ||
| pub struct TrimmingStatus { |
Contributor
Author
There was a problem hiding this comment.
not sure about naming this, could also be TrimmingResult or something.
could also just be a boolean but I prefer a struct here
lexnv
reviewed
Sep 21, 2023
lexnv
approved these changes
Sep 21, 2023
Contributor
lexnv
left a comment
lexnv
left a comment
There was a problem hiding this comment.
LGTM! 👍 Small nit: would be nice to have a test that checks a non-trimmed and a trimmed solution to ensure the numbers are properly propagated. Not sure how easy that is to implement
Co-authored-by: Alexandru Vasile <[email protected]>
kianenigma
approved these changes
Sep 21, 2023
Contributor
kianenigma
left a comment
kianenigma
left a comment
There was a problem hiding this comment.
Please find one test that actually does trimming and assert on the output.
lexnv
approved these changes
Sep 21, 2023
Contributor
Author
|
bot merge |
|
@niklasad1 |
ordian
added a commit
that referenced
this pull request
Sep 27, 2023
* master: (61 commits) OpenGov in Westend and Rococo (#1177) Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720) Migrate polkadot-primitives to v6 (#1543) genesis-builder: implemented for all runtimes (#1492) `BlockId` removal: `tx-pool` refactor (#1678) Bump directories from 4.0.1 to 5.0.1 (#1656) Allow debug_assertions in short-benchmarks CI job (#1711) chainHead/storage: Fix storage iteration using the query key (#1665) Implement more useful traits in `Slot` type (#1595) Make downloads in parallel and give more time to complete (#1699) Bump actions/checkout from 4.0.0 to 4.1.0 (#1688) contracts: Fix incorrect storage alias in mirgration (#1687) Fix documentation about justification and `finalized == true` requirement (#1607) tweak pallet macro (genesis_config etc) to cater for RA users as well. (#1689) Uncoupling pallet-xcm from frame-system's RuntimeCall (#1684) Bump aes-gcm from 0.10.2 to 0.10.3 (#1681) docs / Update PR template to reflect monorepo (#1674) update contributing guide and ui-tests scripts (#1668) pallet epm: add `TrimmingStatus` to the mined solution (#1659) Update HRMP pallet benchmarking to use benchmarks v2 (#1676) ...
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
For tools such that is using the `Miner` it's useful to know whether a solution was trimmed or not and also how much that was trimmed. --------- Co-authored-by: Alexandru Vasile <[email protected]>
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For tools such that is using the
Minerit's useful to know whether a solution was trimmed or not and also how much that was trimmed.