Use Extensions to register offchain worker custom extensions#1719
Merged
skunert merged 5 commits intoparitytech:masterfrom Sep 29, 2023
Merged
Use Extensions to register offchain worker custom extensions#1719skunert merged 5 commits intoparitytech:masterfrom
Extensions to register offchain worker custom extensions#1719skunert merged 5 commits intoparitytech:masterfrom
Conversation
skunert
commented
Sep 26, 2023
Member
|
Just an idea, but what about adding a method to the And then use that id to populate the map For sure using the |
bkchr
requested changes
Sep 26, 2023
Member
bkchr
left a comment
bkchr
left a comment
There was a problem hiding this comment.
We should probably remove the Any supertrait from Extension. Then we can forward the type_id function of Box<dyn Extension to the wrapped type. This would ensure that we don't take the TypeId of Box<Extension>. This should then probably fix this issue without requiring any of the changes in this pr.
Contributor
Author
|
Good suggestions guys, code is now simpler 👍 |
bkchr
approved these changes
Sep 27, 2023
Co-authored-by: Bastian Köcher <git@kchr.de>
michalkucharczyk
approved these changes
Sep 28, 2023
davxy
approved these changes
Sep 28, 2023
ordian
added a commit
that referenced
this pull request
Oct 3, 2023
* master: (24 commits) Init System Parachain storage versions and add migration check jobs to CI (#1344) no-bound derives: Use absolute path for `core` (#1763) migrate alliance, fast-unstake and bags list to use derive-impl (#1636) Tvl pool staking (#1322) improve service error (#1734) frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717) Point documentation links to monorepo (#1741) [NPoS] Fix for Reward Deficit in the pool (#1255) Move import queue from `ChainSync` to `SyncingEngine` (#1736) Enable mocking contracts (#1331) Revert "fix(review-bot): pull secrets from `master` environment" (#1748) Remove kusama and polkadot runtime crates (#1731) Use `Extensions` to register offchain worker custom extensions (#1719) [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666) fix(review-bot): pull secrets from `master` environment (#1745) Fix `subkey inspect` output text padding (#1744) archive: Implement height, hashByHeight and call (#1582) rpc/client: Propagate `rpc_methods` method to reported methods (#1713) rococo-runtime: `RococoGenesisExt` removed (#1490) PVF: more filesystem sandboxing (#1373) ...
ordian
added a commit
that referenced
this pull request
Oct 10, 2023
* tsv-disabling-node-side: (24 commits) Init System Parachain storage versions and add migration check jobs to CI (#1344) no-bound derives: Use absolute path for `core` (#1763) migrate alliance, fast-unstake and bags list to use derive-impl (#1636) Tvl pool staking (#1322) improve service error (#1734) frame-support: `RuntimeDebug\Eq\PartialEq` impls for `Imbalance` (#1717) Point documentation links to monorepo (#1741) [NPoS] Fix for Reward Deficit in the pool (#1255) Move import queue from `ChainSync` to `SyncingEngine` (#1736) Enable mocking contracts (#1331) Revert "fix(review-bot): pull secrets from `master` environment" (#1748) Remove kusama and polkadot runtime crates (#1731) Use `Extensions` to register offchain worker custom extensions (#1719) [RPC-Spec-V2] chainHead: use integer for block index and adjust RuntimeVersion JSON format (#1666) fix(review-bot): pull secrets from `master` environment (#1745) Fix `subkey inspect` output text padding (#1744) archive: Implement height, hashByHeight and call (#1582) rpc/client: Propagate `rpc_methods` method to reported methods (#1713) rococo-runtime: `RococoGenesisExt` removed (#1490) PVF: more filesystem sandboxing (#1373) ...
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
…ytech#1719) Closes paritytech#1671 Adds a `type_id` function to the `Extension` trait, allowing to properly store an retrieve boxed `Extensions`. --------- Co-authored-by: Bastian Köcher <git@kchr.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1671
As discovered correctly in that issue, custom externality extensions passed in from the outside as
Box<dyn Extension>have some limitations. We store them inExtensionswere the key is aTypeId, so multiple extensions are overriding each other.I think the solution proposed in the issue is reasonable, so I changed the return type of the
custom_extensionsclosure to returnExtensions. They can then be passed to the runtime instance and merged with the existing extensions.