Uncoupling pallet-xcm from frame-system's RuntimeCall#1684
Merged
gavofyork merged 1 commit intoparitytech:masterfrom Sep 25, 2023
Merged
Uncoupling pallet-xcm from frame-system's RuntimeCall#1684gavofyork merged 1 commit intoparitytech:masterfrom
gavofyork merged 1 commit intoparitytech:masterfrom
Conversation
bkchr
approved these changes
Sep 24, 2023
KiChjang
approved these changes
Sep 25, 2023
gavofyork
approved these changes
Sep 25, 2023
ordian
added a commit
that referenced
this pull request
Sep 27, 2023
* master: (61 commits) OpenGov in Westend and Rococo (#1177) Associated type Hasher for `QueryPreimage`, `StorePreimage` and `Bounded` (#1720) Migrate polkadot-primitives to v6 (#1543) genesis-builder: implemented for all runtimes (#1492) `BlockId` removal: `tx-pool` refactor (#1678) Bump directories from 4.0.1 to 5.0.1 (#1656) Allow debug_assertions in short-benchmarks CI job (#1711) chainHead/storage: Fix storage iteration using the query key (#1665) Implement more useful traits in `Slot` type (#1595) Make downloads in parallel and give more time to complete (#1699) Bump actions/checkout from 4.0.0 to 4.1.0 (#1688) contracts: Fix incorrect storage alias in mirgration (#1687) Fix documentation about justification and `finalized == true` requirement (#1607) tweak pallet macro (genesis_config etc) to cater for RA users as well. (#1689) Uncoupling pallet-xcm from frame-system's RuntimeCall (#1684) Bump aes-gcm from 0.10.2 to 0.10.3 (#1681) docs / Update PR template to reflect monorepo (#1674) update contributing guide and ui-tests scripts (#1668) pallet epm: add `TrimmingStatus` to the mined solution (#1659) Update HRMP pallet benchmarking to use benchmarks v2 (#1676) ...
|
This pull request has been mentioned on Polkadot Forum. There might be relevant details there: https://forum.polkadot.network/t/polkadot-release-analysis-v1-2-0/4451/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR uncouples pallet-xcm's Config trait from frame-system's RuntimeCall and instead uses it's own RuntimeCall trait type, it also removes the trait requirement for it's RuntimeCall to be
IsType<<Self as frame_system::Config>::RuntimeCall>, meaning you can write custom types to be used for the XCM Transact instruction in a runtime that has pallet-xcm, which was previously not possible because of the hardcoded requirement imposed by pallet-xcm, which is not imposed by xcm-executor.This does not require any other changes to existing or future code, since all it does is make the trait requirements slightly less strict, maintaining compatibility but expanding it.