Conversation
**- Why I did it** Prior to SONiC using Debian Buster, we needed to build Python 3.5 or newer from source for installation in the SNMP container, becuase it wasn't available from the Debian repository for Jessie or Stretch. Now that all containers are based on Buster, we simply install Python 3.7 from the Debian repository in the host as well as all containers. We are no longer building Python 3 from source, so the Makefile is unused and we no longer need to install build dependencies in the slave containers. **- How I did it** - Remove Python 3 makefile - No longer install Python 3 build dependencies in the slave containers.
…ge (sonic-net#6442) **- Why I did it** To enable running Pytest unit tests before building the Python 3 sonic-platform-common package **- How I did it** - Add Python 3 sonic-config-engine package as a dependency of Python 3 sonic-platform-common package (needed for both runtime and unit tests) - No longer disable unit tests when building Python 3 sonic-platform-common package
…-net#6403) **- Why I did it** Earlier today we found a bug in the SONiC TSA implementation. TSC shows incorrect output (see below) in case we have a route-map which contains TSA route-map as a prefix. ``` admin@str-s6100-acs-1:~$ TSC Traffic Shift Check: System Mode: Not consistent ``` The reason is that TSC implementation has too loose regexps in TSA utilities, which match wrong route-map entries: For example, current TSC matches following ``` route-map TO_BGP_PEER_V4 permit 200 route-map TO_BGP_PEER_V6 permit 200 ``` But it should match only ``` route-map TO_BGP_PEER_V4 permit 20 route-map TO_BGP_PEER_V4 deny 30 route-map TO_BGP_PEER_V6 permit 20 route-map TO_BGP_PEER_V6 deny 30 ``` **- How I did it** I fixed it by using egrep with `^` and `$` regexp markers which match begin and end of the line. **- How to verify it** 1. Add follwing entry to FRR config: ``` str-s6100-acs-1# str-s6100-acs-1# conf t str-s6100-acs-1(config)# route-map TO_BGP_PEER_V4 permit 200 str-s6100-acs-1(config-route-map)# end ``` 2. Use the TSC command and check output. It should show normal. ``` admin@str-s6100-acs-1:~$ TSC Traffic Shift Check: System Mode: Normal```
…k (CVL) (sonic-net#5714) - Why I did it Management framework (CVL) needs to call lyd_check_mandatory_tree() for validation and hence exported lyd_check_mandatory_tree() as an API. - How I did it Added "API" keyword before lyd_check_mandatory_tree() definition. - How to verify it There is no functionality code change here and no specific steps to verify it. Management framework (CVL) should be able to call this function and no patching and compilation error should be seen. - Description for the changelog Added "API" keyword before export lyd_check_mandatory_tree() function definition.
…onic-net#6454) * [warm boot finalizer] only wait for enabled components to reconcile Define the component with its associated service. Only wait for components that have associated service enabled to reconcile during warm reboot. Signed-off-by: Ying Xie <[email protected]>
…nic-net#6460) In order to build up device hierachy, PSU and module thermals are no longer child of chassis. PSU thermal belongs to PSU objects and SFP thermals belong to SFP object now. Need align this change in platform.json. Move thermal objects to correct parent device
…6458) “time" module was missed to be imported and will cause an error when the branch hit. Signed-off-by: Kebo Liu <[email protected]>
…#6440) Some non-production minigraphs will have an empty ClusterName tag Signed-off-by: Lawrence Lee <[email protected]>
sonic-net#6168) It's been reported that accton fan monitor process keeps consuming memory after few days. The amount of memory occupied increases in linear and never leased. Signed-off-by: roy_lee <[email protected]>
…onic-net#6089) **- Why I did it** - The thermalctld daemon on the Pmon docker requires support from the thermal manager API. **- How I did it** - Removed the old function for detecting a faulty fan. - Removed the old function for detecting excess temperature. - Implement thermal_manager APIs based on ThermalManagerBase - Implement thermal_conditions APIs based on ThermalPolicyConditionBase - Implement thermal_actions APIs based on ThermalPolicyActionBase - Implement thermal_info APIs based on ThermalPolicyInfoBase - Add thermal_policy.json
…ent service (sonic-net#6465) **- Why I did it** On the Mellanox platform, reboot cause is fetched from some certain sysfs which is created by the hw-management service. So determine-reboot-cause service shall start after hw-management, otherwise it could fail due to the related sysfs is not available yet. **- How I did it** Add a patch to the hw-management service to make sure determine-reboot-cause service should start after it. Signed-off-by: Kebo Liu <[email protected]>
When building the sonic-slave-buster docker container, the node.js package is installed to meet the requirements of the Azure DevOPs pipleline build. Recently this install of node.js has been failing. This commit fixes that build break by upgrading the sonic-slave-buster build to install version 14.x of node.js which is the current LTS version for buster.
…cks (sonic-net#6457) Avoid sonic-cfggen crashing when a server does not have a configured loopback address in the minigraph Signed-off-by: Lawrence Lee <[email protected]>
…ms speeds requirements (sonic-net#6279) [DPB][MLNX][YANG] fixed range of max speed - Why I did it All Mellanox platforms require DPB modes with a specific set of speeds example - How I did it Extended regex pattern inside YANG model. Supported platforms: SN2010, SN2100, SN2410, SN2700, SN3420, SN3700, SN3700C, SN3800, SN4600C, SN4410, SN4700 - How to verify it Manually tested DPB CLI on all platform with all modes Signed-off-by: Vadym Hlushko <[email protected]>
…t#6003) [DPB] added capability files for SN2700 platform - Why I did it platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout - How I did it Created capability files according to platform specification SN2700 - How to verify it Full qualification requires bugs fixes reported under sonic-buildimage NOTE: breakout to 4 is currently not available as of missing functionality in DPB implementation. Signed-off-by: Vadym Hlushko <[email protected]>
…t#6013) - Why I did it platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout - How I did it Created capability files according to platform specification SN3800 - How to verify it Full qualification requires bugs fixes reported under sonic-buildimage Signed-off-by: Vadym Hlushko <[email protected]>
…t#6015) - Why I did it platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout - How I did it Created capability files according to platform specification SN2010 - How to verify it Full qualification requires bugs fixes reported under sonic-buildimage Signed-off-by: Vadym Hlushko <[email protected]>
…t#6016) - Why I did it platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout - How I did it Created capability files according to platform specification SN2100 - How to verify it Full qualification requires bugs fixes reported under sonic-buildimage Signed-off-by: Vadym Hlushko <[email protected]>
…t#6017) - Why I did it platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout - How I did it Created capability files according to platform specification SN2410 - How to verify it Full qualification requires bugs fixes reported under sonic-buildimage NOTE: breakout to 4 is currently not available as of missing functionality in DPB implementation. Signed-off-by: Vadym Hlushko <[email protected]>
…t#6021) - Why I did it platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout - How I did it Created capability files according to platform specification SN3700 - How to verify it Full qualification requires bugs fixes reported under sonic-buildimage Signed-off-by: Vadym Hlushko <[email protected]>
…t#6059) - Why I did it platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout - How I did it Created capability files according to platform specification SN4410 - How to verify it Full qualification requires bugs fixes reported under sonic-buildimage Signed-off-by: Vadym Hlushko <[email protected]>
…et#6061) - Why I did it platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout - How I did it Created capability files according to platform specification SN4600C - How to verify it Full qualification requires bugs fixes reported under sonic-buildimage NOTE: breakout to 4 is currently not available as of missing functionality in DPB implementation. Signed-off-by: Vadym Hlushko <[email protected]>
dump netstat info on error Signed-off-by: Guohan Lu <[email protected]>
use dpkg-buildpackage build with fakeroot Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
…#6478) Fix sonic-net#5026 There is a race condition between zebra server accepts connections and bgpd tries to connect. Bgpd has a chance to try to connect before zebra is ready. In this scenario, bgpd will try again after 10 seconds and operate as normal within these 10 seconds. As a consequence, whatever bgpd tries to sent to zebra will be missing in the 10 seconds. To avoid such a scenario, bgpd should start after zebra is ready to accept connections.
Signed-off-by: Guohan Lu <[email protected]>
…t#6020) platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout Signed-off-by: Vadym Hlushko <[email protected]>
* 3b330db4a 2021-01-18 | [build]: Fix build error when compiling for armhf (32-bit) (sonic-net#30) (HEAD, origin/master, origin/HEAD, master) [dflynn-Nokia] * 56aaa225b 2021-01-16 | [ci]: add pipeline for armhf and arm64 (sonic-net#29) [lguohan] * 90da6141c 2021-01-12 | [ci]: propagate the correct error code the next step (sonic-net#27) [lguohan] Signed-off-by: Guohan Lu <[email protected]>
[ci]: download artifacts from master branch (sonic-net#768) Do not create fabric port if mapping is not available (sonic-net#769) [syncd] Comparison logic log also current attr value on set operation (sonic-net#763) Add fabric port test to vslib (sonic-net#737) [ci]: use sonicbld pool (sonic-net#766) [tests] Remove exit command blocking all tests to run (sonic-net#765) [vslib]: adapt macsec sai 1.7.1 (sonic-net#755) Add support for SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY needed by CRM (sonic-net#756) Signed-off-by: Danny Allen <[email protected]>
…le (sonic-net#6682) - Why I did it As of sonic-net/sonic-utilities#1297, subcommands of pcieutil have changed to remove the redundant pcie- prefix. This PR adapts calling applications (pcie-check) to the new syntax. Resolves sonic-net#6676 - How I did it Remove pcie- prefix from pcieutil subcommands in calling applications Also add pcieutil * to sudoers file, as pcieutil requires elevated permissions
…logy service(sonic-net#6594) [multi_asic][vs]: Add dependency in teamd service to start after topology service. - Why I did it In multi-asic VS, topology service is run after database service to set up the internal asic topology. swss and syncd have a dependency to start after topology service is run so that the interfaces are moved to right namespace and created in the right namespace. In case of multi-asic vs, during the initial boot up, when there is no configuration added, teamd service starts and swss/syncd do not start as topology service does not start. Upon loading configuration using config_db or minigraph, swss and sycnd start up , but teamd is not restarted as swss is not stopped and started. This causes teamd to be in a bad state and requires a reload of config. - How I did it Add dependency in teamd service to start after topology service is completed. - How to verify it No change in single asic vs or platform. No change in multi-asic regular image. Change only in multi-asic VS. Bring up a multi-asic VS image without any configration, teamd service will fail to start due to dependency failure. Load minigraph, start topology service, load configuration, ensure all services come up. Signed-off-by: SuvarnaMeenakshi <[email protected]>
…onic-net#6600) Encounter error when install SONiC image if there are some onie_discovery variables assigned with multiple values inside machine.conf - How I did it Replace original ". /machine.conf" method and add another function to do the same thing. - How to verify it Add a item inside /host/machine.conf like onie_disco_ntpsrv=10.254.141.10 10.254.141.131 Do sonic_installer install to check if any error occurs
Changed Error log to Notice log during FDB flush notification after VLAN delete (sonic-net#1618) 288fb40 - How to verify it Create a VLAN and add member port to it. Then inject traffic on the member port for that VLAN. Ensure that FDB entry is learnt for that VLAN member port. Then remove the member port and remove VLAN. Check if you get a NOTICE log that "failed to locate VLAN" appears in syslogs. Co-authored-by: Madhan Babu <[email protected]>
Reboot command in Dell S6000 failed to reboot the switch. Added retry mechanism and CPU reset.
…on and fixes (sonic-net#6438) **- Why I did it** To incorporate the below changes in DellEMC S6100, S6000 platforms. - S6100, S6000: - Enable 'thermalctld' - Implement DeviceBase methods (presence, status, model, serial) for Fantray and Component - Implement ‘get_position_in_parent’, ‘is_replaceable’ methods for all device types - Implement ‘get_status’ method for Fantray - Implement ‘get_temperature’, ‘get_temperature_high_threshold’, ‘get_voltage_high_threshold’, ‘get_voltage_low_threshold’ methods for PSU - Implement ‘get_status_led’, ‘set_status_led’ methods for Chassis - SFP: - Make EEPROM read both Python2 and Python3 compatible - Fix ‘get_tx_disable_channel’ method’s return type - Implement ‘tx_disable’, ‘tx_disable_channel’ and ‘set_power_override’ methods - S6000: - Move PSU thermal sensors from Chassis to respective PSU - Make available the data of both Fans present in each Fantray **- How I did it** - Remove 'skip_thermalctld:true' in pmon_daemon_control.json - Implement the platform API methods in the respective device files - Use `bytearray` for data read from transceiver EEPROM - Change return type of 'get_tx_disable_channel' to match specification in sonic_platform_common/sfp_base.py
Includes below commits ``` 9e91e0d 2021-02-04 | Fix: RedisClient.set() should return bool (sonic-net#454) [Qi Luo] 244a0bf 2021-02-04 | [swig] Add missing functions for ConfigDBConnector (sonic-net#453) [Qi Luo] e659698 2021-01-22 | [dbconnector] Make sure json is declared as non null object (sonic-net#452) [Kamil Cudnik] ```
…rse_dom_capability' (sonic-net#6695) **- Why I did it** PR sonic-net/sonic-platform-common#102 modified the name of the SFF-8436 (QSFP) method to align the method name between all drivers, renaming it from `parse_qsfp_dom_capability` to `parse_dom_capability`. Once the submodule was updated, the callers using the old nomenclature broke. This PR updates all callers to use the new naming convention. **- How I did it** Update the name of the function globally for all calls into the SFF-8436 driver. Note that the QSFP-DD driver still uses the old nomenclature and should be modified similarly. I will open a PR to handle this separately.
**- Why I did it** To support nightly build for master branch **- How to verify it** confirm from azure pipeline page.
Port_config update for hwsku 7050CX3-32S-C3 - add two 10G ports. This change is added to fix issue of "PortsOrch initialization failure" seen by previous removal of these 10G ports. Tested on the device with new minigraph, and the PortsOrch initialization failure is not seen.
Signed-off-by: Guohan Lu <[email protected]>
* Remove makefile and As part of sonic-net#6046 we have moved to python3 of dbsyncd. Cleanup the python2 makefile and dependency. Signed-off-by: Abhishek Dosi <[email protected]> * Revert "Remove makefile and dependency for python2 of dbsyncd." This reverts commit ceaa4f8. * Fix Signed-off-by: Abhishek Dosi <[email protected]>
…6696) prerm is needed for platform modules package to be properly removed. Added prerm to remove installed in postinst wheel packages. Signed-off-by: Volodymyr Boyko <[email protected]>
official build only use scheduled build Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
check the uid before modify local user account.
when run sudo, the process the invoke nss_tacplus library
does not have priviledge to modify the user profile, and
will generate below error messages:
user_rw@sonic:~$ sudo bash
usermod: Permission denied.
usermod: cannot lock /etc/passwd; try again later.
usermod: Permission denied.
usermod: cannot lock /etc/passwd; try again later.
Signed-off-by: Guohan Lu <[email protected]>
sonic-utilities will become dependent upon sonic-platform-common as of sonic-net/sonic-utilities#1386.
…ic-net#6321) Accton util applies lsmod to check if drivers are installed. But lsmod may return error on startup and skip module installation. Signed-off-by: roy_lee <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
- [ci]: add default values to build template - [ci]: add marvel armhf official build Signed-off-by: Guohan Lu <[email protected]>
* [device] add platform.json hwsku.json for Montara * [device] add autonge, fec fields to hwsku
) Signed-off-by: Guohan Lu <[email protected]>
**- Why I did it** After migrating to python3, the operator '/' always get a float result, but it gets integer result in python2. Need fix this in thermal_conditions. **- How I did it** 1. cast float value to int 2. change the unit test case to cover this situation **- How to verify it** Manually test and regression test
proper bool comparision Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
…ic-net#6713) Fix sonic-net#6711 the requirement was introduced in commit 75104bb to support sflow in stretch build. in buster build, the requirement is met, no need to pin down the version. Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Volodymyr Boyko <[email protected]>
vboykox
pushed a commit
that referenced
this pull request
Dec 20, 2021
#### What I did [sonic-linkmgrd][master] submodule update 6c6151b Fix unstable unit tests (state change handler wasn't invoked) (#8) 2f7dc0a support code diff coverage (#5) 83f0002 Force mux state switch to standby if triggered from Cli (#6) signed-off-by: Jing Zhang [email protected]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
- How I did it
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)