[Mellanox][platform api] fix a missing module import#6458
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jan 15, 2021
Merged
[Mellanox][platform api] fix a missing module import#6458lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Kebo Liu <[email protected]>
Contributor
|
@keboliu: I assume this also needs to be cherry-picked into the 202012 branch, no? |
jleveque
approved these changes
Jan 15, 2021
Collaborator
Author
202012 also need it, I labeled it. thanks. |
lguohan
pushed a commit
that referenced
this pull request
Jan 15, 2021
“time" module was missed to be imported and will cause an error when the branch hit. Signed-off-by: Kebo Liu <[email protected]>
Contributor
|
@keboliu Please create PR for 201911. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
“time" module was missed to be imported and will cause an error when the branch hit.
- How I did it
Add "import time"
- How to verify it
make the condition to be true by mocking and let the code run, can see it run w/o error.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)