[DPB][YANG-models] extended regex pattern according to Mellanox systems speeds requirements#6279
Conversation
Signed-off-by: Vadym Hlushko <[email protected]>
Signed-off-by: Vadym Hlushko <[email protected]>
Signed-off-by: Vadym Hlushko <[email protected]>
Signed-off-by: Vadym Hlushko <[email protected]>
Signed-off-by: Vadym Hlushko <[email protected]>
|
retest vs please |
|
retest vsimage please |
|
retest vsimage please |
|
I think sonic-breakout_cfg.yang should be removed and backend should check the speed by platform.json, and not limit this into yang models. This is going to be accommodated by sonic-net/sonic-utilities#1020 and new PR(s). sonic-port.yang changes are fine. |
I believe this approach is better but it will take time until it will be available. Meanwhile we are blocked with many PRs. |
|
@zhenggen-xu , what are the new PRs you mentioned? |
|
OK, we can get this in, we will have new PR(s) to remove the sonic-breakout_cfg.yang and make the configMgmt logic to check the breakout mode instead. |
praveen-li
left a comment
There was a problem hiding this comment.
Please add atleast a new test with it.
To add Test:
1.) Add Config at https://github.com/Azure/sonic-buildimage/blob/e52581e919c95e861cf630c9c7e1a840fc5e8ebd/src/sonic-yang-models/tests/yang_model_tests/yangTest.json#L2
2.) Add matching detail and expected error string at:
https://github.com/Azure/sonic-buildimage/blob/e52581e919c95e861cf630c9c7e1a840fc5e8ebd/src/sonic-yang-models/tests/yang_model_tests/test_yang_model.py#L52
Signed-off-by: Vadym Hlushko <[email protected]>
d71eb75
|
@praveen-li could you please review the last changes? |
praveen-li
left a comment
There was a problem hiding this comment.
LGTM, note it may be possible that we may deprecate BRK_CFG Yang model later. Thx.
|
Retest vsimage please |
- Why I did it
All Mellanox platforms require DPB modes with a specific set of speeds example
- How I did it
Extended regex pattern inside YANG model.
Supported platforms:
SN2010,SN2100,SN2410,SN2700,SN3420,SN3700,SN3700C,SN3800,SN4600C,SN4410,SN4700- How to verify it
Manually tested DPB CLI on all platform with all modes
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)