[platform] Update QSFP method name 'parse_qsfp_dom_capability' -> 'parse_dom_capability'#6695
Merged
jleveque merged 1 commit intosonic-net:masterfrom Feb 5, 2021
jleveque:update_dom_capability_function_name
Merged
[platform] Update QSFP method name 'parse_qsfp_dom_capability' -> 'parse_dom_capability'#6695jleveque merged 1 commit intosonic-net:masterfrom jleveque:update_dom_capability_function_name
jleveque merged 1 commit intosonic-net:masterfrom
jleveque:update_dom_capability_function_name
Conversation
…rse_dom_capability'
daall
approved these changes
Feb 5, 2021
daall
pushed a commit
that referenced
this pull request
Feb 5, 2021
…rse_dom_capability' (#6695) **- Why I did it** PR sonic-net/sonic-platform-common#102 modified the name of the SFF-8436 (QSFP) method to align the method name between all drivers, renaming it from `parse_qsfp_dom_capability` to `parse_dom_capability`. Once the submodule was updated, the callers using the old nomenclature broke. This PR updates all callers to use the new naming convention. **- How I did it** Update the name of the function globally for all calls into the SFF-8436 driver. Note that the QSFP-DD driver still uses the old nomenclature and should be modified similarly. I will open a PR to handle this separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
PR sonic-net/sonic-platform-common#102 modified the name of the SFF-8436 (QSFP) method to align the method name between all drivers, renaming it from
parse_qsfp_dom_capabilitytoparse_dom_capability. Once the submodule was updated, the callers using the old nomenclature broke. This PR updates all callers to use the new naming convention.- How I did it
Update the name of the function globally for all calls into the SFF-8436 driver.
Note that the QSFP-DD driver still uses the old nomenclature and should be modified similarly. I will open a PR to handle this separately.
- How to verify it
Ensure method is called properly and callers no longer crash.
- Which release branch to backport (provide reason below if selected)