[device/accton/as4630-54pe] Fix accton driver not been installed#6321
Merged
lguohan merged 1 commit intosonic-net:masterfrom Feb 6, 2021
Merged
[device/accton/as4630-54pe] Fix accton driver not been installed#6321lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Accton util applies lsmod to check if drivers are installed. But lsmod may return error on startup and skip module installation. Signed-off-by: roy_lee <[email protected]>
lguohan
approved these changes
Jan 6, 2021
Contributor
|
Retest mellanox please |
Contributor
|
Retest vsimage please |
jleveque
approved these changes
Jan 9, 2021
|
Reset |
4 tasks
|
Retest |
Contributor
|
Retest vsimage please |
daall
pushed a commit
that referenced
this pull request
Feb 16, 2021
Accton util applies lsmod to check if drivers are installed. But lsmod may return error on startup and skip module installation. Signed-off-by: roy_lee <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accton util applies lsmod to check if drivers are installed.
But lsmod may return error on startup and skip module installation.
Signed-off-by: roy_lee [email protected]
- Why I did it
Reported that sometimes the peripherals cannot be polled.
- How I did it
It's found that lsmod command may failed on startup, the accton util misjudges that drivers have been installed.
The change here is not to apply lsmod to poll installed drivers.
- How to verify it
The bug can be probably replicated during several time of reboot.
Replace with new script and reboot 100 times.
Drivers are all well installed on these 100 reboot.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog