[minigraph.py]: Check for empty cluster tag before parsing#6440
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jan 15, 2021
Merged
[minigraph.py]: Check for empty cluster tag before parsing#6440lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
prsunny
approved these changes
Jan 13, 2021
Contributor
Author
|
retest vsimage please |
Collaborator
|
this is also needed for 202012, right? |
lguohan
pushed a commit
that referenced
this pull request
Jan 15, 2021
Some non-production minigraphs will have an empty ClusterName tag Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
abdosi
pushed a commit
that referenced
this pull request
Jan 28, 2021
Some non-production minigraphs will have an empty ClusterName tag Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
- Why I did it
Some non-production minigraphs will have an empty
ClusterNametag- How I did it
Check if
ClusterNametag is empty before trying to access text- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
