Remove things needed for building Python 3 from source#6441
Merged
jleveque merged 2 commits intosonic-net:masterfrom Jan 14, 2021
jleveque:no_build_python3
Merged
Remove things needed for building Python 3 from source#6441jleveque merged 2 commits intosonic-net:masterfrom jleveque:no_build_python3
jleveque merged 2 commits intosonic-net:masterfrom
jleveque:no_build_python3
Conversation
jleveque
changed the title
qiluo-msft
approved these changes
Jan 14, 2021
lguohan
pushed a commit
that referenced
this pull request
Jan 24, 2021
**- Why I did it** Prior to SONiC using Debian Buster, we needed to build Python 3.5 or newer from source for installation in the SNMP container, becuase it wasn't available from the Debian repository for Jessie or Stretch. Now that all containers are based on Buster, we simply install Python 3.7 from the Debian repository in the host as well as all containers. We are no longer building Python 3 from source, so the Makefile is unused and we no longer need to install build dependencies in the slave containers. **- How I did it** - Remove Python 3 makefile - No longer install Python 3 build dependencies in the slave containers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Prior to SONiC using Debian Buster, we needed to build Python 3.5 or newer from source for installation in the SNMP container, becuase it wasn't available from the Debian repository for Jessie or Stretch. Now that all containers are based on Buster, we simply install Python 3.7 from the Debian repository in the host as well as all containers. We are no longer building Python 3 from source, so the Makefile is unused and we no longer need to install build dependencies in the slave containers.
- How I did it
- How to verify it
Successfully build all slave containers and a SONiC image
- Which release branch to backport (provide reason below if selected)