[testbed] fanout add rootfanout connect when deploying fanout switch#368
Merged
lguohan merged 5 commits intosonic-net:masterfrom Dec 15, 2017
Merged
[testbed] fanout add rootfanout connect when deploying fanout switch#368lguohan merged 5 commits intosonic-net:masterfrom
lguohan merged 5 commits intosonic-net:masterfrom
Conversation
lguohan
reviewed
Dec 4, 2017
ansible/roles/fanout/tasks/main.yml
Outdated
| async: 1 | ||
| poll: 0 | ||
| ignore_errors: true | ||
| when: device_info.HwSku == "Arista-7060CX-32S" |
Contributor
There was a problem hiding this comment.
can we unify them into one block?,
only the deploy deploy script is different.
lguohan
reviewed
Dec 4, 2017
| {% if connect_leaf %} | ||
| {% if 'Fanout' in lab_devices[peer_dev]['Type'] %} | ||
| interface {{ intf }} | ||
| switchport mode trunk fanout |
Contributor
There was a problem hiding this comment.
fanout [](start = 24, length = 6)
extra?
pavel-shirshov
suggested changes
Dec 4, 2017
|
|
||
| - set_fact: connect_leaf=false | ||
|
|
||
| - include: roles/fanout/tasks/rootfanout_connect.yml |
Contributor
There was a problem hiding this comment.
It could be written as
- include: roles/fanout/tasks/rootfanout_connect.yml
connect_leaf=false
Contributor
Author
There was a problem hiding this comment.
thank you, changed
ansible/roles/fanout/tasks/main.yml
Outdated
|
|
||
| - block: | ||
| - name: create persistent shell login | ||
| shell: touch /mnt/flash/rc.eos |
Contributor
There was a problem hiding this comment.
Why do we need a persistent shell prompt?
Contributor
Author
There was a problem hiding this comment.
Well, it depends. for new switch, if manually copied this file over, then no need for this. Otherwise, if just manually add a new user to run deployment, after switch reload, the shell login is gone.
| - name: build fanout startup config for Arista Fanout leaf | ||
| template: src=arista_7260_deploy.j2 | ||
| dest=/mnt/flash/startup-config | ||
| notify: |
Contributor
There was a problem hiding this comment.
Why don't use notify?
Contributor
Author
There was a problem hiding this comment.
Notify has a large change fail reboot, didn't root cause this, but reboot is more consistent for reload the switch
pavel-shirshov
approved these changes
Dec 15, 2017
praveen-li
pushed a commit
to praveen-li/sonic-mgmt
that referenced
this pull request
Jun 20, 2019
* msft_github/master: Update README.testbed.Setup.md call test by test case name (sonic-net#362) [testbed] fanout add rootfanout connect when deploying fanout switch (sonic-net#368) [lag_2] enable lag_2 test on t0-116 topology (sonic-net#390) [deployment] add missing quotation marks that breaks (sonic-net#386) Finalize T0-116 topology (sonic-net#381) Directed broadcast Test (sonic-net#377) [change_mac]: Change MAC address formatting (sonic-net#380) add github template helping report issues and submit pull request (sonic-net#378) Fixing logic to identify proper 'port_config.ini' file. (sonic-net#376) [sensors] add sensor definitions for arista 7260/7060 (sonic-net#371) [pfc_wd]: Rework for P2 (sonic-net#363) [test]: Update BGP speaker test (sonic-net#236) Add vm_resument which restore paused VMs (sonic-net#297) Copy acsbase files to ptf before ptf_runner (sonic-net#366) Modify dhcp_servers IPs in order to fix DHCP relay test (sonic-net#364) [templates]: Remove trailing space in t1-lag minigraph template (sonic-net#360) [fastreboot test]: Add "fanout_listener" for MLNX fanout switches (sonic-net#353) patch t0 portchannel name to 15 chars (sonic-net#358) [process_checker]: Add the process_checker playbook (sonic-net#349) fix issue 354 (sonic-net#355) Update build instruction for docker-ptf.gz and docker-sonic-mgmt.gz [upgrade_sonic]: Add upgrade_sonic as a convenience script to upgrade the device with an image (sonic-net#338) [acl test]: Generate switch info file. (sonic-net#346) fix t0 templates for generate minigraph (sonic-net#344) [loganalyzer_end.yml]: Rename expected_matches (sonic-net#345) [minigraph_facts]: Add the missing brace (sonic-net#342) [Arista7260cx3] update topology t0-116 to include port 17 and 19 (sonic-net#340) [fdb test] help switch populate mac table before starting the test (sonic-net#341) [arista7260cx3] include port 18 and 20 as 50G breakout ports (sonic-net#339) Loganalyzer enhancements (sonic-net#321) [plugin]: Adding Dell platform in switch connection plugin (sonic-net#333) modified files to get lag members from minigraph (sonic-net#327) [minigraph] modify script to fit the latest configuration method (sonic-net#331) [minigraph_fact] add port mapping for 5 INGRASYS switches (sonic-net#336) [sensors] add sensor data for 5 INGRASYS switches (sonic-net#335) [minigraph-template]: Add ACL L3 and mirroring tables to minigraph template. (sonic-net#330) [acltb-test]: Addopt ACL test to acl-loader. (sonic-net#299) [everflow test]: Addopt Everflow testbed test to acl-loader. (sonic-net#300) Remove hard-coded bgp speaker asn number, fetch from DUT (sonic-net#329) Port alias mapping added for Arista-7060CX-32S-C32 (sonic-net#328) Adding if case for S6100 platform to get port details (sonic-net#314) [interface_facts] improve interface facts checking performance (sonic-net#326) [fdb] Hard code port layout to enable fdb test on t0-116 topology (sonic-net#322) (sonic-net#320) [fib] Hard code port layout to enable fib test on t0-116 topology (sonic-net#322) [fib, fdb] Allow fib and fdb test info files to contain empty lines and comments (sonic-net#323) [lag_test]: Correct typo error for lag tests (sonic-net#325) [link flap test] improve performance of link flap test (sonic-net#319)
sdszhang
pushed a commit
to sdszhang/sonic-mgmt
that referenced
this pull request
Jun 14, 2025
…-net#368) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [x] 202505 - [x] 202412 ### Approach #### What is the motivation for this PR? Change t1-isolated-d28 to d32 in ACL tests #### How did you do it? #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
… automatically (sonic-net#15133) src/sonic-platform-common * ff72811 - (HEAD -> 202205, origin/202205) Fix issue '<' not supported between instances of 'NoneType' and 'int' (sonic-net#371) (5 hours ago) [Junchao-Mellanox] * f2a419d - Render Media lane and Media assignment options info from Application Code (sonic-net#368) (8 hours ago) [rajann] * d8bad10 - Retrieve FW version using CDB command for CMIS transceivers + handle single bank FW versioning (sonic-net#372) (8 hours ago) [mihirpat1]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Fix SubscriberStateTable::hasCachedData formula for a timing risk (sonic-net#379) Add restapi DB (sonic-net#386) Fix swss::exec return value (sonic-net#368) Signed-off-by: Abhishek Dosi <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
… automatically (sonic-net#16332) #### Why I did it src/sonic-platform-common ``` * 05cf5c1 - (HEAD -> 202211, origin/202211) Change Y cable simulator log level from error to warning due to false alarm (11 hours ago) [ShiyanWangMS] * 35ea290 - Update CMIS api's rendering max-duration (sonic-net#375) (11 hours ago) [rajann] * 33bd498 - Retrieve FW version using CDB command for CMIS transceivers + handle single bank FW versioning (sonic-net#372) (11 hours ago) [mihirpat1] * 2434362 - Render Media lane and Media assignment options info from Application Code (sonic-net#368) (11 hours ago) [rajann] * 862674b - Modify sfputil show fwversion to include build version for active/inactive FW version fields (sonic-net#367) (11 hours ago) [mihirpat1] * 8edfece - Adding electrical for 800G and 100G (sonic-net#365) (11 hours ago) [mihirpat1] * 8a1debf - SFF-8472: Fix tx_disable_channel to avoid write to read-only bit (sonic-net#364) (11 hours ago) [mihirpat1] * 223a231 - Update host electrical interface for 2x400G breakout cable (sonic-net#363) (11 hours ago) [mihirpat1] * baabd8f - fix get module hardware minor revision (sonic-net#361) (11 hours ago) [Qingxiao Ren] * 2ebabf5 - Prevent VDM dictionary related KeyError when a transceiver module is pulled while a bulk get method is interrogating said module (sonic-net#360) (11 hours ago) [snider-nokia] * 1498ed6 - [CMIS] Add API to get module power up duration (sonic-net#354) (11 hours ago) [ChiouRung Haung] * 1cae718 - Modify get_host_lane_assignment_option to return value based on application id (sonic-net#352) (11 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to improve Issue #224