[tacacs+ test]: Add TACACS+ test by liuqu · Pull Request #372 · sonic-net/sonic-mgmt

liuqu · 2017-11-30T13:48:24Z

Add TACACS+ testcase
Add username and password for TACACS+ server

* Add TACACS+ testcase * Add username and password for TACACS+ server

maggiemsft · 2017-12-07T18:39:28Z

ansible/inventory

 ptf-1 ansible_host=10.0.0.200 ansible_ssh_user=root ansible_ssh_pass=password
+
+[tacacs_server]
+tacacs_server ansible_host=10.0.0.9 ansible_ssh_user=root ansible_ssh_pass=root


@liuqu are you using the default ptf docker within the testbed? I didn't closely follow up PRs in sonic-buildimage, is this server been included and deployed with testbed ptf docker?
did you add your Tacacs+ design/testing document to sonic/wiki so the community member can follow? (I remembered last time it's from your own repo)

Sorry too late to reply. You can find the the test plan in TACACS+ Test Plan.md
TACACS+ server is a host which installed tac_plus, not included in ptf docker. This configuration is used to save the username and password to ensure that TACACS+ server can be logined to execute sudo command.

The feature source address for TACACS+ is needed for source address test. It will be pulled request after the current PRs are merged.

lguohan · 2017-12-12T12:12:05Z

ansible/roles/test/tasks/tacacs_test.yml

+  become: true
+  shell: config aaa authentication failthrough default
+
+# Test source address


admin@str-s6000-on-4:~$ sudo config tacacs src_ip Usage: config tacacs [OPTIONS] COMMAND [ARGS]... Error: No such command "src_ip".

since src_ip is not supported in current version, I suggest to remove the src_ip test.

Already removed it.

lguohan · 2017-12-12T12:16:30Z

ansible/roles/test/tasks/tacacs_configure.yml

+  service:
+    name: tac_plus
+    state: started
+  delegate_to: "{{ tacacs_server }}"


suggest to move tacacs_server, passkey, test username, passwd all into test inventory. Make this as a testbed requirement, and leave the tacacs+ server setup outside of the test.

I suggest also remove the starting tacacs+ service and add comment indicating whoever perform the testbed needs to setup tacacs service manually to enable the test user and passwd and passkey.

Some comments have been added to inform user which setup need for TACACS+ testbed. The tacacs+ passkey, user account and password already moved to group_vars/lab/lab.yml

lguohan

as comments.

* The feature source address for TACACS+ hasn't been merged in current version, so remove src_ip test temporarily. * Remove configuration for TACACS+ service * Move TACACS+ passkey, user account and password to group_vars/lab/lab.yml * Move configure, testcase and cleanup to one file, remove redundant files. Signed-off-by: Chenchen Qi <[email protected]>

lguohan · 2020-03-06T05:43:35Z

superceded by #1428

… automatically (sonic-net#15133) src/sonic-platform-common * ff72811 - (HEAD -> 202205, origin/202205) Fix issue '<' not supported between instances of 'NoneType' and 'int' (sonic-net#371) (5 hours ago) [Junchao-Mellanox] * f2a419d - Render Media lane and Media assignment options info from Application Code (sonic-net#368) (8 hours ago) [rajann] * d8bad10 - Retrieve FW version using CDB command for CMIS transceivers + handle single bank FW versioning (sonic-net#372) (8 hours ago) [mihirpat1]

…D automatically (sonic-net#15347) src/sonic-platform-daemons * a90bff5 - (HEAD -> 202205, origin/202205) [ycabled] correct the wrong function call for 'config hwmode state' (sonic-net#372) (5 minutes ago) [vdahiya12]

…D automatically (sonic-net#15366) src/sonic-platform-daemons * 18815c7 - (HEAD -> 202205, origin/202205) Revert "[ycabled] refactor code for onboarding async client changes;refactor (sonic-net#355)" (3 minutes ago) [Ying Xie] * 5324554 - Revert "add async notification support in active-active topo; refactor code for ycable tasks for change events (sonic-net#327)" (3 minutes ago) [Ying Xie] * cbbe2b5 - Revert "[ycabled] fix bug for `show mux status` delayed response (sonic-net#364)" (3 minutes ago) [Ying Xie] * 9746709 - Revert "[dualtor] Fix command `show mux status` (sonic-net#371)" (3 minutes ago) [Ying Xie] * 551ab3c - Revert "[ycabled] correct the wrong function call for 'config hwmode state' (sonic-net#372)" (3 minutes ago) [Ying Xie]

…D automatically (sonic-net#15749) src/sonic-platform-daemons * 112656c - (HEAD -> 202205, origin/202205) [ycabled][active-active] no initialize Async Client, when no active-active cable type; fix names for all ycabled threads (sonic-net#373) (4 minutes ago) [vdahiya12] * e325d5a - Revert "Revert "[ycabled] correct the wrong function call for 'config hwmode state' (sonic-net#372)"" (4 minutes ago) [Ying Xie] * ddabca1 - Revert "Revert "[dualtor] Fix command `show mux status` (sonic-net#371)"" (4 minutes ago) [Ying Xie] * 28918da - Revert "Revert "[ycabled] fix bug for `show mux status` delayed response (sonic-net#364)"" (4 minutes ago) [Ying Xie] * a849de9 - Revert "Revert "add async notification support in active-active topo; refactor code for ycable tasks for change events (sonic-net#327)"" (4 minutes ago) [Ying Xie] * cf1e73a - Revert "Revert "[ycabled] refactor code for onboarding async client changes;refactor (sonic-net#355)"" (4 minutes ago) [Ying Xie]

… automatically (sonic-net#16332) #### Why I did it src/sonic-platform-common ``` * 05cf5c1 - (HEAD -> 202211, origin/202211) Change Y cable simulator log level from error to warning due to false alarm (11 hours ago) [ShiyanWangMS] * 35ea290 - Update CMIS api's rendering max-duration (sonic-net#375) (11 hours ago) [rajann] * 33bd498 - Retrieve FW version using CDB command for CMIS transceivers + handle single bank FW versioning (sonic-net#372) (11 hours ago) [mihirpat1] * 2434362 - Render Media lane and Media assignment options info from Application Code (sonic-net#368) (11 hours ago) [rajann] * 862674b - Modify sfputil show fwversion to include build version for active/inactive FW version fields (sonic-net#367) (11 hours ago) [mihirpat1] * 8edfece - Adding electrical for 800G and 100G (sonic-net#365) (11 hours ago) [mihirpat1] * 8a1debf - SFF-8472: Fix tx_disable_channel to avoid write to read-only bit (sonic-net#364) (11 hours ago) [mihirpat1] * 223a231 - Update host electrical interface for 2x400G breakout cable (sonic-net#363) (11 hours ago) [mihirpat1] * baabd8f - fix get module hardware minor revision (sonic-net#361) (11 hours ago) [Qingxiao Ren] * 2ebabf5 - Prevent VDM dictionary related KeyError when a transceiver module is pulled while a bulk get method is interrogating said module (sonic-net#360) (11 hours ago) [snider-nokia] * 1498ed6 - [CMIS] Add API to get module power up duration (sonic-net#354) (11 hours ago) [ChiouRung Haung] * 1cae718 - Modify get_host_lane_assignment_option to return value based on application id (sonic-net#352) (11 hours ago) [mihirpat1] ``` #### How I did it #### How to verify it #### Description for the changelog

[tacacs+ test]: Add TACACS+ test

cd4dd6f

* Add TACACS+ testcase * Add username and password for TACACS+ server

liuqu mentioned this pull request Dec 7, 2017

[TACACS+]: Add configDB enforcer for TACACS+ sonic-net/sonic-buildimage#1214

Merged

maggiemsft reviewed Dec 7, 2017

View reviewed changes

lguohan reviewed Dec 12, 2017

View reviewed changes

lguohan requested changes Dec 12, 2017

View reviewed changes

liuqu mentioned this pull request Dec 14, 2017

[TACACS+]: Add support to specify source address for TACACS+ sonic-net/sonic-buildimage#1238

Closed

lguohan closed this Mar 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tacacs+ test]: Add TACACS+ test#372

[tacacs+ test]: Add TACACS+ test#372
liuqu wants to merge 2 commits intosonic-net:masterfrom
liuqu:tacplus

liuqu commented Nov 30, 2017

Uh oh!

maggiemsft Dec 7, 2017

Uh oh!

liuqu Dec 11, 2017

Uh oh!

liuqu Dec 11, 2017

Uh oh!

lguohan Dec 12, 2017

Uh oh!

lguohan Dec 12, 2017

Uh oh!

liuqu Dec 12, 2017

Uh oh!

lguohan Dec 12, 2017

Uh oh!

liuqu Dec 12, 2017

Uh oh!

lguohan left a comment

Uh oh!

lguohan commented Mar 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

liuqu commented Nov 30, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lguohan left a comment

Choose a reason for hiding this comment

Uh oh!

lguohan commented Mar 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants