[link flap test] improve performance of link flap test by yxieca · Pull Request #319 · sonic-net/sonic-mgmt

yxieca · 2017-10-30T21:50:55Z

explicitly set conneciton local for local tasks
explicitly check the interface with down link without loop

- explicitly set conneciton local for local tasks - explicitly check the interface with down link without loop

stcheng · 2017-10-30T22:16:37Z

ansible/roles/test/tasks/link_flap/link_flap_helper.yml

      assert: { that: "'{{ ansible_interface_facts[item]['active'] }}' == 'True'" }
      with_items: "{{ minigraph_ports }}"
      when: item != "{{ intfs_to_exclude }}"
+      connection: local


I don't think to add connection: local is needed here.
Ansible will determine whether a command needs to be executed locally or not. It would be better to remove the conditions here.

Oops, I merged already.

But making it explicit should be good too?

If you insist, I can remove it when I am making the interface_facts.py change.

Cheers,
Ying

please remove

* msft_github/master: Update README.testbed.Setup.md call test by test case name (sonic-net#362) [testbed] fanout add rootfanout connect when deploying fanout switch (sonic-net#368) [lag_2] enable lag_2 test on t0-116 topology (sonic-net#390) [deployment] add missing quotation marks that breaks (sonic-net#386) Finalize T0-116 topology (sonic-net#381) Directed broadcast Test (sonic-net#377) [change_mac]: Change MAC address formatting (sonic-net#380) add github template helping report issues and submit pull request (sonic-net#378) Fixing logic to identify proper 'port_config.ini' file. (sonic-net#376) [sensors] add sensor definitions for arista 7260/7060 (sonic-net#371) [pfc_wd]: Rework for P2 (sonic-net#363) [test]: Update BGP speaker test (sonic-net#236) Add vm_resument which restore paused VMs (sonic-net#297) Copy acsbase files to ptf before ptf_runner (sonic-net#366) Modify dhcp_servers IPs in order to fix DHCP relay test (sonic-net#364) [templates]: Remove trailing space in t1-lag minigraph template (sonic-net#360) [fastreboot test]: Add "fanout_listener" for MLNX fanout switches (sonic-net#353) patch t0 portchannel name to 15 chars (sonic-net#358) [process_checker]: Add the process_checker playbook (sonic-net#349) fix issue 354 (sonic-net#355) Update build instruction for docker-ptf.gz and docker-sonic-mgmt.gz [upgrade_sonic]: Add upgrade_sonic as a convenience script to upgrade the device with an image (sonic-net#338) [acl test]: Generate switch info file. (sonic-net#346) fix t0 templates for generate minigraph (sonic-net#344) [loganalyzer_end.yml]: Rename expected_matches (sonic-net#345) [minigraph_facts]: Add the missing brace (sonic-net#342) [Arista7260cx3] update topology t0-116 to include port 17 and 19 (sonic-net#340) [fdb test] help switch populate mac table before starting the test (sonic-net#341) [arista7260cx3] include port 18 and 20 as 50G breakout ports (sonic-net#339) Loganalyzer enhancements (sonic-net#321) [plugin]: Adding Dell platform in switch connection plugin (sonic-net#333) modified files to get lag members from minigraph (sonic-net#327) [minigraph] modify script to fit the latest configuration method (sonic-net#331) [minigraph_fact] add port mapping for 5 INGRASYS switches (sonic-net#336) [sensors] add sensor data for 5 INGRASYS switches (sonic-net#335) [minigraph-template]: Add ACL L3 and mirroring tables to minigraph template. (sonic-net#330) [acltb-test]: Addopt ACL test to acl-loader. (sonic-net#299) [everflow test]: Addopt Everflow testbed test to acl-loader. (sonic-net#300) Remove hard-coded bgp speaker asn number, fetch from DUT (sonic-net#329) Port alias mapping added for Arista-7060CX-32S-C32 (sonic-net#328) Adding if case for S6100 platform to get port details (sonic-net#314) [interface_facts] improve interface facts checking performance (sonic-net#326) [fdb] Hard code port layout to enable fdb test on t0-116 topology (sonic-net#322) (sonic-net#320) [fib] Hard code port layout to enable fib test on t0-116 topology (sonic-net#322) [fib, fdb] Allow fib and fdb test info files to contain empty lines and comments (sonic-net#323) [lag_test]: Correct typo error for lag tests (sonic-net#325) [link flap test] improve performance of link flap test (sonic-net#319)

…nic-net#12870) platform-daemon: * f057b9a 2022-11-30 | [ycabled] fix minor appl_db retrieving logic for update (sonic-net#319) (HEAD -> 202205) [vdahiya12] * 9983106 2022-11-15 | [chassisd] update chassisd to write fabric and lc asics on sep erate table (sonic-net#311) (HEAD -> 202205) [arlakshm] * 8324c26 2022-11-10 | [ycabled] fix exception-handling logic for ycabled (sonic-net#306) [vdahiya12] * eaf73f8 2022-11-07 | [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#303) [vdahiya12] platform-common: * 4b528a0 2022-11-21 | Add missing PM and VDM related EEPROM read (sonic-net#326) (HEAD -> 202205) [mihirpat1] * 8ca6c17 2022-11-14 | Initial commit (sonic-net#323) [mihirpat1] * 47f87d9 2022-11-23 | EEPROM/DOM Info: The Compliance Code will show "unknown" by using FINISAR 10G LR XCVR (sonic-net#319) [ChiouRung Haung] * 6273850 2022-06-01 | [ssd_generic] Fix innodisk health regex (sonic-net#287) [Alexander Allen] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>

* 524685a 2018-05-14 | Ignore bridge port id in fdb consolidated event if value is NULL (sonic-net#319) (origin/201803) [Kamil Cudnik] * be0d9c3 2018-05-23 | Merge pull request sonic-net#321 from yxieca/syncd [Ying Xie] Signed-off-by: Guohan Lu <[email protected]>

d5f2877 Fix pfcwd start_default: Use config_db to get the active port list. (sonic-net#319) Signed-off-by: Guohan Lu <[email protected]>

…tomatically (sonic-net#16059) #### Why I did it src/sonic-linux-kernel ``` * bf1ee0e - (HEAD -> 202305, origin/202305) Fix Makefile syntax and provide default value for CONFIGURED_PLATFORM (sonic-net#324) (13 hours ago) [Saikrishna Arcot] * 7d7abaf - Update codeowner and build info (sonic-net#319) (13 hours ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog

…11 branch (sonic-net#13203) Why I did it advance sonic-platform-daemons submodule for 202211 branch a35b57d - (HEAD, origin/202211) Remove TODO comments which are no longer needed (Support centec platform sonic-net#325) (3 days ago) [Junchao-Mellanox] 3a3726b - [thermalctld] fix some redundant removal of state DB tables (configurations are re-generated across reboots sonic-net#315) (3 days ago) [vdahiya12] c5afac0 - Add new fields to status/dom_sensor/pm tables in STATE_DB for CMIS/C-CMIS (Combine alias_map.json with port_config.ini sonic-net#304) (3 days ago) [longhuan-cisco] 1a338d4 - Create TRANSCEIVER_DOM_THRESHOLD table in state DB (Fix the reference in docker-snmp-sv2 to deprecated alias_map.json sonic-net#320) (3 days ago) [mihirpat1] 7c77907 - Remove the argument that is causing the xcvrd to crash (ingrasys-s9100: Add ingrasys switch s9100 sonic-net#318) (3 days ago) [Vivek] 5a70e7f - [ycabled] fix minor appl_db retrieving logic for update (dockers/docker-snmp-sv2/config.sh still references deprecated alias_map.json file sonic-net#319) (3 days ago) [vdahiya12] b669533 - Use github code scanning instead of LGTM (Consolidate device-specific files; install as a Debian package sonic-net#316) (3 days ago) [Liu Shilong] d3c6739 - Pass grid parameter while calling set_laser_freq ([swss]: update sonic-swss to fix buffer configuration on mlnx platform sonic-net#317) (3 days ago) [mihirpat1] 778f843 - [PSU daemon] Support PSU power threshold checking (Add get_graph service to fetch minigraph automatically sonic-net#288) (9 days ago) [Stephen Sun] 707a720 - [chassisd] update chassisd to write fabric and lc asics on sep erate table (ingrasys-s9100: Add ingrasys switch s9100 sonic-net#311) (8 weeks ago) [arlakshm] e8c5657 - [ycabled] fix exception-handling logic for ycabled (Move sysDescription to /etc/snmp sonic-net#306) (8 weeks ago) [vdahiya12] 905874d - [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (Disable BCM54616S MII isolate mode sonic-net#303) (9 weeks ago) [vdahiya12] 510d330 - Fix typo in xcvrd ([platform] Add support configurations files for DCS-7060CX-32S sonic-net#313) (9 weeks ago) [Junchao-Mellanox] 9ae551f - [ycabled] add support for detach mode in 'active-active' topology (minigraph.py crashed when no png is in the minigraph sonic-net#309) (2 months ago) [vdahiya12] How I did it How to verify it

[link flap test] improve performance of link flap test

8767e3e

- explicitly set conneciton local for local tasks - explicitly check the interface with down link without loop

maggiemsft approved these changes Oct 30, 2017

View reviewed changes

yxieca merged commit 8f2e672 into sonic-net:master Oct 30, 2017

yxieca deleted the link_flap branch October 30, 2017 22:09

stcheng added the Enhancement label Oct 30, 2017

stcheng reviewed Oct 30, 2017

View reviewed changes

kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026

[submodules]: update sonic-utilities

1fa607c

d5f2877 Fix pfcwd start_default: Use config_db to get the active port list. (sonic-net#319) Signed-off-by: Guohan Lu <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[link flap test] improve performance of link flap test#319

[link flap test] improve performance of link flap test#319
yxieca merged 1 commit intosonic-net:masterfrom
yxieca:link_flap

yxieca commented Oct 30, 2017

Uh oh!

stcheng Oct 30, 2017

Uh oh!

yxieca Oct 30, 2017

Uh oh!

lguohan Oct 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

yxieca commented Oct 30, 2017

Uh oh!

stcheng Oct 30, 2017

Choose a reason for hiding this comment

Uh oh!

yxieca Oct 30, 2017

Choose a reason for hiding this comment

Uh oh!

lguohan Oct 30, 2017

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants