Merged
Conversation
Updated run_config_test.yml to support new loganalyzer output
qiluo-msft
reviewed
Oct 31, 2017
| out_file.write("-----------------------------------\n") | ||
| out_file.write("TOTAL MATCHES: %d\n" % total_match_cnt) | ||
| out_file.write("TOTAL EXPECTED MATCHES: %d\n" % total_expect_cnt) | ||
| out_file.write("TOTAL EXPECTED MISSING MATCHES: %d\n" % len(unused_regex_messages)) |
Contributor
There was a problem hiding this comment.
TOTAL EXPECTED MISSING MATCHES: [](start = 20, length = 32)
Do you need to change back the grep command which modified by Maggie, in this PR? #Closed
Contributor
There was a problem hiding this comment.
Yeah, could your please change the loganalyzer_end.yml which process the different result for validation?
Signed-off-by: marian-pritsak <[email protected]>
qiluo-msft
reviewed
Nov 1, 2017
| #--------------------------------------------------------------------- | ||
|
|
||
| def is_filename_stdin(self, file_name): | ||
| return True if file_name == "-" else False |
Contributor
There was a problem hiding this comment.
return True if file_name == "-" else False [](start = 8, length = 42)
return file_name == "-" #Closed
qiluo-msft
reviewed
Nov 1, 2017
| #-- indicates whether log analyzer currently is in the log range between start | ||
| #-- and end marker. see analyze_file method. | ||
| in_analysis_range = False | ||
| stdin_as_input = True if self.is_filename_stdin(log_file_path) else False |
Contributor
There was a problem hiding this comment.
True if self.is_filename_stdin(log_file_path) else False [](start = 25, length = 56)
self.is_filename_stdin(log_file_path) #Closed
maggiemsft
reviewed
Nov 3, 2017
|
|
||
| - set_fact: | ||
| fail_in_logs: "{{ errors_found.stdout != \"0\" or expected_matches.stdout != \"0\" }}" | ||
| fail_in_logs: errors_found.stdout != "0" or expected_missing_matches.stdout != "0" |
Contributor
There was a problem hiding this comment.
I think without the quote, it failed comparison while I tried it. Did you check this in your running? what's your ansible version?
Contributor
Author
There was a problem hiding this comment.
2.0.0.2
I reverted this change.
maggiemsft
approved these changes
Nov 7, 2017
qiluo-msft
approved these changes
Nov 7, 2017
praveen-li
pushed a commit
to praveen-li/sonic-mgmt
that referenced
this pull request
Jun 20, 2019
* msft_github/master: Update README.testbed.Setup.md call test by test case name (sonic-net#362) [testbed] fanout add rootfanout connect when deploying fanout switch (sonic-net#368) [lag_2] enable lag_2 test on t0-116 topology (sonic-net#390) [deployment] add missing quotation marks that breaks (sonic-net#386) Finalize T0-116 topology (sonic-net#381) Directed broadcast Test (sonic-net#377) [change_mac]: Change MAC address formatting (sonic-net#380) add github template helping report issues and submit pull request (sonic-net#378) Fixing logic to identify proper 'port_config.ini' file. (sonic-net#376) [sensors] add sensor definitions for arista 7260/7060 (sonic-net#371) [pfc_wd]: Rework for P2 (sonic-net#363) [test]: Update BGP speaker test (sonic-net#236) Add vm_resument which restore paused VMs (sonic-net#297) Copy acsbase files to ptf before ptf_runner (sonic-net#366) Modify dhcp_servers IPs in order to fix DHCP relay test (sonic-net#364) [templates]: Remove trailing space in t1-lag minigraph template (sonic-net#360) [fastreboot test]: Add "fanout_listener" for MLNX fanout switches (sonic-net#353) patch t0 portchannel name to 15 chars (sonic-net#358) [process_checker]: Add the process_checker playbook (sonic-net#349) fix issue 354 (sonic-net#355) Update build instruction for docker-ptf.gz and docker-sonic-mgmt.gz [upgrade_sonic]: Add upgrade_sonic as a convenience script to upgrade the device with an image (sonic-net#338) [acl test]: Generate switch info file. (sonic-net#346) fix t0 templates for generate minigraph (sonic-net#344) [loganalyzer_end.yml]: Rename expected_matches (sonic-net#345) [minigraph_facts]: Add the missing brace (sonic-net#342) [Arista7260cx3] update topology t0-116 to include port 17 and 19 (sonic-net#340) [fdb test] help switch populate mac table before starting the test (sonic-net#341) [arista7260cx3] include port 18 and 20 as 50G breakout ports (sonic-net#339) Loganalyzer enhancements (sonic-net#321) [plugin]: Adding Dell platform in switch connection plugin (sonic-net#333) modified files to get lag members from minigraph (sonic-net#327) [minigraph] modify script to fit the latest configuration method (sonic-net#331) [minigraph_fact] add port mapping for 5 INGRASYS switches (sonic-net#336) [sensors] add sensor data for 5 INGRASYS switches (sonic-net#335) [minigraph-template]: Add ACL L3 and mirroring tables to minigraph template. (sonic-net#330) [acltb-test]: Addopt ACL test to acl-loader. (sonic-net#299) [everflow test]: Addopt Everflow testbed test to acl-loader. (sonic-net#300) Remove hard-coded bgp speaker asn number, fetch from DUT (sonic-net#329) Port alias mapping added for Arista-7060CX-32S-C32 (sonic-net#328) Adding if case for S6100 platform to get port details (sonic-net#314) [interface_facts] improve interface facts checking performance (sonic-net#326) [fdb] Hard code port layout to enable fdb test on t0-116 topology (sonic-net#322) (sonic-net#320) [fib] Hard code port layout to enable fib test on t0-116 topology (sonic-net#322) [fib, fdb] Allow fib and fdb test info files to contain empty lines and comments (sonic-net#323) [lag_test]: Correct typo error for lag tests (sonic-net#325) [link flap test] improve performance of link flap test (sonic-net#319)
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
* 524685a 2018-05-14 | Ignore bridge port id in fdb consolidated event if value is NULL (sonic-net#319) (origin/201803) [Kamil Cudnik] * be0d9c3 2018-05-23 | Merge pull request sonic-net#321 from yxieca/syncd [Ying Xie] Signed-off-by: Guohan Lu <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…tomatically (sonic-net#16431) #### Why I did it src/sonic-linux-kernel ``` * 9cb7ea0 - (HEAD -> 202305, origin/202305) arm64: dts: marvell: Add Nokia 7215-IXS-A1 board (sonic-net#321) (24 hours ago) [Pavan-Nokia] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update loganalyzer to read stdin
Fixed loganalyzer expect logic