[action] [PR:16057] chore: skip PSU check for chassis LC#16332
Merged
mssonicbld merged 1 commit intosonic-net:202411from Jan 3, 2025
Merged
[action] [PR:16057] chore: skip PSU check for chassis LC#16332mssonicbld merged 1 commit intosonic-net:202411from
mssonicbld merged 1 commit intosonic-net:202411from
Conversation
Description of PR Skip platform_tests/test_platform_info.py::test_turn_on_off_psu_and_check_psustatus for chassis LC Summary: Fixes # (issue) Microsoft ADO 30114143 Approach What is the motivation for this PR? Due to the module-level enumerate fixture psu_test_setup_teardown that has enum_rand_one_per_hwsku_hostname in this test module, we will run platform_tests/test_platform_info.py::test_turn_on_off_psu_and_check_psustatus multiple times when it's a T2 chassis. However, we don't need to run it multiple times because we are just toggling the PDU/PSU on the supervisor card in this test case. Therefore, we should skip the runs when the parametrization is on LCs. How did you do it? How did you verify/test it? Ran it on T2 and I can confirm it's only run for supervisor parametrization. Any platform specific information? Supported testbed topology if it's a new test case? co-authorized by: jianquanye@microsoft.com
Collaborator
Author
|
/azp run |
8 tasks
Collaborator
Author
|
Original PR: #16057 |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Skip
platform_tests/test_platform_info.py::test_turn_on_off_psu_and_check_psustatusfor chassis LCSummary:
Fixes # (issue) Microsoft ADO 30114143
Type of change
Back port request
Approach
What is the motivation for this PR?
Due to the module-level enumerate fixture
psu_test_setup_teardownthat hasenum_rand_one_per_hwsku_hostnamein this test module, we will runplatform_tests/test_platform_info.py::test_turn_on_off_psu_and_check_psustatusmultiple times when it's a T2 chassis. However, we don't need to run it multiple times because we are just toggling the PDU/PSU on the supervisor card in this test case. Therefore, we should skip the runs when the parametrization is on LCs.How did you do it?
How did you verify/test it?
Ran it on T2 and I can confirm it's only run for supervisor parametrization.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation