Skip to content

[process_checker]: Add the process_checker playbook#349

Merged
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:process
Nov 17, 2017
Merged

[process_checker]: Add the process_checker playbook#349
stcheng merged 1 commit intosonic-net:masterfrom
stcheng:process

Conversation

@stcheng
Copy link
Contributor

@stcheng stcheng commented Nov 16, 2017

No description provided.

@stcheng stcheng merged commit ec19e40 into sonic-net:master Nov 17, 2017
@stcheng stcheng deleted the process branch November 17, 2017 20:10
praveen-li pushed a commit to praveen-li/sonic-mgmt that referenced this pull request Jun 20, 2019
* msft_github/master:
  Update README.testbed.Setup.md
  call test by test case name (sonic-net#362)
  [testbed] fanout add rootfanout connect when deploying fanout switch (sonic-net#368)
  [lag_2] enable lag_2 test on t0-116 topology (sonic-net#390)
  [deployment] add missing quotation marks that breaks (sonic-net#386)
  Finalize T0-116 topology (sonic-net#381)
  Directed broadcast Test (sonic-net#377)
  [change_mac]: Change MAC address formatting (sonic-net#380)
  add github template helping report issues and submit pull request (sonic-net#378)
  Fixing logic to identify proper 'port_config.ini' file. (sonic-net#376)
  [sensors] add sensor definitions for arista 7260/7060 (sonic-net#371)
  [pfc_wd]: Rework for P2 (sonic-net#363)
  [test]: Update BGP speaker test (sonic-net#236)
  Add vm_resument which restore paused VMs (sonic-net#297)
  Copy acsbase files to ptf before ptf_runner (sonic-net#366)
  Modify dhcp_servers IPs in order to fix DHCP relay test (sonic-net#364)
  [templates]: Remove trailing space in t1-lag minigraph template (sonic-net#360)
  [fastreboot test]: Add "fanout_listener" for MLNX fanout switches (sonic-net#353)
  patch t0 portchannel name to 15 chars (sonic-net#358)
  [process_checker]: Add the process_checker playbook (sonic-net#349)
  fix issue 354 (sonic-net#355)
  Update build instruction for docker-ptf.gz and docker-sonic-mgmt.gz
  [upgrade_sonic]: Add upgrade_sonic as a convenience script to upgrade the device with an image (sonic-net#338)
  [acl test]: Generate switch info file. (sonic-net#346)
  fix t0 templates for generate minigraph (sonic-net#344)
  [loganalyzer_end.yml]: Rename expected_matches (sonic-net#345)
  [minigraph_facts]: Add the missing brace (sonic-net#342)
  [Arista7260cx3] update topology t0-116 to include port 17 and 19 (sonic-net#340)
  [fdb test] help switch populate mac table before starting the test (sonic-net#341)
  [arista7260cx3] include port 18 and 20 as 50G breakout ports (sonic-net#339)
  Loganalyzer enhancements (sonic-net#321)
  [plugin]: Adding Dell platform in switch connection plugin (sonic-net#333)
  modified files to get lag members from minigraph (sonic-net#327)
  [minigraph] modify script to fit the latest configuration method (sonic-net#331)
  [minigraph_fact] add port mapping for 5 INGRASYS switches (sonic-net#336)
  [sensors] add sensor data for 5 INGRASYS switches (sonic-net#335)
  [minigraph-template]: Add ACL L3 and mirroring tables to minigraph template. (sonic-net#330)
  [acltb-test]: Addopt ACL test to acl-loader. (sonic-net#299)
  [everflow test]: Addopt Everflow testbed test to acl-loader. (sonic-net#300)
  Remove hard-coded bgp speaker asn number, fetch from DUT (sonic-net#329)
  Port alias mapping added for Arista-7060CX-32S-C32 (sonic-net#328)
  Adding if case for S6100 platform to get port details (sonic-net#314)
  [interface_facts] improve interface facts checking performance (sonic-net#326)
  [fdb] Hard code port layout to enable fdb test on t0-116 topology (sonic-net#322) (sonic-net#320)
  [fib] Hard code port layout to enable fib test on t0-116 topology (sonic-net#322)
  [fib, fdb] Allow fib and fdb test info files to contain empty lines and comments (sonic-net#323)
  [lag_test]: Correct typo error for lag tests (sonic-net#325)
  [link flap test] improve performance of link flap test (sonic-net#319)
sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request Jun 14, 2025
… assert failure (sonic-net#349)

### Description of PR

Summary:
Fixes # (issue)
Depending on how buffer queues have been configured in CONFIG_DB, it's possible that the logic in `snmp/test_snmp_queue_counters` will reload CONFIG_DB with zero buffer queue configuration and then assert that there should be at least one buffer queue present. This PR is a workaround for this failure.

### Type of change
- [x] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
Addressing this issue increased our test passing rate for SKUs that had all buffer queues configured as lossy. Typically we had 2 queues configured as lossless which is why we weren't seeing this failure until now.

#### How did you do it?
Instead of letting the test wipe out all buffer_queue configuration, I modified the tests copy of the configuration to ensure one of the buffer queues remains when CONFIG_DB is reloaded. This modification is a special case that only applies to SKUs with a single BUFFER_QUEUE entry in CONFIG_DB. This allows the test to run as usual since the assert of at least one buffer_queue coming up after config reload is now valid.

#### How did you verify/test it?
Verified by running `snmp/test_snmp_queue_counters.py` with and without the fix. With the fix, the test gets past the assert as expected.
#### Any platform specific information?
For SKUs that have both lossy and lossless buffer queues configured, the code path hasn't changed.

#### Supported testbed topology if it's a new test case?
No new test case.
### Documentation
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…net#14561)

Why I did it
src/sonic-platform-common

* 41e2a6e - (HEAD -> 202205, origin/202205) Fix pipeline apt-get purge error. (sonic-net#349) (sonic-net#358) (6 days ago) [Liu Shilong]
src/sonic-swss

* 804e5ac - (HEAD -> 202205, origin/202205) [FDB]Fixing FDB consolidated flush for Remote MACs (sonic-net#2673) (sonic-net#2725) (4 hours ago) [Sudharsan Dhamal Gopalarathnam]
src/sonic-utilities

* ea1d849a - (HEAD -> 202205, origin/202205) Use sonic-swss-common artifacts from the matching source branch (sonic-net#2783) (5 days ago) [Saikrishna Arcot]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
… automatically (sonic-net#14654)

src/sonic-platform-common

* 41e2a6e - (HEAD -> 202205, origin/202205) Fix pipeline apt-get purge error. (sonic-net#349) (sonic-net#358) (11 days ago) [Liu Shilong]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant