Merged
Conversation
|
@maggiemsft, |
pavel-shirshov
approved these changes
May 25, 2017
lguohan
pushed a commit
that referenced
this pull request
Aug 3, 2017
nhe-NV
pushed a commit
to nhe-NV/sonic-mgmt
that referenced
this pull request
May 12, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes same issue in [sonic-net#22022](sonic-net/sonic-buildimage#22022) by updating the peer T0's ASN to 4 bytes ASN number. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 ### Approach #### What is the motivation for this PR? Fix topo error. #### How did you do it? #### How did you verify/test it? ``` admin@sonic:~$ show ip bgp summary IPv4 Unicast Summary: BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0 BGP table version 2 RIB entries 3, using 672 bytes of memory Peers 12, using 8903712 KiB of memory Peer groups 5, using 320 bytes of memory Neighbhor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd NeighborName ----------- --- ---------- --------- --------- -------- ----- ------ --------- -------------- -------------- 10.0.0.57 4 64600 0 0 0 0 0 never Active ARISTA01T1 10.0.0.59 4 64600 0 0 0 0 0 never Active ARISTA02T1 10.0.0.61 4 64600 0 0 0 0 0 never Active ARISTA03T1 10.0.0.63 4 64600 0 0 0 0 0 never Active ARISTA04T1 10.0.0.65 4 64600 0 0 0 0 0 never Active ARISTA05T1 10.0.0.67 4 64600 0 0 0 0 0 never Active ARISTA06T1 10.0.0.69 4 64600 0 0 0 0 0 never Active ARISTA07T1 10.0.0.71 4 64600 0 0 0 0 0 never Active ARISTA08T1 10.0.0.157 4 4200000000 0 0 0 0 0 never Active ARISTA01PT0 10.0.0.159 4 4200000001 0 0 0 0 0 never Active ARISTA02PT0 10.0.0.161 4 4200000002 0 0 0 0 0 never Active ARISTA03PT0 10.0.0.163 4 4200000003 0 0 0 0 0 never Active ARISTA04PT0 Total number of neighbors 12 admin@sonic:~$ show ipv6 bgp summary IPv6 Unicast Summary: BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0 BGP table version 2 RIB entries 3, using 672 bytes of memory Peers 12, using 8903712 KiB of memory Peer groups 5, using 320 bytes of memory Neighbhor V AS MsgRcvd MsgSent TblVer InQ OutQ Up/Down State/PfxRcd NeighborName ----------- --- ---------- --------- --------- -------- ----- ------ --------- -------------- -------------- fc00::7a 4 64600 0 0 0 0 0 never Active ARISTA03T1 fc00::7e 4 64600 0 0 0 0 0 never Active ARISTA04T1 fc00::8a 4 64600 0 0 0 0 0 never Active ARISTA07T1 fc00::8e 4 64600 0 0 0 0 0 never Active ARISTA08T1 fc00::17a 4 4200000002 0 0 0 0 0 never Active ARISTA03PT0 fc00::17e 4 4200000003 0 0 0 0 0 never Active ARISTA04PT0 fc00::72 4 64600 0 0 0 0 0 never Active ARISTA01T1 fc00::76 4 64600 0 0 0 0 0 never Active ARISTA02T1 fc00::82 4 64600 0 0 0 0 0 never Active ARISTA05T1 fc00::86 4 64600 0 0 0 0 0 never Active ARISTA06T1 fc00::172 4 4200000000 0 0 0 0 0 never Active ARISTA01PT0 fc00::176 4 4200000001 0 0 0 0 0 never Active ARISTA02PT0 Total number of neighbors 12 admin@sonic:~$ ``` #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Includes below sonic-snmpagent commits ``` dfde06e 2021-01-13 | Revert "[rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (sonic-net#169)" (sonic-net#191) [Stepan Blyshchak] 45edd7e 2021-01-04 | [snmpagent] Fix hardcoded qsfp lane count by reading sensor status from DB (sonic-net#184) [Junchao-Mellanox] 3b72a6f 2021-01-02 | Fix: handle empty LOC_CHASSIS_TABLE (sonic-net#190) [Qi Luo] 4aad821 2020-12-29 | [sysName]: Implement sysName OID (sonic-net#185) [SuvarnaMeenakshi] 8efb4bb 2020-12-29 | [rfc1213] fix counter value type (sonic-net#189) [Stepan Blyshchak] 025483a 2020-12-23 | [RouteUpdater]: Fix multi_asic mock function implementation and multi_asic variable name (sonic-net#186) [SuvarnaMeenakshi] 381ae47 2020-12-10 | [mibs] b'VLAN_TABLE:' -> 'VLAN_TABLE' (sonic-net#181) [Stepan Blyshchak] e54036c 2020-12-09 | [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (sonic-net#169) [Stepan Blyshchak] fd1eae7 2020-11-24 | Set swsscommon logging level (sonic-net#178) [Qi Luo] 706d504 2020-11-23 | Improve MockRedis _encode(): so it will work on all types of value (sonic-net#179) [Qi Luo] 64c93a1 2020-11-16 | [RFC4292][Namespace]: Fix implementation of RouteUpdater for multi-asic platform (sonic-net#176) [SuvarnaMeenakshi] b8f19ee 2020-11-12 | [sonic-snmpagent] SONiC physical entity mib extension (sonic-net#168) [Junchao-Mellanox] 6b94ec3 2020-11-05 | Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code (sonic-net#162) [Qi Luo] ``` Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com> Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…net#14412) Why I did it src/linkmgrd * 3403160 - (HEAD -> 202205, origin/202205) [ci] fix azure pipeline (sonic-net#190) (33 hours ago) [Jing Zhang] * 95abb4c - [active-standby] avoid unnecessary mux state probe after configuring to `auto` (sonic-net#183) (33 hours ago) [Jing Zhang] * 9277650 - [ci] Fix apt-get install unable locate package issue. (sonic-net#177) (33 hours ago) [Liu Shilong] src/sonic-linux-kernel * 836aedf - (HEAD -> 202205, origin/202205) [202205] Add Secure Boot Kernel configuration (sonic-net#310) (35 hours ago) [Sachin Naik] src/sonic-platform-common * 9b367e4 - (HEAD -> 202205, origin/202205) Modify get_host_lane_assignment_option to return value based on application id (sonic-net#352) (33 hours ago) [mihirpat1] src/sonic-platform-daemons * a6015f2 - (HEAD -> 202205, origin/202205) chassisd: Fix crash on exit on linecard (sonic-net#347) (33 hours ago) [Patrick MacArthur] * dcc0079 - [Supervisor][fabric] Modify the deinit function not to remove CHASSIS_FABRIC_ASIC_TABLE when supervisorctl stop chassisd (sonic-net#340) (33 hours ago) [prem-nokia] src/sonic-swss * a2f1428 - (HEAD -> 202205, origin/202205) Run individule pytests instead of running all pytests at once. (sonic-net#2350) (33 hours ago) [mint570] src/sonic-swss-common * 643132e - (HEAD -> 202205, origin/202205) Fix mod_config with empty config will delete table bug. (sonic-net#767) (34 hours ago) [Hua Liu] * 4c7ee30 - Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (sonic-net#720) (34 hours ago) [Saikrishna Arcot]
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#18256) #### Why I did it src/sonic-gnmi ``` * 71ae185 - (HEAD -> 202305, origin/202305) Merge pull request sonic-net#202 from sonic-net/revert-191-cherry/202305/190 (82 minutes ago) [StormLiangMS] |\ | failure_prs.log e2b78b4 - (origin/revert-191-cherry/202305/190) Revert "Fix sonic string in osversion/build (sonic-net#190)" (2 hours ago) [StormLiangMS] |/ * b431273 - Account for GLOBAL key in PFC_WD (sonic-net#178) (6 days ago) [Zain Budhwani] * e1af33f - Merge pull request sonic-net#199 from abdosi/202305 (6 days ago) [StormLiangMS] |\ | failure_prs.log f7e216b - Update db_client.go (6 days ago) [abdosi] |/ * ec3f56d - Fix sonic string in osversion/build (sonic-net#190) (9 days ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#18674) #### Why I did it src/sonic-gnmi ``` * 395a246 - (HEAD -> 202305, origin/202305) Merge pull request sonic-net#205 from sonic-net/revert-202-revert-191-cherry/202305/190 (23 hours ago) [StormLiangMS] * 92d3363 - (origin/revert-202-revert-191-cherry/202305/190) Merge branch '202305' into revert-202-revert-191-cherry/202305/190 (9 days ago) [StormLiangMS] * 0f36f52 - Revert "Revert "[action] [PR:190] Fix sonic string in osversion/build (sonic-net#190)"" (3 weeks ago) [Zain Budhwani] ``` #### How I did it #### How to verify it #### Description for the changelog
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#15576) #### Why I did it src/linkmgrd ``` * fc6e299 - (HEAD -> 202211, origin/202211) [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (sonic-net#184) (2 hours ago) [Jing Zhang] * 5c6332d - Re-handle pre-init mux config notification after state machine init (sonic-net#202) (2 hours ago) [Longxiang Lyu] * c49a5ef - [active-standby][bsl] fix no mux probe issue (sonic-net#201) (2 hours ago) [Jing Zhang] * 2d62ef1 - Enable debug symbols (sonic-net#199) (2 hours ago) [Longxiang Lyu] * f952b64 - [active-active] Add mux server state correction mechanism (sonic-net#191) (2 hours ago) [Longxiang Lyu] * e6b1bfc - [ci] fix azure pipeline (sonic-net#190) (2 hours ago) [Jing Zhang] * 615ed21 - [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (sonic-net#184) (2 hours ago) [Jing Zhang] * 3adfc69 - [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (sonic-net#179) (2 hours ago) [Jing Zhang] * 6fb9a0b - loose link down swithcover condition (sonic-net#178) (2 hours ago) [Jing Zhang] * 8ffbd8a - [ci] Fix apt-get install unable locate package issue. (sonic-net#177) (2 hours ago) [Liu Shilong] * 3dfbdd7 - [active-active] link operational down didn't trigger toggle to standby if `MuxUnknown` event arrives first. (sonic-net#175) (2 hours ago) [Jing Zhang] * 68c06d9 - [active-active] Toggle to standby if default route is missing (sonic-net#171) (2 hours ago) [Longxiang Lyu] * 1592cd3 - [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (sonic-net#169) (2 hours ago) [Jing Zhang] * a96105f - Fix the warning of unused variables (sonic-net#167) (2 hours ago) [Longxiang Lyu] * 984ffe3 - Fix mux config when gRPC connection is lost (sonic-net#166) (2 hours ago) [Longxiang Lyu] * 4d0b457 - [active-active] force switch when config == active && target state == active (sonic-net#164) (2 hours ago) [Jing Zhang] * 32bd2bb - Use github code scanning instead of LGTM (sonic-net#157) (2 hours ago) [Liu Shilong] * 6f23fe2 - [active-active] update linkmgr health label definition (sonic-net#163) (3 hours ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.