Skip to content

[bgp-scale-test] reorder test cases to avoid device unisolation test effect other tests#18256

Merged
Blueve merged 1 commit intosonic-net:masterfrom
w1nda:change-order-of-bgp-scale-test-case
May 7, 2025
Merged

[bgp-scale-test] reorder test cases to avoid device unisolation test effect other tests#18256
Blueve merged 1 commit intosonic-net:masterfrom
w1nda:change-order-of-bgp-scale-test-case

Conversation

@w1nda
Copy link
Member

@w1nda w1nda commented May 7, 2025

Description of PR

Summary:
Fixes # (issue)
The device unisolation test will restart all ports on DUT, after all bgp routes were stable in FRR after ports restart, however, the routes may not stable in ASIC, so the member scale test will be affected. To avoid this, move the device unisolation test to the last.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

The device unisolation test will restart all ports on DUT, after all bgp routes were stable in FRR after ports restart, however, the routes may not stable in ASIC, so the member scale test will be affected.

How did you do it?

To avoid this, move the device unisolation test to the last.

How did you verify/test it?

Run test on DUT

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@w1nda w1nda requested a review from StormLiangMS as a code owner May 7, 2025 08:34
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@w1nda w1nda requested review from Blueve and r12f May 7, 2025 13:01
@Blueve
Copy link
Collaborator

Blueve commented May 7, 2025

This can only be a short term solution. For long-term, we need a checker to ensure the ASIC DB is expected before we entering the test case.

@Blueve Blueve merged commit c6c4fae into sonic-net:master May 7, 2025
15 checks passed
@r12f
Copy link
Collaborator

r12f commented May 10, 2025

hi @w1nda , I wonder if you could help do a manual cherry pick to 202412?

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-mgmt.msft#266

opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
…effect other tests (sonic-net#18256)

What is the motivation for this PR?
The device unisolation test will restart all ports on DUT, after all bgp routes were stable in FRR after ports restart, however, the routes may not stable in ASIC, so the member scale test will be affected.

How did you do it?
To avoid this, move the device unisolation test to the last.

How did you verify/test it?
Run test on DUT

Signed-off-by: opcoder0 <[email protected]>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
…effect other tests (sonic-net#18256)

What is the motivation for this PR?
The device unisolation test will restart all ports on DUT, after all bgp routes were stable in FRR after ports restart, however, the routes may not stable in ASIC, so the member scale test will be affected.

How did you do it?
To avoid this, move the device unisolation test to the last.

How did you verify/test it?
Run test on DUT

Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
…effect other tests (sonic-net#18256)

What is the motivation for this PR?
The device unisolation test will restart all ports on DUT, after all bgp routes were stable in FRR after ports restart, however, the routes may not stable in ASIC, so the member scale test will be affected.

How did you do it?
To avoid this, move the device unisolation test to the last.

How did you verify/test it?
Run test on DUT

Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
…effect other tests (sonic-net#18256)

What is the motivation for this PR?
The device unisolation test will restart all ports on DUT, after all bgp routes were stable in FRR after ports restart, however, the routes may not stable in ASIC, so the member scale test will be affected.

How did you do it?
To avoid this, move the device unisolation test to the last.

How did you verify/test it?
Run test on DUT

Signed-off-by: Guy Shemesh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants