Skip to content

[TestLAG] add additional/alternative lag_2 test #199

Merged
lguohan merged 6 commits intosonic-net:masterfrom
maggiemsft:masun/lag_2
Jun 17, 2017
Merged

[TestLAG] add additional/alternative lag_2 test #199
lguohan merged 6 commits intosonic-net:masterfrom
maggiemsft:masun/lag_2

Conversation

@maggiemsft
Copy link
Contributor

@maggiemsft maggiemsft commented Jun 9, 2017

  1. add lag_2 test to use lab graph file to identify fanout switch ports;
  2. modify the lacp_timing playbook be able to validate both fast and slow rate;
  3. leave traffic balancing part to FIB test

@maggiemsft
add additional/alternative lag test for using lab graph file to ident…
78bfc27 
…ify fanout switch ports; modify the lacp_time playbook be able to validate both fast and slow rate; leave traffic balancing part of lag test to FIB test
@msftclas
Copy link

msftclas commented Jun 9, 2017

@maggiemsft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@lguohan
Copy link
Contributor

lguohan commented Jun 13, 2017

please remove the lag test being replaced.

lguohan
lguohan reviewed Jun 13, 2017
View reviewed changes
ansible/roles/test/tasks/single_lag_test.yml
peer_hwsku: 'Arista-VM'

- set_fact:
peer_host: "{{ lldp[flap_intf]['chassis']['mgmt-ip'] }}"
Copy link
Contributor

@lguohan lguohan Jun 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please mark this as todo, we should really use the testbed info to deduce the mgmt ip of the arista vm, not using lldp.

Copy link
Contributor Author

@maggiemsft maggiemsft Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, will add it later

lguohan
lguohan reviewed Jun 13, 2017
View reviewed changes
ansible/roles/test/tasks/single_lag_test.yml Outdated
- pause:
seconds: 5

- name: test lacp packet seending rate is 30 seconds
Copy link
Contributor

@lguohan lguohan Jun 13, 2017 •
edited by maggiemsft
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seending -> sending

Copy link
Contributor Author

@maggiemsft maggiemsft Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solved

Copy link
Contributor Author

@maggiemsft maggiemsft Jun 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the origin lagall.yml may still work for others if they only use one fanout switch,
I want to first ask around see if anyone is using it, if no, then I'll remove them in future improvement.

@maggiemsft
add todo and fix typo
0180b8b
@maggiemsft
Pretty much sure lacp timing issue is covered by lag_2.yml, all other…
dd0e239 
… existing lab tests, not very sure if they are still working or not since cannot test in my environment. Will leave it here until I can confirm no one is running it
lguohan
lguohan reviewed Jun 16, 2017
View reviewed changes
ansible/roles/test/tasks/single_lag_test.yml Outdated
- pause:
seconds: 5

- name: test lacp packet seending rate is 30 seconds
Copy link
Contributor

@lguohan lguohan Jun 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seending [](start = 25, length = 8)

sending

lguohan
lguohan reviewed Jun 16, 2017
View reviewed changes
ansible/roles/test/tasks/lag_minlink.yml Outdated
assert: { that: "'{{ lag_facts.lags[po]['po_stats']['ports'][item]['link']['up'] }}' == 'True'" }
with_items: "{{ po_interfaces.keys() }}"

- name: verify port-channel {{ po }} interface are marked up ncorrectly
Copy link
Contributor

@lguohan lguohan Jun 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrectly

@lguohan
Copy link
Contributor

lguohan commented Jun 16, 2017

:shipit:

lguohan
lguohan approved these changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor fixes.

@lguohan lguohan merged commit 2a625d0 into sonic-net:master Jun 17, 2017
@maggiemsft maggiemsft deleted the masun/lag_2 branch July 5, 2017 20:41
lguohan pushed a commit that referenced this pull request Aug 3, 2017
@maggiemsft @lguohan
[TestLAG] add additional/alternative lag_2 test (#199)
7b25559 
* add additional/alternative lag test for using lab graph file to identify fanout switch ports; modify the lacp_time playbook be able to validate both fast and slow rate; leave traffic balancing part of lag test to FIB test

* modify it run for T0 lag too

* add todo and fix typo

* Pretty much sure lacp timing issue is covered by lag_2.yml, all other existing lab tests, not very sure if they are still working or not since cannot test in my environment. Will leave it here until I can confirm no one is running it

* minor typo fix

* fix comment
nhe-NV pushed a commit to nhe-NV/sonic-mgmt that referenced this pull request May 12, 2025
@mssonicbld
[action] [PR:18020] Fix incompatible import of scapy and skip when no…
6156d42 
… lldp neigh in test_srv6_dataplane.py (sonic-net#199)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary: Previously I changed the import of scapy from ptf.packet to direct import, that broke the scapy header classes reference in the TestSRv6Base. Besides, when there is no LLDP neighbors, we should directly skip the test script.
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [ ] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [x] 202412

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@daall
[202012][submodule] Update sonic-linux-kernel submodule (sonic-net#7013)
5263478 
- Unset CONFIG_THERMAL_STATISTICS to prevent kernel crash (sonic-net#199)
- [dni_dps460] Add attributes to retrieve PMBus status command codes (sonic-net#197)
- [mellanox]: Backport new kernel patches (sonic-net#195)
- [ci]: build amd64/armhf/arm64 for CI build (sonic-net#196)
- Fix read and write failure to ‘fan1_target’ attribute of ‘dni_dps460’ driver. (sonic-net#183)

Signed-off-by: Danny Allen <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@lguohan
[submodule]: update sonic-platform-common (sonic-net#8178)
1d3939b 
* 063e915 2021-06-15 | [CI] sonic-config-engine now depends on SONiC YANG packages (sonic-net#198) (HEAD, origin/202012) [Joe LeVeque]
* 2d36a79 2021-07-13 | Fix Xcvrd crash due to invalid key access in type_of_media_interface, host_electrical_interface, connector_dict (sonic-net#206) [Prince George]
* 67b8a77 2021-06-18 | Fix decode error when parsing EEPROM fields (sonic-net#199) [Aravind Mani]
* 238d76b 2021-06-17 | Unifying the platform api for get_pcie_aer_stats with PcieBase (sonic-net#197) [Sujin Kang]

Signed-off-by: Guohan Lu <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule linkmgrd to the latest HEAD automatically (
1e0412a 
sonic-net#14862)

#### Why I did it
src/linkmgrd
```
* 35f7d1c - (HEAD -> 202012, origin/202012) [202012][active-standby][bsl] fix no mux probe issue sonic-net#201 (sonic-net#206) (2 weeks ago) [Jing Zhang]
* be701fb - [202012] pick codeql fixes (sonic-net#207) (2 weeks ago) [Jing Zhang]
* 0b42cec - Enable debug symbols (sonic-net#199) (3 weeks ago) [Longxiang Lyu]
```
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule linkmgrd to the latest HEAD automatically (
443561b 
sonic-net#14746)

src/linkmgrd

* aa1d55f - (HEAD -> 202205, origin/202205) [202205] cherry-pick `azure-pipeline.yml` updates (sonic-net#200) (8 hours ago) [Jing Zhang]
* 2efc130 - Enable debug symbols (sonic-net#199) (9 hours ago) [Longxiang Lyu]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@judyjoseph
Update sonic-platform-common with following commits
c95a9d1 
 1d3a810 [python coverage] fix result color bar (sonic-net#202)
 3f7b359 Add a template function that returns list of asics on module (sonic-net#185)
 abc2709 Fix decode error when parsing EEPROM fields (sonic-net#199)
 789b41e Load interval from thermal_policy.json (sonic-net#178)
 540ed1c Fix Xcvrd crash due to invalid key access in type_of_media_interface, host_electrical_interface, connector_dict (sonic-net#206)
 716caf8 Unifying the platform api for get_pcie_aer_stats with PcieBase (sonic-net#197)

Update sonic-utilities with following commit

 3f3974e [show priority-group drop counters] Add user info output when user want to check PG counters and polling are disabled (sonic-net#1678)
 16606de Global and Interface commands for IPv6 Link local address enhancements (sonic-net#1159)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-gnmi to the latest HEAD automatica…
b1daba8 
…lly (sonic-net#18256)

#### Why I did it
src/sonic-gnmi
```
* 71ae185 - (HEAD -> 202305, origin/202305) Merge pull request sonic-net#202 from sonic-net/revert-191-cherry/202305/190 (82 minutes ago) [StormLiangMS]
|\ 
| failure_prs.log e2b78b4 - (origin/revert-191-cherry/202305/190) Revert "Fix sonic string in osversion/build (sonic-net#190)" (2 hours ago) [StormLiangMS]
|/ 
* b431273 - Account for GLOBAL key in PFC_WD (sonic-net#178) (6 days ago) [Zain Budhwani]
* e1af33f - Merge pull request sonic-net#199 from abdosi/202305 (6 days ago) [StormLiangMS]
|\ 
| failure_prs.log f7e216b - Update db_client.go (6 days ago) [abdosi]
|/ 
* ec3f56d - Fix sonic string in osversion/build (sonic-net#190) (9 days ago) [Zain Budhwani]
```
#### How I did it
#### How to verify it
#### Description for the changelog
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule linkmgrd to the latest HEAD automatically (
ba5729e 
sonic-net#15576)

#### Why I did it
src/linkmgrd
```
* fc6e299 - (HEAD -> 202211, origin/202211) [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (sonic-net#184) (2 hours ago) [Jing Zhang]
* 5c6332d - Re-handle pre-init mux config notification after state machine init (sonic-net#202) (2 hours ago) [Longxiang Lyu]
* c49a5ef - [active-standby][bsl] fix no mux probe issue (sonic-net#201) (2 hours ago) [Jing Zhang]
* 2d62ef1 - Enable debug symbols (sonic-net#199) (2 hours ago) [Longxiang Lyu]
* f952b64 - [active-active] Add mux server state correction mechanism (sonic-net#191) (2 hours ago) [Longxiang Lyu]
* e6b1bfc - [ci] fix azure pipeline (sonic-net#190) (2 hours ago) [Jing Zhang]
* 615ed21 - [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (sonic-net#184) (2 hours ago) [Jing Zhang]
* 3adfc69 - [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (sonic-net#179) (2 hours ago) [Jing Zhang]
* 6fb9a0b - loose link down swithcover condition (sonic-net#178) (2 hours ago) [Jing Zhang]
* 8ffbd8a - [ci] Fix apt-get install unable locate package issue. (sonic-net#177) (2 hours ago) [Liu Shilong]
* 3dfbdd7 - [active-active] link operational down didn't trigger toggle to standby if `MuxUnknown` event arrives first.  (sonic-net#175) (2 hours ago) [Jing Zhang]
* 68c06d9 - [active-active] Toggle to standby if default route is missing (sonic-net#171) (2 hours ago) [Longxiang Lyu]
* 1592cd3 - [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (sonic-net#169) (2 hours ago) [Jing Zhang]
* a96105f - Fix the warning of unused variables (sonic-net#167) (2 hours ago) [Longxiang Lyu]
* 984ffe3 - Fix mux config when gRPC connection is lost (sonic-net#166) (2 hours ago) [Longxiang Lyu]
* 4d0b457 - [active-active] force switch when config == active && target state == active (sonic-net#164) (2 hours ago) [Jing Zhang]
* 32bd2bb - Use github code scanning instead of LGTM (sonic-net#157) (2 hours ago) [Liu Shilong]
* 6f23fe2 - [active-active] update linkmgr health label definition (sonic-net#163) (3 hours ago) [Jing Zhang]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan lguohan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maggiemsft @msftclas @lguohan