Skip to content

[dualtor] Fix loganalyzer not exist issue#18674

Merged
bingwang-ms merged 1 commit intosonic-net:masterfrom
lolyu:fix_loganalyzer_is_none
May 28, 2025
Merged

[dualtor] Fix loganalyzer not exist issue#18674
bingwang-ms merged 1 commit intosonic-net:masterfrom
lolyu:fix_loganalyzer_is_none

Conversation

@lolyu
Copy link
Collaborator

@lolyu lolyu commented May 28, 2025

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

If loganalyzer is not enabled, fixture loganalyzer will return None.

Signed-off-by: Longxiang Lyu lolv@microsoft.com

How did you do it?

If loganalyzer is None, simply return.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@lolyu
[dualtor] Fix loganalyzer not exist issue
b73a473 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

mssonicbld commented May 28, 2025

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented May 28, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@lolyu lolyu requested review from bingwang-ms, yxieca and yyynini May 28, 2025 10:38
@bingwang-ms
Copy link
Collaborator

bingwang-ms commented May 28, 2025

LGTM

@bingwang-ms bingwang-ms merged commit 5292ec9 into sonic-net:master May 28, 2025
13 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request May 29, 2025
@lolyu @mssonicbld
[dualtor] Fix loganalyzer not exist issue (sonic-net#18674)
f1f8444 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

mssonicbld commented May 29, 2025

Cherry-pick PR to 202411: #18695

@mssonicbld mssonicbld mentioned this pull request May 29, 2025
Merged
11 tasks
mssonicbld pushed a commit that referenced this pull request May 29, 2025
@lolyu @mssonicbld
[dualtor] Fix loganalyzer not exist issue (#18674)
763c1b3 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request May 30, 2025
@lolyu @mssonicbld
[dualtor] Fix loganalyzer not exist issue (sonic-net#18674)
e5a2de8 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
@mssonicbld
Copy link
Collaborator

mssonicbld commented May 30, 2025

Cherry-pick PR to 202505: #18718

@mssonicbld mssonicbld mentioned this pull request May 30, 2025
Merged
11 tasks
mssonicbld pushed a commit that referenced this pull request May 30, 2025
@lolyu @mssonicbld
[dualtor] Fix loganalyzer not exist issue (#18674)
ece58ad 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
bachalla pushed a commit to bachalla/sonic-mgmt that referenced this pull request Jun 2, 2025
@lolyu @bachalla
[dualtor] Fix loganalyzer not exist issue (sonic-net#18674)
117bc81 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request Jun 14, 2025
@r12f
[202412] Code sync sonic-net/sonic-mgmt:202411 => 202412 (sonic-net#382)
6989a9b 
Code sync sonic-net/sonic-mgmt:202411 => 202412

```
*   1f86dab (HEAD -> code-sync-202412, origin/code-sync-202412) r12f 250610:2314 - Merge remote-tracking branch 'base/202411' into code-sync-202412
|\
| * 2ba104e (base/202411) xwjiang-ms 250610:1604 - [202411] Use ceos 4.32.5M as default ceos image version (sonic-net#18878)
| * 5fa5cda Longxiang Lyu 250610:0818 - [202411][dualtor-aa] Add `dualtor_aa` support to `test_nvgre_hash` (sonic-net#18883)
| * afecbbf zitingguo-ms 250609:1334 - [Cherry-pick][ACL] Collect all upstream ports and Include service port into upstream neighbors in ACL tests (sonic-net#18847)
| * 2e4247b pragnya-arista 250609:0632 - [202411][sonic-mgmt]Fix decap/test_subnet_decap.py::test_vlan_subnet_decap (sonic-net#18778)
| * 0bfc7a8 Longxiang Lyu 250606:0943 - [dualtor-io] Fix duplication merge condition (sonic-net#18828)
| * 52d3771 Zhaohui Sun 250605:2046 - Restore configuration after vxlan module (sonic-net#18714)
| * 3d0922f Yaqiang Zhu 250605:2259 - [202411][pktgen] Skip test_pktgen in m0/mx/m1 (sonic-net#18822)
| * 3de20a6 Zhaohui Sun 250516:1325 - Add secondary subnet config for t0 topologies (sonic-net#18399)
| * bb3e0f9 Zhaohui Sun 250605:1416 - Xfail test_dir_bcast.py due to known issue on Broadcom platform (sonic-net#18787)
| * 158c562 Justin Wong 250604:2058 - Add snmp lldp state check after config_reload (sonic-net#18805)
| * e39c891 eyakubch 250605:0415 - bug: added fast reboot into reboot_type check (sonic-net#18551)
| * 8c7dd3b Cong Hou 250604:1433 - Remove the skip/xfail for the dualtor_io link failure test (sonic-net#18712)
| * 5dbc53d mssonicbld 250604:0952 - [dualtor-io] fix dualtor sniffer start slow issue (sonic-net#18758) (sonic-net#18776)
| * 105cdf6 StormLiangMS 250603:0844 - [CRM AVAILABLE] To enhance the crm tests for TD3 and Cisco devices (sonic-net#18733)
| * 4251b38 andywongarista 250601:1828 - Add restore_image fixture to test_multi_hop_upgrade_path (sonic-net#18230) (sonic-net#18532)
| * 85a55d8 Longxiang Lyu 250528:2313 - [dualtor] Fix `test_orchagent_slb` (sonic-net#18666)
| * 95a8764 Vivek Verma 250227:0656 - Fix fixture invocation order in qos_sai_base.py to prevent teardown failure. (sonic-net#17180)
| * 9a72265 Justin Wong 250514:1844 - Add PTF parameter for ceos neighbor lacp multiplier (sonic-net#18215)
| * cd1375d Longxiang Lyu 250529:1029 - [dualtor-io] Validate and recover active-active setup (sonic-net#18675)
| * 763c1b3 Longxiang Lyu 250528:2314 - [dualtor] Fix loganalyzer not exist issue (sonic-net#18674)
```
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@lolyu
[dualtor] Fix loganalyzer not exist issue (sonic-net#18674)
436c0ed 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Dec 16, 2025
@lolyu @AharonMalkin
[dualtor] Fix loganalyzer not exist issue (sonic-net#18674)
5579720 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@lolyu @gshemesh2
[dualtor] Fix loganalyzer not exist issue (sonic-net#18674)
7e7215e 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@lolyu @gshemesh2
[dualtor] Fix loganalyzer not exist issue (sonic-net#18674)
d39a73d 
Signed-off-by: Longxiang Lyu <lolv@microsoft.com>
Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bingwang-ms bingwang-ms bingwang-ms approved these changes

@yxieca yxieca Awaiting requested review from yxieca

@yyynini yyynini Awaiting requested review from yyynini

Assignees

No one assigned

Labels

Approved for 202411 branch Approved for 202505 branch Included in 202411 branch Included in 202505 branch Request for 202411 branch Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lolyu @mssonicbld @bingwang-ms @yejianquan