Skip to content

Add sensors test#181

Closed
jleveque wants to merge 1 commit intosonic-net:masterfrom
jleveque:add_sensor_test
Closed

Add sensors test#181
jleveque wants to merge 1 commit intosonic-net:masterfrom
jleveque:add_sensor_test

Conversation

@jleveque
Copy link
Contributor

@jleveque jleveque commented May 17, 2017 •
edited
Loading

  • Also some minor cleanup/refactoring

@jleveque jleveque self-assigned this May 17, 2017
@jleveque jleveque requested a review from lguohan May 17, 2017 01:17
pavel-shirshov
pavel-shirshov suggested changes May 17, 2017
View reviewed changes
ansible/roles/sonic-common/tasks/sensors_check.yml
ansible_python_interpreter: "docker exec -i {{ pmon_ps.stdout }} python"

- name: Gather sensors
sensors_facts: checks={{ sensors_checks[minigraph_hwsku] }}
Copy link
Contributor

@pavel-shirshov pavel-shirshov May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add library sensors_facts file

Copy link
Contributor Author

@jleveque jleveque May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sensors_facts.py is already committed.

Copy link
Contributor

@pavel-shirshov pavel-shirshov May 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in the repo

@lguohan
Copy link
Contributor

lguohan commented May 17, 2017

can you generate pull against https://github.com/maggiemsft/sonic-mgmt/commits/masun/try_test_sync

@jleveque
Copy link
Contributor Author

jleveque commented May 17, 2017

@lguohan: So to confirm, you would like me to merge this into Maggie's branch rather than master?

@jleveque
Copy link
Contributor Author

jleveque commented May 20, 2017

Closing this PR, as it is now included as a part of PR #183.

@jleveque jleveque closed this May 20, 2017
@jleveque jleveque deleted the add_sensor_test branch May 20, 2017 01:15
nhe-NV pushed a commit to nhe-NV/sonic-mgmt that referenced this pull request May 12, 2025
@prgeor
[API transceiver_info] update xcvr info keys (sonic-net#181)
03ad485 
<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit
easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should
reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary: 
Update xcvr info keys based on PR
Azure/sonic-platform-common.msft#69.
The change is not related to SFP cable.

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [x] Test case(new/improvement)


### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405

### Approach
#### What is the motivation for this PR?
Allign the test with latest changes


#### How did you verify/test it?
Executed test test_get_transceiver_info on setup with different cable.
auspham pushed a commit to auspham/sonic-mgmt that referenced this pull request Jun 27, 2025
@az-pz
[202503] Fix txvr tests after diagnostic table restructuring (sonic-n…
7321961 
…et#422)

The changes to the sonic-mgmt testcases are required due to the below
changes:
sonic-net/sonic-platform-common#556
sonic-net/sonic-platform-daemons#604
sonic-net/sonic-utilities#3844

This PR also reverts the changes made by sonic-net#181 .
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@stepanblyschak @qiluo-msft @lguohan
[snmpagent] update submodule (sonic-net#6169)
80c1926 
Includes below sonic-snmpagent commits
```
dfde06e 2021-01-13 | Revert "[rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (sonic-net#169)" (sonic-net#191) [Stepan Blyshchak]
45edd7e 2021-01-04 | [snmpagent] Fix hardcoded qsfp lane count by reading sensor status from DB (sonic-net#184) [Junchao-Mellanox]
3b72a6f 2021-01-02 | Fix: handle empty LOC_CHASSIS_TABLE (sonic-net#190) [Qi Luo]
4aad821 2020-12-29 | [sysName]: Implement sysName OID (sonic-net#185) [SuvarnaMeenakshi]
8efb4bb 2020-12-29 | [rfc1213] fix counter value type (sonic-net#189) [Stepan Blyshchak]
025483a 2020-12-23 | [RouteUpdater]: Fix multi_asic mock function implementation and multi_asic variable name (sonic-net#186) [SuvarnaMeenakshi]
381ae47 2020-12-10 | [mibs] b'VLAN_TABLE:' -> 'VLAN_TABLE' (sonic-net#181) [Stepan Blyshchak]
e54036c 2020-12-09 | [rfc1213] Interface MIB add l3 vlan interfaces & aggregate rif counters (sonic-net#169) [Stepan Blyshchak]
fd1eae7 2020-11-24 | Set swsscommon logging level (sonic-net#178) [Qi Luo]
706d504 2020-11-23 | Improve MockRedis _encode(): so it will work on all types of value (sonic-net#179) [Qi Luo]
64c93a1 2020-11-16 | [RFC4292][Namespace]: Fix implementation of RouteUpdater for multi-asic platform (sonic-net#176) [SuvarnaMeenakshi]
b8f19ee 2020-11-12 | [sonic-snmpagent] SONiC physical entity mib extension (sonic-net#168) [Junchao-Mellanox]
6b94ec3 2020-11-05 | Replace swsssdk.SonicV2Connector with swsscommon.SonicV2Connector (SWIG wrapper of C++ implementation) in production code (sonic-net#162) [Qi Luo]
```

Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Co-authored-by: Qi Luo <qiluo-msft@users.noreply.github.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@vdahiya12 @yxieca
[sonic-platform-common] submodule update (sonic-net#7253)
ca4deb8 
872f0a3 [Y-Cable] refactor get_firmware_version to comply with all vendors (sonic-net#182)
cc162d6 [sonic_y_cable]: Decorate all method for mux simulator (sonic-net#181)
fa02416 Change import order in Ycable helper and EEPROM read bytearray change in SFP plugin (sonic-net#177)
0b60982 [thermal_base] Add setter functions for critical thresholds (sonic-net#180)
10dc16f [y_cable] add support for enable/disable autoswitch feature on Y cable (sonic-net#176)
c6c81a8 [fan_drawer_base.py] Fix FanDrawer get_status_led interface (sonic-net#175)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-telemetry to the latest HEAD autom…
f2f0539 
…atically (sonic-net#17786)

src/sonic-telemetry

* 371073d - (HEAD -> 202205, origin/202205) Merge pull request sonic-net#181 from sonic-net/202205_dialout (7 days ago) [Feng-msft]
* 72c3ae4 - (origin/202205_dialout) Manual cherrypick dialout build flag PR to 202205. (11 days ago) [Feng Pan]
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@mssonicbld
[submodule] Update submodule sonic-restapi to the latest HEAD automat…
a5ce95b 
…ically (#25242)

#### Why I did it
src/sonic-restapi
```
* 66d1605 - (HEAD -> 202505, origin/202505) [Pfx_len] Extend prefix length for routes and advertisement (sonic-net#181) (9 days ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lguohan lguohan Awaiting requested review from lguohan

1 more reviewer

@pavel-shirshov pavel-shirshov pavel-shirshov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jleveque jleveque

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jleveque @lguohan @pavel-shirshov @msftclas