[fib_test]: Prevent overlap of source and destination ports.#164
Merged
stcheng merged 1 commit intosonic-net:masterfrom Apr 12, 2017
Merged
[fib_test]: Prevent overlap of source and destination ports.#164stcheng merged 1 commit intosonic-net:masterfrom
stcheng merged 1 commit intosonic-net:masterfrom
Conversation
Due to overlap of source and destination port according to ECMP rules some packets were send to the same port on which they were received. Routing rules doesn't allow packets to be received from the port they were sent to so such packets were dropped.
|
@stcheng looks like the original code also had different port as src and dst while the new version of this test uses the same one. Looks like this is more robust solution unless you don't agree with that approach. |
lguohan
approved these changes
Apr 12, 2017
stcheng
approved these changes
Apr 12, 2017
lguohan
pushed a commit
that referenced
this pull request
Aug 3, 2017
Due to overlap of source and destination port according to ECMP rules some packets were send to the same port on which they were received. Routing rules doesn't allow packets to be received from the port they were sent to so such packets were dropped.
zhixzhu
pushed a commit
to zhixzhu/sonic-mgmt
that referenced
this pull request
May 1, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Handle errored DUT shell result in sanity checks. Summary: Fixes # (issue) Microsoft ADO 31652009 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? There will be a chance that the DUT shell command returning error response. If we don't add `module_ignore_errors=True`, such error response could make a check exit early with exception, which leads to unexpected sanity check behavior. Hence, we want to handle the situation when there is an error with the shell command.  #### How did you do it? #### How did you verify/test it? I ran a sanity check with a DUT shell command that returns an error response and can confirm the sanity check will not raise an exception anymore.  #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
This PR updates the following commits c6b642b [ci]: download from sonic-buildimage.vs artifact (sonic-net#168) e76ecc6 [sonic_y_cable] add support for retrieving firmware info for Y cable, internal and nic temperature and voltage (sonic-net#162) f9cf8c9 [GitHub] Add pull request template (sonic-net#167) c31636e [ci] Call pip2/3 using sudo (sonic-net#166) 5521f67 [ci] Test and build packages using Azure Pipelines (sonic-net#164) faca35c [ci]: Set up CI with Azure Pipelines Signed-off-by: vaibhav-dahiya <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…e submodule head (sonic-net#13606) swss: * 79223f0 2023-01-25 | [bfdorch] add local discriminator to state DB (sonic-net#2629) (HEAD -> 202205) [Baorong Liu] * 64940d4 2023-01-25 | Vxlan tunnel endpoint custom monitoring APPL DB table. (sonic-net#2589) [siqbal1986] * 0930529 2023-02-02 | Merge pull request sonic-net#2650 from devpatha/202205 (github/202205) [Kevin Wang] * 8f5884f 2023-02-01 | Remove counters for Mux ACL [Devesh P Pathak] utilities: * 557adfcc 2023-02-01 | show logging CLI support for logs stored in tmpfs (sonic-net#2641) (HEAD -> 202205) [mihirpat1] * 28d7bb26 2023-01-31 | Making 'show feature autorestart' more resilient to missing auto_restart config in CONFIG_DB (sonic-net#2592) [kartik-arista] * e0b3b4ab 2023-01-06 | [masic] 'show interfaces counters' reminds to use '-d all' option to check for internal links (sonic-net#2466) [wenyiz2021] * 5613277d 2023-01-27 | [show_bfd] add local discriminator in show bfd command (sonic-net#2625) [Baorong Liu] linkmgrd: * 8803690 2023-01-31 | [active-active] force switch when config == active && target state == active (sonic-net#164) (HEAD -> 202205) [Jing Zhang] sairedis: * ad3d4d6 2023-02-01 | [sai_failure_dump]Invoking dump during SAI failure (sonic-net#1198) (HEAD -> 202205) [Sudharsan Dhamal Gopalarathnam] platform-common: * 6fd8992 2023-01-30 | Add missing sys imports (sonic-net#343) (HEAD -> 202205) [spilkey-cisco] * 1fbc864 2023-01-25 | Change get_tx_bias return type to list (sonic-net#342) [mihirpat1] Signed-off-by: Ying Xie <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
a4f39ac580cdc4bc816b829adefa56626332b6d6 (HEAD -> 201911, origin/201911) [RouteUpdater]: Fix multi_asic mock function implementation and multi_asic variable name (sonic-net#186) 583265e521df440549d29fd2ef403c09f9e907ab [LLDP]: Update init_db to load global database config (sonic-net#166) 005cf2e14005220699b57b0165b00914d009a852 Fix: correctly handle that lldp_loc_man_addr contains only IPv6 address without IPv4 address (sonic-net#164) Signed-off-by: Abhishek Dosi <[email protected]>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
sonic-net#15576) #### Why I did it src/linkmgrd ``` * fc6e299 - (HEAD -> 202211, origin/202211) [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (sonic-net#184) (2 hours ago) [Jing Zhang] * 5c6332d - Re-handle pre-init mux config notification after state machine init (sonic-net#202) (2 hours ago) [Longxiang Lyu] * c49a5ef - [active-standby][bsl] fix no mux probe issue (sonic-net#201) (2 hours ago) [Jing Zhang] * 2d62ef1 - Enable debug symbols (sonic-net#199) (2 hours ago) [Longxiang Lyu] * f952b64 - [active-active] Add mux server state correction mechanism (sonic-net#191) (2 hours ago) [Longxiang Lyu] * e6b1bfc - [ci] fix azure pipeline (sonic-net#190) (2 hours ago) [Jing Zhang] * 615ed21 - [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (sonic-net#184) (2 hours ago) [Jing Zhang] * 3adfc69 - [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (sonic-net#179) (2 hours ago) [Jing Zhang] * 6fb9a0b - loose link down swithcover condition (sonic-net#178) (2 hours ago) [Jing Zhang] * 8ffbd8a - [ci] Fix apt-get install unable locate package issue. (sonic-net#177) (2 hours ago) [Liu Shilong] * 3dfbdd7 - [active-active] link operational down didn't trigger toggle to standby if `MuxUnknown` event arrives first. (sonic-net#175) (2 hours ago) [Jing Zhang] * 68c06d9 - [active-active] Toggle to standby if default route is missing (sonic-net#171) (2 hours ago) [Longxiang Lyu] * 1592cd3 - [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (sonic-net#169) (2 hours ago) [Jing Zhang] * a96105f - Fix the warning of unused variables (sonic-net#167) (2 hours ago) [Longxiang Lyu] * 984ffe3 - Fix mux config when gRPC connection is lost (sonic-net#166) (2 hours ago) [Longxiang Lyu] * 4d0b457 - [active-active] force switch when config == active && target state == active (sonic-net#164) (2 hours ago) [Jing Zhang] * 32bd2bb - Use github code scanning instead of LGTM (sonic-net#157) (2 hours ago) [Liu Shilong] * 6f23fe2 - [active-active] update linkmgr health label definition (sonic-net#163) (3 hours ago) [Jing Zhang] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to overlap of source and destination port according to ECMP rules
some packets were send to the same port on which they were received.
Routing rules doesn't allow packets to be received from the port they
were sent to so such packets were dropped which caused test failure.