Merge dev into refactor#13278
Merged
TobiGr merged 77 commits intoTeamNewPipe:refactorfrom Feb 22, 2026
Merged
Conversation
It no longer really builds any view and used only for stroing click gesture callbacks. In the same way lik local/LocalItemBuilder does Last usage of build functions: 2e9a860
Because otherwise they will be caught by underlying view and "click through" will happen. Workaround for TeamNewPipe#5600
…ceptions
Replace Illegal{State,Argument} exceptions with more idiomatic kotlin code
…factor TabsJsonHelper refactor
Remove dead code from info_list/InfoItemBuilder
If performs action when value is true but check when false Fix for d6be966
Correct inverted check (error fix on dev branch)
…archFields It doesn't need to return mutable list
Kotlin misc idiomatic refactor
- Use early return in case of nulls - Use better variable names - Remove non-required newlines, imports and add missing ones Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Convert a bunch of files to kotlin
Duration data in the player code incosnistently typed. Half code uses ints and half uses longs. Recieve longs in this function to allow both halfs of player code just use the function without nasty long to int downcasting warnings/errors in code
Co-authored-by: Aayush Gupta <aayushgupta219@protonmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Based on changes from refactor Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
VideoDetailFragment: hide relatedItemsLayout in tablet mode after fullscreen
Accomodate extractor changes (EnumSet for service media capabilities)
Remove redundant comment about hiding controls on double tap
…-tap-to-resume [fix] Hide controls when resuming playback via double tap
Migrate from Picasso to Coil
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Update dependencies and Gradle to latest stable releases
Member
Author
|
Part of #13213 hasn't been ported (NavigationHelper changes) as it seems to have been migrated to compose |
TobiGr
approved these changes
Feb 22, 2026
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
I tested the changes briefly and did not find any obvious bugs.
ShareASmile
added
codequality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
refactorbranchDescription of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence