Migrate from Picasso to Coil#13272
Conversation
Based on changes from refactor branch for code parity Signed-off-by: Aayush Gupta <[email protected]>
Based on changes from refactor Signed-off-by: Aayush Gupta <[email protected]>
Signed-off-by: Aayush Gupta <[email protected]>
|
We should do a merge from dev to refactor after this. Then I will do a new PR to add SPDX copyright to files touched by this PR to avoid conflicts and simplify things. |
TobiGr
left a comment
There was a problem hiding this comment.
LGTM. I tested the different image quality options with different network settings and everything seems to be working fine. Did you face any conflicts or difficulties while porting the changes back? If not, I'd feel free to merge. I don't think we need to review the code again. I'd just have a closer look if you needed to make some modifications to the originial version.
Not much. Most conflicts were due to migration split into different PRs and lint changes that were done recently. |
What is it?
refactorbranchDescription of the changes in your PR
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence