Remove dead code from info_list/InfoItemBuilder#13137
Merged
theimpulson merged 1 commit intoTeamNewPipe:devfrom Feb 8, 2026
Merged
Remove dead code from info_list/InfoItemBuilder#13137theimpulson merged 1 commit intoTeamNewPipe:devfrom
theimpulson merged 1 commit intoTeamNewPipe:devfrom
Conversation
It no longer really builds any view and used only for stroing click gesture callbacks. In the same way lik local/LocalItemBuilder does Last usage of build functions: 2e9a860
ShareASmile
added
the
codequality
Contributor
|
I'd suggest to rename it to something more fitting as it isn't a builder anymore. |
Contributor
Author
I also though about it but as I said we have one more "Builder" which holds only listeners too. And the listeners are static IIRC so these two "builders" probably could be eliminated at all... So I decided to leave it as builders so they are giving you more pain when you look at them so easier to spot... Very weird but... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
info_list/InfoItemBuilderIt no longer really builds any view and used only for storing click gesture callbacks. In the same way like
local/LocalItemBuilderdoesLast usage of build functions: 2e9a860
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence