Skip to content

Replace Illegal{State,Argument} exceptions with more idiomatic kotlin code#13028

Merged
theimpulson merged 1 commit intoTeamNewPipe:devfrom
dustdfg:idiomatic_kotlin_exceptions
Feb 8, 2026
Merged

Replace Illegal{State,Argument} exceptions with more idiomatic kotlin code#13028
theimpulson merged 1 commit intoTeamNewPipe:devfrom
dustdfg:idiomatic_kotlin_exceptions

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Jan 9, 2026

What is it?

  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Replace Illegal{State,Argument} exceptions with more idiomatic kotlin code

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Jan 9, 2026
Copy link
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@theimpulson theimpulson force-pushed the idiomatic_kotlin_exceptions branch from f89f8b7 to 7eac212 Compare February 8, 2026 10:07
@theimpulson theimpulson force-pushed the idiomatic_kotlin_exceptions branch from 7eac212 to d6be966 Compare February 8, 2026 13:59
@theimpulson theimpulson merged commit 5d79342 into TeamNewPipe:dev Feb 8, 2026
5 checks passed
@dustdfg dustdfg deleted the idiomatic_kotlin_exceptions branch February 8, 2026 15:40
@TobiGr TobiGr mentioned this pull request Feb 28, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants