[fix] Hide controls when resuming playback via double tap#13030
Merged
TobiGr merged 2 commits intoTeamNewPipe:devfrom Feb 21, 2026
Merged
[fix] Hide controls when resuming playback via double tap#13030TobiGr merged 2 commits intoTeamNewPipe:devfrom
TobiGr merged 2 commits intoTeamNewPipe:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where player controls remain visible after resuming playback via double-tap in the middle of the screen. The fix adds logic to hide the controls immediately when playback resumes.
Key Changes
- Added conditional logic to hide player controls when transitioning to playing state after a double-tap gesture
- The controls are hidden with no delay (0, 0) when the player starts playing
app/src/main/java/org/schabi/newpipe/player/gesture/BasePlayerGestureListener.kt
Outdated
Show resolved
Hide resolved
TobiGr
added
bug
Contributor
|
I pulled locally and tested. Confirm this PR solves the bug |
dustdfg
reviewed
Feb 18, 2026
| startMultiDoubleTap(event) | ||
| } else if (portion === DisplayPortion.MIDDLE) { | ||
| player.playPause() | ||
| if (player.isPlaying()) { |
Contributor
There was a problem hiding this comment.
Please use kotlins property access syntax
Remove redundant comment about hiding controls on double tap
TobiGr
force-pushed
the
fix/6815-double-tap-to-resume
branch
from
0b15da5 to
423f95a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove redundant comment about hiding controls on double tap
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Screenrecorder-2026-01-10-01-20-11-472.mp4
Screenrecorder-2026-01-10-01-26-30-932.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence