Skip to content

Correct inverted check (error fix on dev branch)#13219

Merged
Stypox merged 1 commit intoTeamNewPipe:devfrom
dustdfg:kotlin_check_is_not_if
Feb 9, 2026
Merged

Correct inverted check (error fix on dev branch)#13219
Stypox merged 1 commit intoTeamNewPipe:devfrom
dustdfg:kotlin_check_is_not_if

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Feb 9, 2026

What is it?

  • Bugfix (user facing)
  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Just correct stupid "error" introduced in dev.
  • Due to inverted logic it gives error when there is no error. Literally every time when you open any video 😅
  • If performs action when value is true but check when false Fix for d6be966

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

If performs action when value is true but check when false
Fix for d6be966
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Feb 9, 2026
@dustdfg
Copy link
Contributor Author

dustdfg commented Feb 9, 2026

Maybe even better revert check part? 🤔

@Stypox
Copy link
Member

Stypox commented Feb 9, 2026

Maybe even better revert check part? 🤔

Nah it's fine. Thanks for noticing :-)

@Stypox Stypox merged commit 6214ae3 into TeamNewPipe:dev Feb 9, 2026
1 check passed
@TobiGr TobiGr mentioned this pull request Feb 28, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants