Skip to content

Handling Comment Replies fragments#13213

Merged
TobiGr merged 1 commit intoTeamNewPipe:devfrom
aivelon:handle-comment-replies-screens
Feb 19, 2026
Merged

Handling Comment Replies fragments#13213
TobiGr merged 1 commit intoTeamNewPipe:devfrom
aivelon:handle-comment-replies-screens

Conversation

@aivelon
Copy link
Contributor

@aivelon aivelon commented Feb 8, 2026

What is it?

  • Bugfix (user facing)
  • Feature (user facing) ⚠️ Your PR must target the refactor branch
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Remove existing comment replies screens before adding new one. This will avoid infinite stacking of comment replies views.

Before/After Screenshots/Screen Record

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Feb 8, 2026
@aivelon aivelon marked this pull request as ready for review February 8, 2026 09:48
@hollownights
Copy link

Gonna leave my last comment on #13162 to be discussed here too, in case any reviewer misses it.

I have been reconsidering part of my understanding of this problem, though. To use yours PR description, I think that to...

Remove existing comment replies screens before adding new one.

... is absolutely great and solve the annoying problem with infinite back-pages, but I'm not sure that to...

Also close all comment replies screens when the video details screen is closed.

... is ideal anymore. Reason being that closing the replies' page that the user has on screen may be a little disconcerting, cause, sure, the user may not want to watch/listen to the video anymore, but they may still be reading the comments on screen.

@TobiGr TobiGr added bug Issue is related to a bug comments Anything to do with comments and comment replies under videos/audios GUI Issue is related to the graphical user interface labels Feb 13, 2026
@aivelon
Copy link
Contributor Author

aivelon commented Feb 17, 2026

please review.....changes have been made after discussion in the linked issue.

Copy link
Contributor

@TobiGr TobiGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@aivelon aivelon force-pushed the handle-comment-replies-screens branch from 5c70df3 to 9f8055f Compare February 19, 2026 06:42
@TobiGr TobiGr merged commit 51c9ed7 into TeamNewPipe:dev Feb 19, 2026
5 checks passed
@theimpulson theimpulson mentioned this pull request Feb 22, 2026
7 tasks
@TobiGr TobiGr mentioned this pull request Feb 28, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue is related to a bug comments Anything to do with comments and comment replies under videos/audios GUI Issue is related to the graphical user interface size/small PRs with less than 50 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NewPipe shouldn't keep comments' replies in page history if the video to which they belong is not open anymore

3 participants