feat(t8s-cluster/management-cluster): ignore local storage for autoscaler

[cwrau]

They can be removed indiscriminately

Summary by CodeRabbit

• Chores
  • Updated cluster autoscaler configuration to consider nodes with local storage when making scaling decisions, improving resource optimization during cluster scaling operations.

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the configuration of the cluster autoscaler for the t8s-cluster management cluster. The change ensures that nodes with local storage are properly evaluated for scaling down, preventing them from being inadvertently excluded from the autoscaling process and allowing for more efficient resource management.

Highlights

• Autoscaler Configuration: The skip-nodes-with-local-storage argument has been explicitly set to false within the cluster autoscaler's extraArgs. This configuration ensures that nodes equipped with local storage are not ignored during autoscaling operations, allowing them to be considered for scaling down.

Changelog

• charts/t8s-cluster/templates/management-cluster/autoscaler.yaml
  • Added the skip-nodes-with-local-storage: false argument to the autoscaler's extraArgs section. This explicitly configures the autoscaler to not skip nodes that have local storage when making scaling decisions.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

📝 Walkthrough

Walkthrough

A single configuration parameter is added to the cluster autoscaler Helm template, setting skip-nodes-with-local-storage to false. This prevents the autoscaler from skipping nodes that have local storage attached.

Changes

Cohort / File(s)	Summary
Cluster Autoscaler Configuration charts/t8s-cluster/templates/management-cluster/autoscaler.yaml	Added skip-nodes-with-local-storage: false extraArg to cluster autoscaler configuration, enabling autoscaling for nodes with local storage.

Possibly related PRs

• feat(t8s-cluster/management-cluster): add cluster-autoscaler deployment #1756 — Modifies the same autoscaler HelmRelease template with cluster-autoscaler extraArgs configuration changes.
• fix(t8s-cluster/autoscaler): these names are inside the workload cluster #1877 — Updates autoscaler.yaml extraArgs, removing other configuration parameters from the same autoscaler setup.

Suggested labels

t8s-cluster

Suggested reviewers

• tasches
• marvinWolff
• teutonet-bot

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A single flag hops into place,
Local storage nodes find grace,
The autoscaler learns to care,
For data on nodes everywhere! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding skip-nodes-with-local-storage: false to the autoscaler configuration, allowing it to ignore local storage constraints.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/t8s-cluster/autoscaler-ignore-local-storage

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request configures the cluster-autoscaler to allow scaling down nodes that have pods with local storage by setting skip-nodes-with-local-storage to false. While this may be the intended behavior for a specific use case, hardcoding this value in a reusable chart is risky as it can lead to unexpected data loss for other users. My review suggests making this setting configurable via values.yaml and defaulting to the safer option (true) to prevent accidents.

[Copilot]

Pull request overview

This PR configures the cluster autoscaler to allow removal of nodes with local storage by setting skip-nodes-with-local-storage: false. This changes the autoscaler's default behavior to permit aggressive scale-down operations even when pods have emptyDir or hostPath volumes.

Changes:

• Added skip-nodes-with-local-storage: false configuration to the cluster autoscaler extraArgs

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.