fix(t8s-cluster/management-cluster): remove hardcoded field

[cwrau]

This is not used anymore anyways

Summary by CodeRabbit

• Chores
  • Removed Bastion configuration from cluster specification.

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the cluster.yaml configuration by eliminating an obsolete and unused bastion field. This change simplifies the template, removing unnecessary code and improving maintainability without impacting functionality.

Highlights

• Configuration Cleanup: Removed a hardcoded bastion field from the cluster.yaml template, as it is no longer used.

Changelog

• charts/t8s-cluster/templates/management-cluster/cluster.yaml
  • Removed the hardcoded bastion: enabled: false block.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

Removes a hardcoded spec.bastion.enabled: false block from the management-cluster TeutonetesCluster manifest, aligning the rendered CR with the chart’s existing bastion configuration that is already expressed via .Values.bastion.* in the OpenStackClusterTemplate spec.

Changes:

• Delete the hardcoded spec.bastion section from templates/management-cluster/cluster.yaml.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

📝 Walkthrough

Walkthrough

Removed the Bastion configuration block from the management cluster template YAML, disabling the Bastion feature at the manifest level. This reduces the cluster specification by two lines without affecting other configuration parameters or control flow logic.

Changes

Cohort / File(s)	Summary
Bastion Configuration Removal charts/t8s-cluster/templates/management-cluster/cluster.yaml	Removed the bastion: enabled: false configuration block from the cluster spec.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

• marvinWolff
• tasches
• teutonet-bot

Poem

🐰 A bastion stood tall in our YAML so dear,
Two lines removed, now it's quite clear—
No need for the fortress, the cluster runs free,
Simpler and lighter for all we can be! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(t8s-cluster/management-cluster): remove hardcoded field' directly describes the main change—removal of a hardcoded Bastion configuration field from the cluster manifest.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/t8s-cluster/remove-hardcoded-field

---

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request removes a hardcoded bastion configuration from the TeutonetesCluster template. While the PR description suggests this field is no longer used, the chart's values files (values.yaml, ci/bastion-values.yaml) contain configuration for it, indicating it's an intended feature. Removing the block entirely would prevent bastion hosts from being enabled, which could break CI jobs. My review suggests replacing the hardcoded block with a templated one that uses the chart's values. If the bastion feature is indeed deprecated, the related configuration should be removed from all values files to avoid confusion.

I am having trouble creating individual review comments. Click here to see my feedback.

charts/t8s-cluster/templates/management-cluster/cluster.yaml (48-49)

Removing the bastion block entirely prevents it from being configured. The chart's values (values.yaml, ci/bastion-values.yaml) indicate that this is an intended feature that should be configurable. For instance, CI seems to rely on enabling the bastion host, which this change would break.

Instead of removing the block, it should be templated to use the values from .Values.bastion.

  {{- with .Values.bastion }}
  bastion:
    {{- toYaml . | nindent 4 }}
  {{- end }}