fix(t8s-cluster/management-cluster): adjust test helmRepositories

[cwrau]

Otherwise the sources aren't found for artifacthub scanning

Summary by CodeRabbit

• Chores
  • Updated Helm repository namespace configuration in cluster templates to ensure repositories are consistently resolved in the flux-system namespace.

[gemini-code-assist]

Summary of Changes

Hello @cwrau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue preventing artifacthub from correctly scanning and resolving chart sources. It achieves this by introducing a conditional override for the Release.Namespace within the helmRepositories.yaml template. Specifically, when the release is in the "default" namespace, the Release object is deep-copied, its namespace is set to "flux-system", and this modified object is then used to include common Helm repositories. This ensures that artifacthub operates with the correct namespace context, allowing it to successfully find and process repository sources.

Highlights

• Namespace Adjustment for Helm Repositories: The helmRepositories.yaml template now explicitly sets the Release.Namespace to "flux-system" before including common Helm repositories. This modification is conditional, only applying when the original release namespace is "default".
• Artifacthub Scanning Fix: This change is implemented to resolve an issue where artifacthub scanning was unable to locate chart sources, ensuring proper resolution and scanning of repositories.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[coderabbitai]

📝 Walkthrough

Walkthrough

This change modifies the Helm template context passed to the common.helm.repositories include in the t8s-cluster management-cluster repositories template. Instead of passing the current context directly, the modified version creates a deep copy of the Release object, overrides its Namespace field to "flux-system", and passes a structured context containing Values, Chart, and the modified Release to the include.

Changes

Cohort / File(s)	Summary
Helm Repository Template Context charts/t8s-cluster/templates/management-cluster/repositories/helmRepositories.yaml	Modified context passed to common.helm.repositories include by deep-copying Release, forcing Namespace to "flux-system", and restructuring the context object to include Values, Chart, and modified Release.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• chore(t8s-cluster/flux): use centralised HelmRepositories instead of per-instance #1758: Implements the same flux-system namespace forcing for Helm repository lookups using a different approach with HelmRepository/HelmRelease references
• feat(t8s-cluster/artifacthub): use centralised helmRepositories template #1846: Directly modifies the same template file by replacing per-repo generation with the common.helm.repositories include that this PR further refines
• feat(common): centralise helmRepositories templating #1844: Adds/centralizes the common.helm.repositories template that this PR's context modification depends on

Suggested labels

t8s-cluster

Suggested reviewers

• tasches
• marvinWolff
• teutonet-bot

Poem

🐰 A namespace flows like clover through the flux,
Deep-copied releases, no fuss or mucks,
To "flux-system" we redirect the tide,
Where Helm repositories safely reside! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(t8s-cluster/management-cluster): adjust test helmRepositories' accurately describes the main change - adjusting Helm repositories configuration in the management-cluster template by forcing the namespace to flux-system.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/t8s-cluster/adjust-helmrepositories

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Code Review

This pull request adjusts the context passed to the common.helm.repositories template to ensure Helm repository sources are correctly identified during ArtifactHub scanning. The change modifies the release namespace to flux-system when the current namespace is default.

While the intent is correct, the implementation creates a new context that only includes Values, Chart, and Release, potentially omitting other important objects from the original context like Capabilities. I've suggested a more robust approach that preserves the full context while only modifying the release namespace, preventing potential issues with templates that rely on the complete context.

[Copilot]

Pull request overview

This PR adjusts how Helm repositories are rendered for the management cluster when the release is in the default namespace, so that Artifact Hub can correctly discover and scan the associated sources.

Changes:

• For charts/t8s-cluster/templates/management-cluster/repositories/helmRepositories.yaml, when .Release.Namespace is default, a deep copy of .Release is created with the namespace overridden to flux-system.
• The common.helm.repositories helper is now invoked with an explicit context containing Values, Chart, and the modified Release, so that generated HelmRepository/GitRepository objects are namespaced to flux-system for Artifact Hub image resolution.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In
`@charts/t8s-cluster/templates/management-cluster/repositories/helmRepositories.yaml`:
- Around line 3-4: The code tries to use sprig's set on the Helm .Release struct
($release := mustDeepCopy .Release; set $release "Namespace" "flux-system")
which fails because set works only on maps; instead create a map/dict for
$release and populate the fields you need (e.g., Namespace and any other
.Release fields you use) by calling dict and copying values from .Release (for
example: $release := dict "Name" .Release.Name "Namespace" "flux-system" ...),
or construct a map by converting .Release fields explicitly before using
$release elsewhere.