feat(t8s-cluster/management-cluster): add quotas fied to cluster#1998
feat(t8s-cluster/management-cluster): add quotas fied to cluster#1998
Conversation
cwrau
requested review from
marvinWolff,
tasches and
teutonet-bot
as code owners
Summary of ChangesHello @cwrau, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThis pull request adds quotas configuration support to the t8s-cluster Helm chart by introducing a quotas values file, a quotas entry in default values, a schema definition for quotas.floatingIPs, and conditional rendering of quotas in the management cluster template. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring quotas in the t8s-cluster chart, specifically for floating IPs. The implementation includes schema validation and a test configuration file.
Changes:
- Added a new
quotasfield to the cluster configuration - Defined schema validation for the quotas object with
floatingIPsproperty - Created a CI test file to validate the quotas configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/t8s-cluster/values.yaml | Adds empty quotas object as default configuration |
| charts/t8s-cluster/values.schema.json | Defines JSON schema for quotas with floatingIPs integer property |
| charts/t8s-cluster/templates/management-cluster/cluster.yaml | Integrates quotas field into cluster template |
| charts/t8s-cluster/ci/quotas-values.yaml | Provides test configuration with floatingIPs set to -1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a quotas field to the cluster configuration, allowing resource limits like floatingIPs to be set. The implementation across the Helm templates, values.yaml, and schema files is sound. I have one suggestion to enhance the JSON schema for better validation and clarity. Additionally, there's a small typo in the pull request title ('fied' should be 'field').
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
charts/t8s-cluster/values.schema.json (1)
166-174: Consider adding adescriptionfor thequotasobject and itsfloatingIPsproperty.A brief description (e.g., explaining that
-1means unlimited) would help users configuring these values. This is a minor readability improvement — other properties in the schema follow a similar pattern of omitting descriptions, so this is consistent as-is.
cwrau
force-pushed
the
feat/t8s-cluster/add-quotas-field
branch
from
d965929 to
03616e5
Compare
🤖 I have created a release *beep* *boop* --- ## [9.6.0](t8s-cluster-v9.5.2...t8s-cluster-v9.6.0) (2026-02-25) ### Features * **t8s-cluster/management-cluster:** add `compute-plane` role label to nodes ([#1953](#1953)) ([f5897e3](f5897e3)) * **t8s-cluster/management-cluster:** add quotas fied to cluster ([#1998](#1998)) ([3123514](3123514)) * **t8s-cluster/management-cluster:** ignore local storage for autoscaler ([#1973](#1973)) ([d4abff8](d4abff8)) ### Bug Fixes * **t8s-cluster/management-cluster:** add missing securityGroupRule for cilium hubble ([#1971](#1971)) ([f36f231](f36f231)) * **t8s-cluster/management-cluster:** adjust test helmRepositories ([#1964](#1964)) ([66be444](66be444)) * **t8s-cluster/management-cluster:** remove hardcoded field ([#1984](#1984)) ([227af97](227af97)) * **t8s-cluster/workload-cluster:** add missing tolerations ([#1933](#1933)) ([8718c0d](8718c0d)) * **t8s-cluster/workload-cluster:** correctly set extraArgs value ([#2003](#2003)) ([6e558f0](6e558f0)) * **t8s-cluster/workload-cluster:** migrate extraArgs type to string ([#1985](#1985)) ([79d6df5](79d6df5)) ### Miscellaneous Chores * **t8s-cluster/dependencies:** update common docker tag to v1.8.0 ([#1940](#1940)) ([cdf387f](cdf387f)) * **t8s-cluster/dependencies:** update helm release cilium to v1.19.0 ([#1969](#1969)) ([e95a9a5](e95a9a5)) * **t8s-cluster/dependencies:** update helm release cluster-autoscaler to v9.55.0 ([#1963](#1963)) ([659a529](659a529)) * **t8s-cluster/dependencies:** update helm release openstack-cinder-csi to v2.35.0 ([#1970](#1970)) ([741d5b2](741d5b2)) * **t8s-cluster/dependencies:** update helm release openstack-cloud-controller-manager to v2.35.0 ([#1941](#1941)) ([a580142](a580142)) * **t8s-cluster/dependencies:** update registry.k8s.io/etcd docker tag to v3.6.8 ([#1996](#1996)) ([aa7d054](aa7d054)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Summary by CodeRabbit