fix(t8s-cluster/autoscaler): these names are inside the workload cluster

[cwrau]

There is no .Release.Namespace namespace in the workload cluster...
This just looked like it was necessary for the management clusters
themselves 🤣

Summary by CodeRabbit

• Chores
  • Simplified autoscaler configuration by removing three explicit namespace and resource naming settings.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Three autoscaler configuration lines were removed from the Helm template: clusterAPIConfigMapsNamespace, leader-elect-resource-name, and status-config-map-name. No new functionality was introduced; existing configuration values were deleted.

Changes

Cohort / File(s)	Change Summary
Autoscaler Configuration charts/t8s-cluster/templates/management-cluster/autoscaler.yaml	Removed three configuration keys: clusterAPIConfigMapsNamespace, leader-elect-resource-name, and status-config-map-name

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

• Single file modified with straightforward line removals
• Configuration-only change with no logic alterations
• Consider reviewing impact on cluster-autoscaler behavior post-removal

Possibly related PRs

• feat(t8s-cluster/management-cluster): add cluster-autoscaler deployment #1756: Previously added the same clusterAPIConfigMapsNamespace, leader-elect-resource-name, and status-config-map-name configuration keys to this autoscaler template; this PR removes them.

Suggested labels

t8s-cluster

Suggested reviewers

• tasches
• marvinWolff
• teutonet-bot

Poem

🐰 Three config lines bid farewell today,
From the autoscaler's helm they slip away.
No more ConfigMaps namespace defined with care,
Leader and status keys vanish into air.
Simpler times ahead—defaults light and fair! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing namespace-related configuration lines from the autoscaler because these names belong in the workload cluster, not management cluster.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/t8s-cluster/autoscaler-names

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dc5f071 and b9287e7.

📒 Files selected for processing (1)

• charts/t8s-cluster/templates/management-cluster/autoscaler.yaml (0 hunks)

💤 Files with no reviewable changes (1)

• charts/t8s-cluster/templates/management-cluster/autoscaler.yaml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Agent

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR fixes incorrect namespace references in the cluster-autoscaler configuration for managing workload clusters. The autoscaler runs in the management cluster but manages node scaling in workload clusters via a kubeconfig. The removed parameters were incorrectly referencing .Release.Namespace for resources in the workload cluster, where that namespace doesn't exist.

• Removes clusterAPIConfigMapsNamespace which incorrectly pointed to a non-existent namespace in the workload cluster
• Removes leader-elect-resource-name and status-config-map-name extraArgs that were unnecessarily prefixed with release name

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.