[meta] do not fail bulk operations if MODE_IGNORE_ERROR - #1613
Merged
Conversation
bulk operations do not continue when SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR is set and an error occurs. Create new check that considers the mode when validating bulk operations. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Jun 17, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hi @kcudnik, if you approve of the changes can you help merge? |
prsunny
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jul 18, 2025
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED.
bobby-nexthop
pushed a commit
to bobby-nexthop/sonic-swss
that referenced
this pull request
Jul 24, 2025
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED.
mssonicbld
added a commit
to mssonicbld/sonic-swss.msft
that referenced
this pull request
Jul 31, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Check for specific SAI status codes instead of just `SAI_STATUS_NOT_EXECUTED` and respond accordingly **Why I did it** sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to `SAI_STATUS_NOT_EXECUTED`. **How I verified it** **Details if related**
prabhataravind
pushed a commit
to Azure/sonic-swss.msft
that referenced
this pull request
Jul 31, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Check for specific SAI status codes instead of just `SAI_STATUS_NOT_EXECUTED` and respond accordingly **Why I did it** sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to `SAI_STATUS_NOT_EXECUTED`. **How I verified it** **Details if related**
rlhui
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Aug 18, 2025
…ort bulk update mode (#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
Contributor
|
@Ndancejic Can you raise a PR to 202411? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 20, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
prsunny
pushed a commit
that referenced
this pull request
Dec 11, 2025
mssonicbld
added a commit
to mssonicbld/sonic-sairedis
that referenced
this pull request
Dec 11, 2025
…c-net#1613)" This commit caused failures in test_duplicate_route. This reverts commit fb5652b.
vikram-nexthop
pushed a commit
to nexthop-ai/sonic-sairedis
that referenced
this pull request
Dec 12, 2025
…c-net#1613)" (sonic-net#1676) This reverts commit fb5652b. Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" sonic-net#1676 Signed-off-by: Vikram Menon <vikram@nexthop.ai>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.
croos12
pushed a commit
to croos12/sonic-sairedis
that referenced
this pull request
Jan 14, 2026
…c-net#1613)" (sonic-net#1676) This reverts commit fb5652b. Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" sonic-net#1676
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Yael Tzur <ytzur@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: Yael Tzur <ytzur@nvidia.com>
theasianpianist
added a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 4, 2026
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED. Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED. Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
mssonicbld
added a commit
that referenced
this pull request
Feb 25, 2026
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Apr 20, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Apr 20, 2026
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
justin-wong-ce
pushed a commit
to justin-wong-ce/sonic-sairedis
that referenced
this pull request
Apr 20, 2026
…c-net#1613)" (sonic-net#1676) This reverts commit fb5652b. Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" sonic-net#1676 Signed-off-by: Justin Wong <jvwong@arista.com>
Naveen-Rampuram
pushed a commit
to Naveen-Rampuram/sonic-sairedis
that referenced
this pull request
May 22, 2026
…c-net#1613)" (sonic-net#1676) This reverts commit fb5652b. Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" sonic-net#1676
Yogapriya-cisco
pushed a commit
to prhoskot/sonic-swss
that referenced
this pull request
Jul 13, 2026
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED. Signed-off-by: Yogapriya Mohankumar <ymohanku@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bulk operations do not continue when SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR is set and an error occurs. Create new check that considers the mode when validating bulk operations.
fixes a crash in sonic-net/sonic-buildimage#21243 because route entries that are not removed in syncd by bulker are assumed to be removed in orchagent. Then when the nexthops are attempting to be removed, orchagent crashes due to OBJECT_IN_USE.