[meta] do not fail bulk operations if MODE_IGNORE_ERROR#1613
Merged
kcudnik merged 3 commits intosonic-net:masterfrom Jul 14, 2025
Merged
[meta] do not fail bulk operations if MODE_IGNORE_ERROR#1613kcudnik merged 3 commits intosonic-net:masterfrom
kcudnik merged 3 commits intosonic-net:masterfrom
Conversation
bulk operations do not continue when SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR is set and an error occurs. Create new check that considers the mode when validating bulk operations. Signed-off-by: Nikola Dancejic <[email protected]>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
approved these changes
Jun 17, 2025
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
Hi @kcudnik, if you approve of the changes can you help merge? |
prsunny
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jul 18, 2025
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED.
bobby-nexthop
pushed a commit
to bobby-nexthop/sonic-swss
that referenced
this pull request
Jul 24, 2025
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED.
mssonicbld
added a commit
to mssonicbld/sonic-swss.msft
that referenced
this pull request
Jul 31, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Check for specific SAI status codes instead of just `SAI_STATUS_NOT_EXECUTED` and respond accordingly **Why I did it** sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to `SAI_STATUS_NOT_EXECUTED`. **How I verified it** **Details if related**
prabhataravind
pushed a commit
to Azure/sonic-swss.msft
that referenced
this pull request
Jul 31, 2025
<!-- Please make sure you have read and understood the contribution guildlines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md 1. Make sure your commit includes a signature generted with `git commit -s` 2. Make sure your commit title follows the correct format: [component]: description 3. Make sure your commit message contains enough details about the change and related tests 4. Make sure your pull request adds related reviewers, asignees, labels Please also provide the following information in this pull request: --> **What I did** Check for specific SAI status codes instead of just `SAI_STATUS_NOT_EXECUTED` and respond accordingly **Why I did it** sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to `SAI_STATUS_NOT_EXECUTED`. **How I verified it** **Details if related**
rlhui
pushed a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Aug 18, 2025
…ort bulk update mode (#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
Contributor
|
@Ndancejic Can you raise a PR to 202411? |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 20, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
lizhijianrd
pushed a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Oct 20, 2025
…pport bulk update mode (#769) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Summary: Fixes # 20231 ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. #### How did you do it? Some of the message format has slightly changed even though the meaning itself remains the same. I moved the regex to the ignore list so that the check will pass with both versions of sairedis. #### How did you verify/test it? I validated the changes by running test_duplicate_route.py with the new image and with the old image. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.
Ndancejic
added a commit
to Ndancejic/sonic-sairedis
that referenced
this pull request
Oct 28, 2025
…c-net#1613)" This reverts commit fb5652b.
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED.
balanokia
pushed a commit
to balanokia/sonic-swss
that referenced
this pull request
Nov 17, 2025
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED.
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: opcoder0 <[email protected]>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: opcoder0 <[email protected]>
prsunny
pushed a commit
that referenced
this pull request
Dec 11, 2025
mssonicbld
added a commit
to mssonicbld/sonic-sairedis
that referenced
this pull request
Dec 11, 2025
…c-net#1613)" This commit caused failures in test_duplicate_route. This reverts commit fb5652b.
vikram-nexthop
pushed a commit
to nexthop-ai/sonic-sairedis
that referenced
this pull request
Dec 12, 2025
…c-net#1613)" (sonic-net#1676) This reverts commit fb5652b. Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" sonic-net#1676 Signed-off-by: Vikram Menon <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: Guy Shemesh <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Aharon Malkin <[email protected]>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: Aharon Malkin <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: Guy Shemesh <[email protected]>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.
croos12
pushed a commit
to croos12/sonic-sairedis
that referenced
this pull request
Jan 14, 2026
…c-net#1613)" (sonic-net#1676) This reverts commit fb5652b. Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" sonic-net#1676
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Guy Shemesh <[email protected]>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: Guy Shemesh <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Yael Tzur <[email protected]>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…de (sonic-net#20357) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list. Signed-off-by: Yael Tzur <[email protected]>
theasianpianist
added a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Feb 4, 2026
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED. Signed-off-by: Lawrence Lee <[email protected]>
baorliu
pushed a commit
to baorliu/sonic-swss
that referenced
this pull request
Feb 23, 2026
What I did Check for specific SAI status codes instead of just SAI_STATUS_NOT_EXECUTED and respond accordingly Why I did it sonic-net/sonic-sairedis#1613 means that SAI should return accurate states codes for each entry in a bulk operation. Prior to this change, any failure in a bulk op meant the status for all objects involved was set to SAI_STATUS_NOT_EXECUTED. Signed-off-by: Baorong Liu <[email protected]>
mssonicbld
added a commit
that referenced
this pull request
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bulk operations do not continue when SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR is set and an error occurs. Create new check that considers the mode when validating bulk operations.
fixes a crash in sonic-net/sonic-buildimage#21243 because route entries that are not removed in syncd by bulker are assumed to be removed in orchagent. Then when the nexthops are attempting to be removed, orchagent crashes due to OBJECT_IN_USE.