[action] [PR:1676] Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (#1613)"#1726
Merged
mssonicbld merged 6 commits intosonic-net:202511from Feb 25, 2026
Merged
Conversation
…c-net#1613)" This commit caused failures in test_duplicate_route. This reverts commit fb5652b.
Collaborator
Author
|
Original PR: #1676 |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| status = meta_generic_validation_get(meta_key, attr_count[idx], attr_list[idx]); | ||
|
|
||
| CHECK_STATUS_SUCCESS_MODE(status, mode); | ||
| // FIXME: This macro returns on failure. |
Check notice
Code scanning / CodeQL
FIXME comment Note
|
@Ndancejic, 1 test failed on this PR - [ FAILED ] FlexCounter.bulkChunksize @vmittal-msft - FYI |
Contributor
|
/azpw run |
Collaborator
Author
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjchadaga
approved these changes
Feb 25, 2026
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit caused failures in test_duplicate_route.
This reverts commit fb5652b.