[meta] Continue bulk operations if MODE_IGNORE_ERROR and skip entries that fail validation#1780
Open
markx-arista wants to merge 1 commit intosonic-net:masterfrom
Open
Conversation
Author
|
@prsunny, FYI. |
markx-arista
changed the title
markx-arista
changed the title
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
markx-arista
force-pushed
the
fix-meta-layer-bulk-operations
branch
from
81b42ed to
7eaa7b3
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
markx-arista
force-pushed
the
fix-meta-layer-bulk-operations
branch
from
7eaa7b3 to
5e131e8
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PR1613 was proposed to ignore errors during bulk operations if SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR is set. But it was reverted as it caused regression in test_duplicate_route.py because validation errors are ignored and some SAI can successfully add duplicated route. Later, createObject will be called on already existed entries in meta_generic_validation_post_create, and throws a fatal runtime_error exception. This fix removes entries that fail validation checks before passing to SAI during bulk operations with SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR, and populates object_statuses with validation results for those entries. Signed-off-by: markxiao <markxiao@arista.com>
markx-arista
force-pushed
the
fix-meta-layer-bulk-operations
branch
from
5e131e8 to
b1def83
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR1613 was proposed to ignore errors during bulk operations if SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR is set. But it was reverted as it caused regression in test_duplicate_route.py because validation errors are ignored and some SAI can successfully add duplicated route. Later, createObject will be called on already existed entries in meta_generic_validation_post_create, and throws a fatal runtime_error exception.
This fix removes entries that fail validation checks before passing to SAI during bulk operations with SAI_BULK_OP_ERROR_MODE_IGNORE_ERROR, and populates object_statuses with validation results for those entries.