Update expect_regex in test_duplicate_route to support bulk update mode#20232
Merged
rlhui merged 1 commit intosonic-net:masterfrom Aug 18, 2025
Merged
Update expect_regex in test_duplicate_route to support bulk update mode#20232rlhui merged 1 commit intosonic-net:masterfrom
rlhui merged 1 commit intosonic-net:masterfrom
Conversation
…ort bulk update mode
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rlhui
approved these changes
Aug 16, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: |
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Aug 20, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
Collaborator
|
Cherry-pick PR to 202505: #20329 |
Merged
11 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Aug 20, 2025
…ort bulk update mode (#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
mssonicbld
added
Included in 202505 branch
and removed
Created PR to 202505 branch
labels
Contributor
|
@eswaran-nexthop your PR is blocking PR test, I created a revert PR #20334, please fix and re-submit |
nikamirrr
pushed a commit
to nikamirrr/nmirin-sonic-mgmt
that referenced
this pull request
Aug 20, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
echuawu
pushed a commit
to echuawu/sonic-mgmt
that referenced
this pull request
Aug 25, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
mssonicbld
added a commit
to mssonicbld/sonic-mgmt.msft
that referenced
this pull request
Oct 20, 2025
…pdate mode" Reverts sonic-net/sonic-mgmt#20232 since it's blocking PR test
lizhijianrd
pushed a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Oct 20, 2025
…te to support bulk update mode" (#767) Reverts sonic-net/sonic-mgmt#20232 since it's blocking PR test
vidyac86
pushed a commit
to vidyac86/sonic-mgmt
that referenced
this pull request
Oct 23, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Dec 16, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Aharon Malkin <amalkin@nvidia.com>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
…ort bulk update mode (sonic-net#20232) The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks. The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change. Summary: Fixes # 20231 Signed-off-by: Yael Tzur <ytzur@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.
The fix is to update the regexes so that the test can continue to pass with and without this sonic-sairedis change.
Summary:
Fixes # 20231
Type of change
Back port request
Approach
What is the motivation for this PR?
The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.
How did you do it?
Some of the message format has slightly changed even though the meaning itself remains the same. Where I could I modified the regex so that the check will pass with both versions of sairedis. For the new ones, I have included them in ignoreRegex. In future, we could move them to the expected list.
How did you verify/test it?
I validated the changes by running test_duplicate_route.py with the new image.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation