Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (#1613)"#1676
Merged
prsunny merged 7 commits intosonic-net:masterfrom Dec 11, 2025
Merged
Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (#1613)"#1676prsunny merged 7 commits intosonic-net:masterfrom
prsunny merged 7 commits intosonic-net:masterfrom
Conversation
…c-net#1613)" This reverts commit fb5652b.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| status = meta_generic_validation_get(meta_key, attr_count[idx], attr_list[idx]); | ||
|
|
||
| CHECK_STATUS_SUCCESS_MODE(status, mode); | ||
| // FIXME: This macro returns on failure. |
Check notice
Code scanning / CodeQL
FIXME comment Note
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
reviewed
Oct 30, 2025
Contributor
lolyu
left a comment
lolyu
left a comment
There was a problem hiding this comment.
what's the plan for the crm failure after reverting this PR?
11 tasks
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prsunny
approved these changes
Dec 11, 2025
Collaborator
|
Cherry-pick PR to msft-202506: |
Collaborator
|
Cherry-pick PR to 202511: #1726 |
vikram-nexthop
pushed a commit
to nexthop-ai/sonic-sairedis
that referenced
this pull request
Dec 12, 2025
…c-net#1613)" (sonic-net#1676) This reverts commit fb5652b. Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" sonic-net#1676 Signed-off-by: Vikram Menon <vikram@nexthop.ai>
croos12
pushed a commit
to croos12/sonic-sairedis
that referenced
this pull request
Jan 14, 2026
…c-net#1613)" (sonic-net#1676) This reverts commit fb5652b. Revert "[meta] do not fail bulk operations if MODE_IGNORE_ERROR (sonic-net#1613)" sonic-net#1676
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit caused failures in test_duplicate_route.
This reverts commit fb5652b.