Skip to content

Update ignore_regex in test_duplicate_route to support bulk update mode - #20357

Merged
rlhui merged 1 commit into
sonic-net:masterfrom
eswaran-nexthop:eswaran-20231-2
Aug 27, 2025
Merged

Update ignore_regex in test_duplicate_route to support bulk update mode#20357
rlhui merged 1 commit into
sonic-net:masterfrom
eswaran-nexthop:eswaran-20231-2

Conversation

@eswaran-nexthop

@eswaran-nexthop eswaran-nexthop commented Aug 21, 2025

Copy link
Copy Markdown
Contributor

Description of PR

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.

Summary:
Fixes # 20231

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Approach

What is the motivation for this PR?

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

How did you do it?

Some of the message format has slightly changed even though the meaning itself remains the same. I moved the regex to the ignore list so that the check will pass with both versions of sairedis.

How did you verify/test it?

I validated the changes by running test_duplicate_route.py with the new image and with the old image.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@eswaran-nexthop
eswaran-nexthop marked this pull request as ready for review August 21, 2025 20:41
@mssonicbld

mssonicbld commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 21, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eswaran-nexthop eswaran-nexthop mentioned this pull request Aug 21, 2025
Open
@eswaran-nexthop

eswaran-nexthop commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

Checks seem to be failing due to some interaction with this commit - 5f017fe

Needs more investigation

Ndancejic
Ndancejic requested changes Aug 21, 2025
View reviewed changes
Comment thread tests/route/test_duplicate_route.py Outdated
@eswaran-nexthop

eswaran-nexthop commented Aug 22, 2025

Copy link
Copy Markdown
Contributor Author

@Ndancejic @prsunny I suspect the checks failing here are unrelated.

From the test runs, I see PR_CHECKERS are set correctly

+ PR_CHECKERS='["t0_checker","t1-multi-asic_checker","t1_checker","t2_checker"]'

But I see the other checkers are running and failing as we would expect. I think the recent commit to this area c08ca93 could be causing it? After the template change, the condition

condition: contains(dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS']

is not applied for each checker correctly. We should not expect the dpu, dualtor, etc checkers to run for this PR.

Any suggestions on how we can get this fixed?

@Ndancejic

Ndancejic commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

/azpw run

@mssonicbld

mssonicbld commented Aug 25, 2025

Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines

azure-pipelines Bot commented Aug 25, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@Ndancejic

Ndancejic commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

@Ndancejic @prsunny I suspect the checks failing here are unrelated.

From the test runs, I see PR_CHECKERS are set correctly

+ PR_CHECKERS='["t0_checker","t1-multi-asic_checker","t1_checker","t2_checker"]'

But I see the other checkers are running and failing as we would expect. I think the recent commit to this area c08ca93 could be causing it? After the template change, the condition

condition: contains(dependencies.get_impacted_area.outputs['SetVariableTask.PR_CHECKERS']

is not applied for each checker correctly. We should not expect the dpu, dualtor, etc checkers to run for this PR.

Any suggestions on how we can get this fixed?

Looks like there was an update that was merged afterwards: #20335 reran the pipeline to try it out

@mssonicbld

mssonicbld commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 26, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@eswaran-nexthop

eswaran-nexthop commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

azure-pipelines Bot commented Aug 26, 2025

Copy link
Copy Markdown
Commenter does not have sufficient privileges for PR 20357 in repo sonic-net/sonic-mgmt

@eswaran-nexthop

eswaran-nexthop commented Aug 26, 2025

Copy link
Copy Markdown
Contributor Author

The kvmtest-t2 check failed because of testbed availability

Error type: LOCK_TESTBED_FAILED
Error message: Lock testbed wait timeout: 7200s

Needs a re-run

@rlhui

rlhui commented Aug 26, 2025

Copy link
Copy Markdown

/azpw run

@mssonicbld

mssonicbld commented Aug 26, 2025

Copy link
Copy Markdown
Collaborator

/AzurePipelines run

@azure-pipelines

azure-pipelines Bot commented Aug 27, 2025

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@rlhui
rlhui merged commit d93cb89 into sonic-net:master Aug 27, 2025
18 of 20 checks passed
lizhijianrd pushed a commit to lizhijianrd/sonic-mgmt that referenced this pull request Oct 20, 2025
@eswaran-nexthop @lizhijianrd
Update ignore_regex in test_duplicate_route to support bulk update mo…
02749ba 
…de (sonic-net#20357)

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.
@lizhijianrd lizhijianrd mentioned this pull request Oct 20, 2025
Merged
11 tasks
@mssonicbld

mssonicbld commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

@eswaran-nexthop PR conflicts with 202505 branch

@lizhijianrd

lizhijianrd commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Backport 202505: #21030

@mssonicbld mssonicbld mentioned this pull request Oct 20, 2025
Merged
11 tasks
@mssonicbld

mssonicbld commented Oct 20, 2025

Copy link
Copy Markdown
Collaborator

Cherry-pick PR to msft-202509: Azure/sonic-mgmt.msft#769

yejianquan pushed a commit that referenced this pull request Oct 23, 2025
@lizhijianrd @xwjiang-ms @eswaran-nexthop
[202505] Backport recent PRs and update skip condition for test_dupli…
2b32689 
…cate_routes (#21030)

Description of PR
Summary:
test_duplicate_routes is expected to run and pass on 202505 branch

Backport PR Revert "Update expect_regex in test_duplicate_route to support bulk update mode" #20334 and Update ignore_regex in test_duplicate_route to support bulk update mode #20357
Update skip condition to Regression: test_duplicate_route.py failing log checks after sairedis update #20231

Co-authored-by: xwjiang-ms <96218837+xwjiang-ms@users.noreply.github.com>
Co-authored-by: eswaran-nexthop <eswaran@nexthop.ai>
opcoder0 pushed a commit to opcoder0/sonic-mgmt that referenced this pull request Dec 8, 2025
@eswaran-nexthop
Update ignore_regex in test_duplicate_route to support bulk update mo…
30d659b 
…de (sonic-net#20357)

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.

Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Dec 21, 2025
@eswaran-nexthop @gshemesh2
Update ignore_regex in test_duplicate_route to support bulk update mo…
7e2c33c 
…de (sonic-net#20357)

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop pushed a commit to venu-nexthop/sonic-mgmt that referenced this pull request Jan 13, 2026
@eswaran-nexthop @venu-nexthop
Update ignore_regex in test_duplicate_route to support bulk update mo…
7f3f33a 
…de (sonic-net#20357)

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.
gshemesh2 pushed a commit to gshemesh2/sonic-mgmt that referenced this pull request Jan 26, 2026
@eswaran-nexthop @gshemesh2
Update ignore_regex in test_duplicate_route to support bulk update mo…
bb80833 
…de (sonic-net#20357)

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.

Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1 pushed a commit to ytzur1/sonic-mgmt that referenced this pull request Feb 2, 2026
@eswaran-nexthop @ytzur1
Update ignore_regex in test_duplicate_route to support bulk update mo…
c12df7e 
…de (sonic-net#20357)

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.

Signed-off-by: Yael Tzur <ytzur@nvidia.com>
arawat-nexthop pushed a commit to nexthop-ai/sonic-mgmt that referenced this pull request Apr 9, 2026
@eswaran-nexthop
NOS-158 Update expect logre instead of ignore logre for test_duplicat…
dd62b40 
…e_route.py (sonic-net#582)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit
easier:
-->
### Description of PR
In a previous PR - 
[Update ignore_regex in test_duplicate_route to support bulk update mode
by eswaran-nexthop · Pull Request sonic-net#20357 ·
sonic-net/sonic-mgmt](https://github.com/sonic-net/sonic-mgmt/pull/20357/files),
I had moved all expect logres to ignore logre so that a sairedis repo
change can merge. This test needs to have the regexes updated, now that
the original issue has been fixed.

Summary:
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [x] Test case improvement


### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505

### Approach
#### What is the motivation for this PR?

#### How did you do it?

#### How did you verify/test it?

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
rraghav-cisco pushed a commit to rraghav-cisco/sonic-mgmt that referenced this pull request Apr 20, 2026
@eswaran-nexthop @rraghav-cisco
Update ignore_regex in test_duplicate_route to support bulk update mo…
a095efe 
…de (sonic-net#20357)

The sonic-sairedis change from sonic-net/sonic-sairedis#1613 modified the behavior of BULK operations which resulted in the log spew looking different before and after on API failures. This impacts test_duplicate_route.py. As this test is failing with the above sonic-sairedis change included, sonic-buildimage PRs that bump up the submodule reference fail pipeline checks.

The fix is to move all regexes to the ignore list so that the test can continue to pass with and without this sonic-sairedis change. Once the sairedis change merges, we can change the ignore list to the expect list.

Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prsunny prsunny prsunny approved these changes
@Ndancejic Ndancejic Ndancejic approved these changes
@rlhui rlhui rlhui approved these changes

Assignees

No one assigned

Labels

Approved for msft-202509 Branch Approved for 202505 branch Created PR to 202505 branch Included in msft-202509 Branch Request for msft-202509 Branch Request for 202505 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eswaran-nexthop @mssonicbld @Ndancejic @rlhui @lizhijianrd @prsunny