[T2 chassis] platform tests that uses pdu_controller to run on sup for chassis #8646
Merged
wenyiz2021 merged 5 commits intosonic-net:masterfrom Jun 20, 2023
Merged
[T2 chassis] platform tests that uses pdu_controller to run on sup for chassis #8646wenyiz2021 merged 5 commits intosonic-net:masterfrom
wenyiz2021 merged 5 commits intosonic-net:masterfrom
Conversation
Contributor
Author
|
@arlakshm can you please review? |
arlakshm
approved these changes
Jun 20, 2023
Contributor
arlakshm
left a comment
arlakshm
left a comment
There was a problem hiding this comment.
lgtm.. can please confirm if these test work on single asic pizzaboxes?
Contributor
Author
thanks @arlakshm , I verified this on single-asic linecard as well |
6 tasks
Collaborator
|
@wenyiz2021 PR conflicts with 202205 branch |
wenyiz2021
changed the title
6 tasks
This was referenced Jul 10, 2023
wangxin
pushed a commit
that referenced
this pull request
Jul 11, 2023
6 tasks
Merged
6 tasks
6 tasks
yaqiangz
added a commit
that referenced
this pull request
Jul 21, 2023
What is the motivation for this PR? Skip condition for 7215 and 1031 failed in this case due to #8646 How did you do it? Modify skip condition. How did you verify/test it? Run tests. Signed-off-by: Yaqiang Zhu <[email protected]>
yaqiangz
added a commit
to yaqiangz/sonic-mgmt
that referenced
this pull request
Jul 27, 2023
…onic-net#9085) What is the motivation for this PR? Skip condition for 7215 and 1031 failed in this case due to sonic-net#8646 How did you do it? Modify skip condition. How did you verify/test it? Run tests. Signed-off-by: Yaqiang Zhu <[email protected]>
6 tasks
wangxin
pushed a commit
that referenced
this pull request
Jul 28, 2023
…9085) (#9149) What is the motivation for this PR? Manually cherry-pick and resolve conflicts of this PR: #9085 Skip condition for 7215 and 1031 failed in this case due to #8646 How did you do it? Modify skip condition. How did you verify/test it? Run tests. Signed-off-by: Yaqiang Zhu <[email protected]>
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
…on sup for chassis (sonic-net#8646) * pdu_controller runs on SUP if chassis, else choose a random dut * corresponding platform tests that use pdu_controller also gets update * refactor out test_power_off_reboot.py
StormLiangMS
pushed a commit
to StormLiangMS/sonic-mgmt
that referenced
this pull request
Dec 16, 2023
test_power_off_reboot will fail due to sonic-net#8646 This PR is to fix that and sync setting for testbed-str2-pikez-acs-1 from internal-202205
7 tasks
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…on sup for chassis (sonic-net#8646) * pdu_controller runs on SUP if chassis, else choose a random dut * corresponding platform tests that use pdu_controller also gets update * refactor out test_power_off_reboot.py
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…t#9085) What is the motivation for this PR? Skip condition for 7215 and 1031 failed in this case due to sonic-net#8646 How did you do it? Modify skip condition. How did you verify/test it? Run tests. Signed-off-by: Yaqiang Zhu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
utilities.py: implement a function
get_sup_node_or_random_nodefor chassis whose pdu info is only avail on sup.Note that here we don't use
enum_supervisor_dut_hostname, because platform_tests/conftest.py have a autouse fixtureskip_on_simxthat makes all platform tests use rand_one_dut_hostname.accomondate other platform tests who uses fixture pdu_controller also need same function implementation and usage.
refactor out
test_power_off_rebootfromtest_reboot.py, this whole file has autosue fixtureteardown_modulebase onenum_rand_one_per_hwsku_hostnameSummary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
accomodate for T2 chassis
How did you do it?
How did you verify/test it?
run on Arista chassis
Any platform specific information?
this will not impact other platforms
Supported testbed topology if it's a new test case?
Documentation