Skip to content

[plt_reboot_dict] auto use fixture set_max_for_interfaces in reboot tests#8938

Merged
wenyiz2021 merged 2 commits intosonic-net:masterfrom
wenyiz2021:reboot_transceiver_masic
Jul 13, 2023
Merged

[plt_reboot_dict] auto use fixture set_max_for_interfaces in reboot tests#8938
wenyiz2021 merged 2 commits intosonic-net:masterfrom
wenyiz2021:reboot_transceiver_masic

Conversation

@wenyiz2021
Copy link
Copy Markdown
Contributor

Description of PR

PR #8646 added default argument interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES in check_interfaces_and_services,
with this interfaces_wait_time is getting directly from MAX_WAIT_TIME_FOR_INTERFACES, while this function has not yet called fixture set_max_time_for_interfaces.

change fixture set_max_time_for_interfaces to autouse fixture as we need it throughout test module
Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

before:

  File "/azp/_work/65/s/tests/platform_tests/test_reboot.py", line 112, in check_interfaces_and_services
    interfaces_wait_time)
AssertionError: Not all transceivers are detected or interfaces are up in 300 seconds

after:

18:58:16 reboot.reboot                            L0255 INFO   | DUT str2-7804-lc7-1 up since 2023-07-12 18:55:52
18:58:16 test_reboot.reboot_and_check             L0082 INFO   | Append the latest reboot type to the queue
18:58:16 test_reboot.check_interfaces_and_service L0101 INFO   | Wait until all critical services are fully started
18:58:16 processes_utils.wait_critical_processes  L0064 INFO   | Wait until all critical processes are healthy in 600 sec

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@wenyiz2021 wenyiz2021 merged commit b61823b into sonic-net:master Jul 13, 2023
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 20, 2023
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202205: #9065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants