Skip to content

[platform][reboot] Fix test_power_off_reboot failed in 7215#9085

Merged
yaqiangz merged 2 commits intosonic-net:masterfrom
yaqiangz:azure-master_fix_reboot
Jul 21, 2023
Merged

[platform][reboot] Fix test_power_off_reboot failed in 7215#9085
yaqiangz merged 2 commits intosonic-net:masterfrom
yaqiangz:azure-master_fix_reboot

Conversation

@yaqiangz
Copy link
Contributor

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205

Approach

What is the motivation for this PR?

Skip condition for 7215 and 1031 failed in this case due to #8646

How did you do it?

Modify skip condition.

How did you verify/test it?

Run tests.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...............................................................Passed
check for added large files..............................................Passed
check python ast.....................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
check conditional mark sort..............................................Failed
- hook id: check-conditional-mark-sort
- exit code: 1

The entries in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_acl.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_drop_packets.yaml tests/common/plugins/conditional_mark/tests_mark_conditions_platform_tests.yaml are not sorted in alphabetic order.

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

@mssonicbld
Copy link
Collaborator

@yaqiangz PR conflicts with 202205 branch

yaqiangz added a commit to yaqiangz/sonic-mgmt that referenced this pull request Jul 27, 2023
…onic-net#9085)

What is the motivation for this PR?
Skip condition for 7215 and 1031 failed in this case due to sonic-net#8646

How did you do it?
Modify skip condition.

How did you verify/test it?
Run tests.

Signed-off-by: Yaqiang Zhu <[email protected]>
wangxin pushed a commit that referenced this pull request Jul 28, 2023
…9085) (#9149)

What is the motivation for this PR?
Manually cherry-pick and resolve conflicts of this PR: #9085
Skip condition for 7215 and 1031 failed in this case due to #8646

How did you do it?
Modify skip condition.

How did you verify/test it?
Run tests.

Signed-off-by: Yaqiang Zhu <[email protected]>
@yaqiangz
Copy link
Contributor Author

@yaqiangz PR conflicts with 202205 branch

Merged #9149

AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
…t#9085)

What is the motivation for this PR?
Skip condition for 7215 and 1031 failed in this case due to sonic-net#8646

How did you do it?
Modify skip condition.

How did you verify/test it?
Run tests.

Signed-off-by: Yaqiang Zhu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants