[platform_tests] Fix test_reboot reboot_type passed as interfaces_wait_time

[andywongarista]

Description of PR

Summary:
Fixes # (issue)

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 201911
• 202012
• 202205

Approach

What is the motivation for this PR?

#8646 introduces regression in which a new arg is added to check_interfaces_and_services but the call made from reboot_and_check is not updated to handle the new arg.

This regression causes all of test_reboot.py to fail.

How did you do it?

Fix call in reboot_and_check.

How did you verify/test it?

Tested on arista device.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[andywongarista]

@wenyiz2021 FYI

[wenyiz2021]

hi @andywongarista thanks for the fix.
can we change the new argument to end of function?
def check_interfaces_and_services(dut, interfaces, xcvr_skip_list,
interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES, reboot_type=None):

to

def check_interfaces_and_services(dut, interfaces, xcvr_skip_list,
reboot_type=None, interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES):

[wenyiz2021]

hi @andywongarista thanks for the fix. can we change the new argument to end of function? def check_interfaces_and_services(dut, interfaces, xcvr_skip_list, interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES, reboot_type=None):

to

def check_interfaces_and_services(dut, interfaces, xcvr_skip_list, reboot_type=None, interfaces_wait_time=MAX_WAIT_TIME_FOR_INTERFACES):

nvm, seems only 2 places pass defaul arguments. this change LGTM.

[mssonicbld]

Cherry-pick PR to 202205: #8771