[chassis] accommodate snmp test that uses pdu controller for chassis#8674
Merged
wenyiz2021 merged 7 commits intosonic-net:masterfrom Jun 26, 2023
Merged
[chassis] accommodate snmp test that uses pdu controller for chassis#8674wenyiz2021 merged 7 commits intosonic-net:masterfrom
wenyiz2021 merged 7 commits intosonic-net:masterfrom
Conversation
| :return: | ||
| """ | ||
| duthost = duthosts[enum_rand_one_per_hwsku_hostname] | ||
| duthost = duthosts[enum_supervisor_dut_hostname] |
Contributor
There was a problem hiding this comment.
The change seems ok.
Shouldn't skip handle this scenario, why do we need to run only on supervisor?
Contributor
Author
There was a problem hiding this comment.
old behavior should also be fine.
old:
for chassis it choose sup and cards, but cards were skipped
new:
for chassis it choose sup only
the only pros is we can avoid some skipped tests in pipeline result.
arlakshm
approved these changes
Jun 26, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Jun 29, 2023
…onic-net#8674) * Update test_snmp_phy_entity.py to run on sup for chassis, other testbeds choose random dut(dualtor) or itself(single-dut)
Collaborator
|
Cherry-pick PR to 202205: #8766 |
Merged
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Jun 29, 2023
…8674) * Update test_snmp_phy_entity.py to run on sup for chassis, other testbeds choose random dut(dualtor) or itself(single-dut)
mssonicbld
added
Included in 202205 branch
and removed
Created PR to 202205 branch
labels
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
…onic-net#8674) * Update test_snmp_phy_entity.py to run on sup for chassis, other testbeds choose random dut(dualtor) or itself(single-dut)
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…onic-net#8674) * Update test_snmp_phy_entity.py to run on sup for chassis, other testbeds choose random dut(dualtor) or itself(single-dut)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
pdu controller needs to be done on sup for chassis, for other topo it just choose a random dut or itself, this is done in #8646
for all other tests that uses pdu_controller, we also need to call it on sup for chassis.
This PR is to fix the only snmp test that calls pdu_controller
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation